You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "kwin (via GitHub)" <gi...@apache.org> on 2024/03/01 16:20:20 UTC

[PR] Feature/update parent [sling-org-apache-sling-event]

kwin opened a new pull request, #37:
URL: https://github.com/apache/sling-org-apache-sling-event/pull/37

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Feature/update parent [sling-org-apache-sling-event]

Posted by "stefan-egli (via GitHub)" <gi...@apache.org>.
stefan-egli commented on PR #37:
URL: https://github.com/apache/sling-org-apache-sling-event/pull/37#issuecomment-2442081668

   I will have a look when I find time. In the meantime if anyone else can jump in, feel free to do so.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Feature/update parent [sling-org-apache-sling-event]

Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #37:
URL: https://github.com/apache/sling-org-apache-sling-event/pull/37#issuecomment-2443449189

   ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-event&pullRequest=37) **Quality Gate failed**  
   Failed conditions  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/failed-16px.png '') [53.3% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event&pullRequest=37&metric=new_coverage&view=list) (required ≥ 80%)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/failed-16px.png '') [C Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-event&pullRequest=37) (required ≥ A)  
     
   [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-event&pullRequest=37)
   
   ##   
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/light_bulb-16px.png '') Catch issues before they fail your Quality Gate with our IDE extension ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/sonarlint-16px.png '') [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Feature/update parent [sling-org-apache-sling-event]

Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin closed pull request #37: Feature/update parent
URL: https://github.com/apache/sling-org-apache-sling-event/pull/37


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Feature/update parent [sling-org-apache-sling-event]

Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on PR #37:
URL: https://github.com/apache/sling-org-apache-sling-event/pull/37#issuecomment-3390995069

   Superseded by #47 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Feature/update parent [sling-org-apache-sling-event]

Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on PR #37:
URL: https://github.com/apache/sling-org-apache-sling-event/pull/37#issuecomment-2437571708

   The broken build currently prevents applying additional PRs....


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Feature/update parent [sling-org-apache-sling-event]

Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #37:
URL: https://github.com/apache/sling-org-apache-sling-event/pull/37#issuecomment-2442381688

   ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-event&pullRequest=37) **Quality Gate failed**  
   Failed conditions  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/failed-16px.png '') [53.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event&pullRequest=37&metric=new_coverage&view=list) (required ≥ 80%)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/failed-16px.png '') [C Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-event&pullRequest=37) (required ≥ A)  
     
   [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-event&pullRequest=37)
   
   ##   
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/light_bulb-16px.png '') Catch issues before they fail your Quality Gate with our IDE extension ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/sonarlint-16px.png '') [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Feature/update parent [sling-org-apache-sling-event]

Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on PR #37:
URL: https://github.com/apache/sling-org-apache-sling-event/pull/37#issuecomment-2442236426

   The first step would be to increase the logging in terms of which events are received and which ones are expected instead of just asserting the count.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Feature/update parent [sling-org-apache-sling-event]

Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on PR #37:
URL: https://github.com/apache/sling-org-apache-sling-event/pull/37#issuecomment-2437570425

   @stefan-egli I would love to get the CI back to green for this module, can you look at the failing test in https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-event/job/PR-37/8/console? I am not really familiar with the ITs in here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org