You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/01/28 09:34:36 UTC
[GitHub] [cloudstack] shwstppr opened a new pull request #4629: server: prevent update vm read-only details
shwstppr opened a new pull request #4629:
URL: https://github.com/apache/cloudstack/pull/4629
### Description
Fixes behaviour in updateVirtualMachine API by disallowing updating read-only details of the VM for accounts other than root-admin using API. Such read-only details will be copied from original values.
Fixes #4514
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [x] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [x] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4629: server: prevent update vm read-only details
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4629:
URL: https://github.com/apache/cloudstack/pull/4629#issuecomment-769600624
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4629: server: prevent update vm read-only details
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4629:
URL: https://github.com/apache/cloudstack/pull/4629#issuecomment-768929809
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4629: server: prevent update vm read-only details
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4629:
URL: https://github.com/apache/cloudstack/pull/4629#issuecomment-769610660
Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2619
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr removed a comment on pull request #4629: server: prevent update vm read-only details
Posted by GitBox <gi...@apache.org>.
shwstppr removed a comment on pull request #4629:
URL: https://github.com/apache/cloudstack/pull/4629#issuecomment-768929070
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4629: server: prevent update vm read-only details
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4629:
URL: https://github.com/apache/cloudstack/pull/4629#issuecomment-770691267
@weizhouapache I think changing global setting name would require DB change and doc changes, the feature/user of the change is only UI so I guess that's why the setting name has `ui` in it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4629: server: prevent update vm read-only details
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4629:
URL: https://github.com/apache/cloudstack/pull/4629#issuecomment-770843938
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland merged pull request #4629: server: prevent update vm read-only details
Posted by GitBox <gi...@apache.org>.
DaanHoogland merged pull request #4629:
URL: https://github.com/apache/cloudstack/pull/4629
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland merged pull request #4629: server: prevent update vm read-only details
Posted by GitBox <gi...@apache.org>.
DaanHoogland merged pull request #4629:
URL: https://github.com/apache/cloudstack/pull/4629
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4629: server: prevent update vm read-only details
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4629:
URL: https://github.com/apache/cloudstack/pull/4629#issuecomment-769600218
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4629: server: prevent update vm read-only details
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4629:
URL: https://github.com/apache/cloudstack/pull/4629#issuecomment-770742309
> @weizhouapache I think changing global setting name would require DB change and doc changes, the feature/user of the change is only UI so I guess that's why the setting name has `ui` in it.
> @shwstppr that PR also needs more attention to updates. I agree with the principle as this is not only UI but also API (which would be a security issue if it wasn't) as is this change lgtm
@rhtyd @DaanHoogland
let's merge this, and change setting name afterwards as it requires sql change ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4629: server: prevent update vm read-only details
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4629:
URL: https://github.com/apache/cloudstack/pull/4629#issuecomment-770871371
Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2627
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4629: server: prevent update vm read-only details
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4629:
URL: https://github.com/apache/cloudstack/pull/4629#issuecomment-771243702
<b>Trillian test result (tid-3462)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 30225 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4629-t3462-kvm-centos7.zip
Smoke tests completed. 83 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4629: server: prevent update vm read-only details
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4629:
URL: https://github.com/apache/cloudstack/pull/4629#issuecomment-770921233
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4629: server: prevent update vm read-only details
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4629:
URL: https://github.com/apache/cloudstack/pull/4629#issuecomment-771243702
<b>Trillian test result (tid-3462)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 30225 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4629-t3462-kvm-centos7.zip
Smoke tests completed. 83 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4629: server: prevent update vm read-only details
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4629:
URL: https://github.com/apache/cloudstack/pull/4629#issuecomment-768929809
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4629: server: prevent update vm read-only details
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4629:
URL: https://github.com/apache/cloudstack/pull/4629#issuecomment-768929070
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4629: server: prevent update vm read-only details
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4629:
URL: https://github.com/apache/cloudstack/pull/4629#issuecomment-768953153
Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2613
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4629: server: prevent update vm read-only details
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4629:
URL: https://github.com/apache/cloudstack/pull/4629#issuecomment-770696005
@weizhouapache maybe we can change setting name in master alongwith similar setting changes #4135? cc @rhtyd @DaanHoogland
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4629: server: prevent update vm read-only details
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4629:
URL: https://github.com/apache/cloudstack/pull/4629#issuecomment-770920329
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4629: server: prevent update vm read-only details
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4629:
URL: https://github.com/apache/cloudstack/pull/4629#issuecomment-770727694
@shwstppr that PR also needs more attention to updates. I agree with the principle as this is not only UI but also API (which would be a security issue if it wasn't) as is this change lgtm
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4629: server: prevent update vm read-only details
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4629:
URL: https://github.com/apache/cloudstack/pull/4629#issuecomment-769666240
@shwstppr good, thanks.
should the detail name be changed from 'user.vm.readonly.ui.details' to 'user.vm.readonly.details' ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4629: server: prevent update vm read-only details
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4629:
URL: https://github.com/apache/cloudstack/pull/4629#issuecomment-770844612
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org