You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2021/03/26 20:22:03 UTC

[GitHub] [helix] pkuwm commented on issue #1688: Add an option to always perform all checks in Helix stoppable check API

pkuwm commented on issue #1688:
URL: https://github.com/apache/helix/issues/1688#issuecomment-808487803


   > I think we need to communicate a little bit more about motivation.
   > 
   > 1. Why stage 1 Helix checks are not valid for applications. Is it fixable? Or it is fundamentally not applied.
   > 2. Can we just let users to opt-out of the stage 1 checkup if they are not applicable? In this case, we do not waste resources to run a set of invalid checks.
   > 3. If all the above options are not possible, do we really need to make it an option instead of just make it the default behavior?
   
   @jiajunwang Thanks for the questions.
   For example, customers have a deployment during rebalance.  During the deployment, they want to ignore INSTANCE_NOT_STABLE failure. This is because custom has state transition cancellation feature enabled, they want to stop an instance even if there is state transition going on. They only ignore certain checks and if they are the only ones that failed, then they treat it as stoppable. 
   So they want all checks to determine if the instance is stoppable for this case.
   For the other cases, we helix don’t have to do all checks. The current logic is still valid, if helix own fails, no need to further check custom.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org