You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by ludop-usharesoft <gi...@git.apache.org> on 2018/10/09 14:21:40 UTC

[GitHub] brooklyn-ui pull request #81: Fix firefox multi-lines issue in configuration...

GitHub user ludop-usharesoft opened a pull request:

    https://github.com/apache/brooklyn-ui/pull/81

    Fix firefox multi-lines issue in configuration text-area

    Fix firefox multi-lines issue in configuration text-area in the blueprint composer
    
    - replace white-space "nowrap" by "pre" otherwise firefox doesn't display new lines
    - handle shift+enter (in addition to ctrl+enter and option+enter) to create a new line
    - avoid javascript error when the input is empty and new line is inserted
    
    Signed-off-by: Ludovic Plantin <lu...@usharesoft.com>
    
    Signed-off-by: Ludovic Plantin <lu...@usharesoft.com>

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/usharesoft/brooklyn-ui firefox-multiline

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-ui/pull/81.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #81
    
----
commit df6b98ddc954cc41a31aad4f513c950a31530b79
Author: Ludovic Plantin <lu...@...>
Date:   2018-10-09T14:02:19Z

    Correct firefox multi-lines issue on configuration text-area in the blueprint composer
    
    - replace white-space "nowrap" by "pre" otherwise firefox doesn't display new lines
    - handle shift+enter (in addition to ctrl+enter and option+enter) to create a new line
    - avoid javascript error when the input is empty and new line is inserted
    
    Signed-off-by: Ludovic Plantin <lu...@usharesoft.com>

----


---

[GitHub] brooklyn-ui pull request #81: Fix firefox multi-lines issue in configuration...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/brooklyn-ui/pull/81


---

[GitHub] brooklyn-ui issue #81: Fix firefox multi-lines issue in configuration text-a...

Posted by ludop-usharesoft <gi...@git.apache.org>.
Github user ludop-usharesoft commented on the issue:

    https://github.com/apache/brooklyn-ui/pull/81
  
    Thanks Thomas ;-)
    It's ok for the ICLA, I have signed it (the 14th of June).


---

[GitHub] brooklyn-ui issue #81: Fix firefox multi-lines issue in configuration text-a...

Posted by tbouron <gi...@git.apache.org>.
Github user tbouron commented on the issue:

    https://github.com/apache/brooklyn-ui/pull/81
  
    Tested on both Firefox and Chrome, works like a charm! Thank you @ludop-usharesoft 👍 
    
    I'll merge this now. In the meantime, can you make sure you sign your ICLA? Thanks again!


---