You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by vincentWangKB <gi...@git.apache.org> on 2017/08/08 04:40:31 UTC
[GitHub] incubator-rocketmq-externals pull request #27: add rocketmq-cpp code
GitHub user vincentWangKB opened a pull request:
https://github.com/apache/incubator-rocketmq-externals/pull/27
add rocketmq-cpp code
add rocketmq-cpp code
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vincentWangKB/incubator-rocketmq-externals master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rocketmq-externals/pull/27.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #27
----
commit a27f12ef39669b44dd2fd7d75cde2d216b66dad5
Author: qiwei.wqw <qi...@alibaba-inc.com>
Date: 2017-08-08T02:55:19Z
upload rocketmq-cpp code
commit db2805af2b65a4139170ef270b1c1db094cd2a36
Author: qiwei.wqw <qi...@alibaba-inc.com>
Date: 2017-08-08T02:56:24Z
remove unused boost file
commit a5e224a39410e13f672303360e992eec5016dc67
Author: qiwei.wqw <qi...@alibaba-inc.com>
Date: 2017-08-08T02:58:40Z
update README.md
commit 683d3fb08db826d262a464fd702d5913892e13b9
Author: vincentWangKB <30...@users.noreply.github.com>
Date: 2017-08-08T04:35:20Z
update readme.md
commit d85f171c0fb6f5d1dbcbb9a6d71025d6478589f7
Author: vincentWangKB <30...@users.noreply.github.com>
Date: 2017-08-08T04:36:41Z
update readme.md
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq-externals issue #27: add rocketmq-cpp code
Posted by vincentWangKB <gi...@git.apache.org>.
Github user vincentWangKB commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/27
For build and install, cmake and Makefile are all supported on linux platform now. Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq-externals issue #27: add rocketmq-cpp code
Posted by lizhanhui <gi...@git.apache.org>.
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/27
A second issue about alog, there are only header files and binary static lib file, where is source code for the static lib files?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq-externals pull request #27: [ROCKETMQ-268]add rocketmq-cp...
Posted by vincentWangKB <gi...@git.apache.org>.
Github user vincentWangKB closed the pull request at:
https://github.com/apache/incubator-rocketmq-externals/pull/27
---
[GitHub] incubator-rocketmq-externals issue #27: [ROCKETMQ-268]add rocketmq-cpp code
Posted by vincentWangKB <gi...@git.apache.org>.
Github user vincentWangKB commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/27
@lizhanhui alog lib had been instead by boost::log, thanks your advisement
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq-externals issue #27: [ROCKETMQ-268]add rocketmq-cpp code
Posted by vongosling <gi...@git.apache.org>.
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/27
It is a good practice for apache way :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq-externals issue #27: [ROCKETMQ-268]add rocketmq-cpp code
Posted by lizhanhui <gi...@git.apache.org>.
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/27
@vesense Yes, we will do this before actually merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re:Re:[GitHub] incubator-rocketmq-externals issue #27: add
rocketmq-cpp code
Posted by 王启伟 <wa...@126.com>.
Hi All,
For build and install, cmake and Makefile are all supported on linux platform now. Thanks.
At 2017-08-14 20:47:31, "王启伟" <wa...@126.com> wrote:
Hi,
Very appreciated to receive your suggestion, I had fixed it by commit: a242505ae7e3ea0bcdc4ace3dcf53ccf331f89b7.
Thanks!
At 2017-08-13 17:22:59, "lizhanhui" <gi...@git.apache.org> wrote:
>Github user lizhanhui commented on the issue:
>
> https://github.com/apache/incubator-rocketmq-externals/pull/27
>
> Trying to create a CMakeLists.txt on top of this PR, but it looks there is something missing:
> ```cpp
> MetaqJson::Value json
> ```
> I grepped MetaqJson in the code, but no definition of this struct if found. Please double check the code is compilable.
>
>
>---
>If your project is set up for it, you can reply to this email and have your
>reply appear on GitHub as well. If your project does not have this feature
>enabled and wishes so, or if the feature is enabled but not working, please
>contact infrastructure at infrastructure@apache.org or file a JIRA ticket
>with INFRA.
>---
Re:[GitHub] incubator-rocketmq-externals issue #27: add
rocketmq-cpp code
Posted by 王启伟 <wa...@126.com>.
Hi,
Very appreciated to receive your suggestion, I had fixed it by commit: a242505ae7e3ea0bcdc4ace3dcf53ccf331f89b7.
Thanks!
At 2017-08-13 17:22:59, "lizhanhui" <gi...@git.apache.org> wrote:
>Github user lizhanhui commented on the issue:
>
> https://github.com/apache/incubator-rocketmq-externals/pull/27
>
> Trying to create a CMakeLists.txt on top of this PR, but it looks there is something missing:
> ```cpp
> MetaqJson::Value json
> ```
> I grepped MetaqJson in the code, but no definition of this struct if found. Please double check the code is compilable.
>
>
>---
>If your project is set up for it, you can reply to this email and have your
>reply appear on GitHub as well. If your project does not have this feature
>enabled and wishes so, or if the feature is enabled but not working, please
>contact infrastructure at infrastructure@apache.org or file a JIRA ticket
>with INFRA.
>---
[GitHub] incubator-rocketmq-externals issue #27: add rocketmq-cpp code
Posted by lizhanhui <gi...@git.apache.org>.
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/27
Trying to create a CMakeLists.txt on top of this PR, but it looks there is something missing:
```cpp
MetaqJson::Value json
```
I grepped MetaqJson in the code, but no definition of this struct if found. Please double check the code is compilable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq-externals issue #27: [ROCKETMQ-268]add rocketmq-cpp code
Posted by XadillaX <gi...@git.apache.org>.
Github user XadillaX commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/27
Consider removing boost? This dependency is too large for a SDK not a complete project.
---
[GitHub] incubator-rocketmq-externals issue #27: add rocketmq-cpp code
Posted by lizhanhui <gi...@git.apache.org>.
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/27
About the disruptor module in src/thread, copyright declarations of this module files are different. Is the source code copied from somewhere? If so, is its license compatible with Apache Software Foundation?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq-externals issue #27: add rocketmq-cpp code
Posted by lizhanhui <gi...@git.apache.org>.
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/27
As it's now part of the Apache RocketMQ project, IMO, rocketmq namespace should be used instead of metaq.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq-externals issue #27: [ROCKETMQ-268]add rocketmq-cpp code
Posted by lizhanhui <gi...@git.apache.org>.
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/27
@vincentWangKB Another issue with the code, currently all classes sit in the namespace of metaq, we should rename it to rocketmq.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq-externals issue #27: [ROCKETMQ-268]add rocketmq-cpp code
Posted by vesense <gi...@git.apache.org>.
Github user vesense commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/27
I suggest that we'd better squash the commits before merging a PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq-externals issue #27: [ROCKETMQ-268]add rocketmq-cpp code
Posted by lizhanhui <gi...@git.apache.org>.
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/27
Though there are still quite a few unused files, I am fine to merge this PR first and fix issues later on.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq-externals issue #27: [ROCKETMQ-268]add rocketmq-cpp code
Posted by vincentWangKB <gi...@git.apache.org>.
Github user vincentWangKB commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/27
close pull request, as rocketmq cpp code had been merged
---
[GitHub] incubator-rocketmq-externals issue #27: [ROCKETMQ-268]add rocketmq-cpp code
Posted by lizhanhui <gi...@git.apache.org>.
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/27
Yes, I see your update...Thanks for you contribution. CMake, IMO, is very good to have!
One more thing, I think we can assume dependent libraries are all installed in the standard default way, thus, we can use find_package features and developers do not have to modify CMake build file. If required libraries are missing, we just abort in the cmake phase.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq-externals issue #27: [ROCKETMQ-268]add rocketmq-cpp code
Posted by lizhanhui <gi...@git.apache.org>.
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/27
Maybe, we can merge it and create JIRA tickets to polish the code. Any idea?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq-externals issue #27: [ROCKETMQ-268]add rocketmq-cpp code
Posted by lizhanhui <gi...@git.apache.org>.
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/27
This Pull Request has been merged and it's safe to close this PR. @vincentWangKB
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq-externals issue #27: [ROCKETMQ-268]add rocketmq-cpp code
Posted by vincentWangKB <gi...@git.apache.org>.
Github user vincentWangKB commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/27
@lizhanhui namespace had been changed to rocketmq, thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq-externals issue #27: [ROCKETMQ-268]add rocketmq-cpp code
Posted by vincentWangKB <gi...@git.apache.org>.
Github user vincentWangKB commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/27
@lizhanhui all build issue had been fixed, please pull latest code, thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq-externals issue #27: [ROCKETMQ-268]add rocketmq-cpp code
Posted by lizhanhui <gi...@git.apache.org>.
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/27
@vincentWangKB Any progress? It's been a while since last update to this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq-externals issue #27: [ROCKETMQ-268]add rocketmq-cpp code
Posted by lizhanhui <gi...@git.apache.org>.
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/27
This patch looks good enough to be merged. Thanks @vincentWangKB
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re:[GitHub] incubator-rocketmq-externals issue #27: add
rocketmq-cpp code
Posted by 王启伟 <wa...@126.com>.
Hi,
Files in example are showing how rocketmq-cpp producer and consumer works, it is useful for new users, we keep it now better.
Thanks.
At 2017-08-13 17:47:46, "lizhanhui" <gi...@git.apache.org> wrote:
>Github user lizhanhui commented on the issue:
>
> https://github.com/apache/incubator-rocketmq-externals/pull/27
>
> Many useless files are included, for example in project folder. Can we remove them?
>
>
>---
>If your project is set up for it, you can reply to this email and have your
>reply appear on GitHub as well. If your project does not have this feature
>enabled and wishes so, or if the feature is enabled but not working, please
>contact infrastructure at infrastructure@apache.org or file a JIRA ticket
>with INFRA.
>---
[GitHub] incubator-rocketmq-externals issue #27: add rocketmq-cpp code
Posted by lizhanhui <gi...@git.apache.org>.
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/27
Many useless files are included, for example in project folder. Can we remove them?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---