[GitHub] [tinkerpop] spmallette commented on a change in pull request #1360: TINKERPOP-2445 Parallelize connection creation

[GitBox <gi...@apache.org>]

spmallette commented on a change in pull request #1360:
URL: https://github.com/apache/tinkerpop/pull/1360#discussion_r526069372



##########
File path: pom.xml
##########
@@ -721,6 +722,18 @@ limitations under the License.
                     </exclusion>
                 </exclusions>
             </dependency>
+            <dependency>

Review comment:
       I'm not sure what the implications are but i just checked to see if you could mock `final` classes with just mockito and came across this:
   
   https://www.baeldung.com/mockito-final
   
   any chance that will suffice rather than adding another testing dependency. definitely don't want to make things harder but every new bit of testing syntax seems to make it harder to get to junit5 without tons of adapters and shims (even powermock holds a `powermock-module-junit4`. Anyway, if it can't be done without the additional dependency or you see a bigger plan for testing with powermock in the future, then I suppose it's fine to keep it, otherwise my preference would be to try to do it with the test modules we already have.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org