[jira] [Commented] (HDFS-17020) RBF: mount table addAll should print failed records in std error

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-17020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17724742#comment-17724742 ] 

ASF GitHub Bot commented on HDFS-17020:
---------------------------------------

virajjasani commented on code in PR #5674:
URL: https://github.com/apache/hadoop/pull/5674#discussion_r1199906322


##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestRouterAdminCLI.java:
##########
@@ -1918,6 +1920,9 @@ public void testAddMultipleMountPointsFailure() throws Exception {
             "-faulttolerant"};
     // mount points were already added
     assertNotEquals(0, ToolRunner.run(admin, argv));
+
+    assertTrue("The error message should return failed entries",
+        err.toString().contains("Cannot add mount points: [0SLASH0testAddMultiMountPoints-01"));

Review Comment:
   Sounds good, that will be more readable to operators. Let me make this change.





> RBF: mount table addAll should print failed records in std error
> ----------------------------------------------------------------
>
>                 Key: HDFS-17020
>                 URL: https://issues.apache.org/jira/browse/HDFS-17020
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Viraj Jasani
>            Assignee: Viraj Jasani
>            Priority: Major
>
> Now that state store putAll supports returning failed records keys, addAll command for mount entries should also support printing failed records in the standard error.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org