You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Salikh Zakirov (JIRA)" <ji...@apache.org> on 2006/08/07 16:34:14 UTC
[jira] Created: (HARMONY-1083) [drlvm][build] Avoid touching
svn_version_tag.h if svn information is not available
[drlvm][build] Avoid touching svn_version_tag.h if svn information is not available
-----------------------------------------------------------------------------------
Key: HARMONY-1083
URL: http://issues.apache.org/jira/browse/HARMONY-1083
Project: Harmony
Issue Type: Improvement
Environment: Windows/ia32
Reporter: Salikh Zakirov
Attachments: 0001-Restricted-svn-revision-stamping-to-svn-workspaces.patch
I would like to suggest to make svn revision stamping optional.
In my use case, I do not have .svn directory in most of my
workspaces, because I use other version control system for managing
local patches, so 'java -version' says on my local builds
java version "1.5.0"
pre-alpha : not complete or compatible
svn = rsvn: '.' is not a working copy, (Aug 7 2006), Windows/ia32/msvc 1310, debug build
http://incubator.apache.org/harmony
and obviously is not helpful.
However, having version_svn_tag.h file modified after each
build is annoying -- it always shows up in diff, prevents me
from merging with latest revision from SVN etc.
The attached patch solves the problem.
It prevents the version_svn_tag.h from being overwritten if svn revision information
is not available.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-1083) [drlvm][build] Avoid touching
svn_version_tag.h if svn information is not available
Posted by "Salikh Zakirov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1083?page=all ]
Salikh Zakirov updated HARMONY-1083:
------------------------------------
Attachment: 0001-Restricted-svn-revision-stamping-to-svn-workspaces.patch
> [drlvm][build] Avoid touching svn_version_tag.h if svn information is not available
> -----------------------------------------------------------------------------------
>
> Key: HARMONY-1083
> URL: http://issues.apache.org/jira/browse/HARMONY-1083
> Project: Harmony
> Issue Type: Improvement
> Environment: Windows/ia32
> Reporter: Salikh Zakirov
> Attachments: 0001-Restricted-svn-revision-stamping-to-svn-workspaces.patch, 0001-Restricted-svn-revision-stamping-to-svn-workspaces.patch
>
>
> I would like to suggest to make svn revision stamping optional.
> In my use case, I do not have .svn directory in most of my
> workspaces, because I use other version control system for managing
> local patches, so 'java -version' says on my local builds
> java version "1.5.0"
> pre-alpha : not complete or compatible
> svn = rsvn: '.' is not a working copy, (Aug 7 2006), Windows/ia32/msvc 1310, debug build
> http://incubator.apache.org/harmony
> and obviously is not helpful.
> However, having version_svn_tag.h file modified after each
> build is annoying -- it always shows up in diff, prevents me
> from merging with latest revision from SVN etc.
> The attached patch solves the problem.
> It prevents the version_svn_tag.h from being overwritten if svn revision information
> is not available.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (HARMONY-1083) [drlvm][build] Avoid touching
svn_version_tag.h if svn information is not available
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1083?page=all ]
Mark Hindess closed HARMONY-1083.
---------------------------------
I'll assume that means it's okay. ;-)
> [drlvm][build] Avoid touching svn_version_tag.h if svn information is not available
> -----------------------------------------------------------------------------------
>
> Key: HARMONY-1083
> URL: http://issues.apache.org/jira/browse/HARMONY-1083
> Project: Harmony
> Issue Type: Improvement
> Environment: Windows/ia32
> Reporter: Salikh Zakirov
> Assigned To: Mark Hindess
> Attachments: 0001-Restricted-svn-revision-stamping-to-svn-workspaces.patch, 0001-Restricted-svn-revision-stamping-to-svn-workspaces.patch, 0001-Restricted-svn-revision-stamping-to-svn-workspaces.patch
>
>
> I would like to suggest to make svn revision stamping optional.
> In my use case, I do not have .svn directory in most of my
> workspaces, because I use other version control system for managing
> local patches, so 'java -version' says on my local builds
> java version "1.5.0"
> pre-alpha : not complete or compatible
> svn = rsvn: '.' is not a working copy, (Aug 7 2006), Windows/ia32/msvc 1310, debug build
> http://incubator.apache.org/harmony
> and obviously is not helpful.
> However, having version_svn_tag.h file modified after each
> build is annoying -- it always shows up in diff, prevents me
> from merging with latest revision from SVN etc.
> The attached patch solves the problem.
> It prevents the version_svn_tag.h from being overwritten if svn revision information
> is not available.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-1083) [drlvm][build] Avoid touching
svn_version_tag.h if svn information is not available
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1083?page=all ]
Mark Hindess reassigned HARMONY-1083:
-------------------------------------
Assignee: Mark Hindess
> [drlvm][build] Avoid touching svn_version_tag.h if svn information is not available
> -----------------------------------------------------------------------------------
>
> Key: HARMONY-1083
> URL: http://issues.apache.org/jira/browse/HARMONY-1083
> Project: Harmony
> Issue Type: Improvement
> Environment: Windows/ia32
> Reporter: Salikh Zakirov
> Assigned To: Mark Hindess
> Attachments: 0001-Restricted-svn-revision-stamping-to-svn-workspaces.patch, 0001-Restricted-svn-revision-stamping-to-svn-workspaces.patch, 0001-Restricted-svn-revision-stamping-to-svn-workspaces.patch
>
>
> I would like to suggest to make svn revision stamping optional.
> In my use case, I do not have .svn directory in most of my
> workspaces, because I use other version control system for managing
> local patches, so 'java -version' says on my local builds
> java version "1.5.0"
> pre-alpha : not complete or compatible
> svn = rsvn: '.' is not a working copy, (Aug 7 2006), Windows/ia32/msvc 1310, debug build
> http://incubator.apache.org/harmony
> and obviously is not helpful.
> However, having version_svn_tag.h file modified after each
> build is annoying -- it always shows up in diff, prevents me
> from merging with latest revision from SVN etc.
> The attached patch solves the problem.
> It prevents the version_svn_tag.h from being overwritten if svn revision information
> is not available.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (HARMONY-1083) [drlvm][build] Avoid touching
svn_version_tag.h if svn information is not available
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1083?page=all ]
Mark Hindess resolved HARMONY-1083.
-----------------------------------
Resolution: Fixed
Thanks Salikh. I've applied your patch in r462856. Please confirm that this has been applied as expected.
> [drlvm][build] Avoid touching svn_version_tag.h if svn information is not available
> -----------------------------------------------------------------------------------
>
> Key: HARMONY-1083
> URL: http://issues.apache.org/jira/browse/HARMONY-1083
> Project: Harmony
> Issue Type: Improvement
> Environment: Windows/ia32
> Reporter: Salikh Zakirov
> Assigned To: Mark Hindess
> Attachments: 0001-Restricted-svn-revision-stamping-to-svn-workspaces.patch, 0001-Restricted-svn-revision-stamping-to-svn-workspaces.patch, 0001-Restricted-svn-revision-stamping-to-svn-workspaces.patch
>
>
> I would like to suggest to make svn revision stamping optional.
> In my use case, I do not have .svn directory in most of my
> workspaces, because I use other version control system for managing
> local patches, so 'java -version' says on my local builds
> java version "1.5.0"
> pre-alpha : not complete or compatible
> svn = rsvn: '.' is not a working copy, (Aug 7 2006), Windows/ia32/msvc 1310, debug build
> http://incubator.apache.org/harmony
> and obviously is not helpful.
> However, having version_svn_tag.h file modified after each
> build is annoying -- it always shows up in diff, prevents me
> from merging with latest revision from SVN etc.
> The attached patch solves the problem.
> It prevents the version_svn_tag.h from being overwritten if svn revision information
> is not available.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1083) [drlvm][build] Avoid touching
svn_version_tag.h if svn information is not available
Posted by "Salikh Zakirov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1083?page=comments#action_12441519 ]
Salikh Zakirov commented on HARMONY-1083:
-----------------------------------------
Thanks a lot, Mark!
> [drlvm][build] Avoid touching svn_version_tag.h if svn information is not available
> -----------------------------------------------------------------------------------
>
> Key: HARMONY-1083
> URL: http://issues.apache.org/jira/browse/HARMONY-1083
> Project: Harmony
> Issue Type: Improvement
> Environment: Windows/ia32
> Reporter: Salikh Zakirov
> Assigned To: Mark Hindess
> Attachments: 0001-Restricted-svn-revision-stamping-to-svn-workspaces.patch, 0001-Restricted-svn-revision-stamping-to-svn-workspaces.patch, 0001-Restricted-svn-revision-stamping-to-svn-workspaces.patch
>
>
> I would like to suggest to make svn revision stamping optional.
> In my use case, I do not have .svn directory in most of my
> workspaces, because I use other version control system for managing
> local patches, so 'java -version' says on my local builds
> java version "1.5.0"
> pre-alpha : not complete or compatible
> svn = rsvn: '.' is not a working copy, (Aug 7 2006), Windows/ia32/msvc 1310, debug build
> http://incubator.apache.org/harmony
> and obviously is not helpful.
> However, having version_svn_tag.h file modified after each
> build is annoying -- it always shows up in diff, prevents me
> from merging with latest revision from SVN etc.
> The attached patch solves the problem.
> It prevents the version_svn_tag.h from being overwritten if svn revision information
> is not available.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1083) [drlvm][build] Avoid touching
svn_version_tag.h if svn information is not available
Posted by "Salikh Zakirov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1083?page=comments#action_12429916 ]
Salikh Zakirov commented on HARMONY-1083:
-----------------------------------------
I do grant ASF license to use attachment 0001-....patch.
> [drlvm][build] Avoid touching svn_version_tag.h if svn information is not available
> -----------------------------------------------------------------------------------
>
> Key: HARMONY-1083
> URL: http://issues.apache.org/jira/browse/HARMONY-1083
> Project: Harmony
> Issue Type: Improvement
> Environment: Windows/ia32
> Reporter: Salikh Zakirov
> Attachments: 0001-Restricted-svn-revision-stamping-to-svn-workspaces.patch
>
>
> I would like to suggest to make svn revision stamping optional.
> In my use case, I do not have .svn directory in most of my
> workspaces, because I use other version control system for managing
> local patches, so 'java -version' says on my local builds
> java version "1.5.0"
> pre-alpha : not complete or compatible
> svn = rsvn: '.' is not a working copy, (Aug 7 2006), Windows/ia32/msvc 1310, debug build
> http://incubator.apache.org/harmony
> and obviously is not helpful.
> However, having version_svn_tag.h file modified after each
> build is annoying -- it always shows up in diff, prevents me
> from merging with latest revision from SVN etc.
> The attached patch solves the problem.
> It prevents the version_svn_tag.h from being overwritten if svn revision information
> is not available.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-1083) [drlvm][build] Avoid touching
svn_version_tag.h if svn information is not available
Posted by "Salikh Zakirov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1083?page=all ]
Salikh Zakirov updated HARMONY-1083:
------------------------------------
Attachment: 0001-Restricted-svn-revision-stamping-to-svn-workspaces.patch
Updated patch to best practices from classlib's workspace
> [drlvm][build] Avoid touching svn_version_tag.h if svn information is not available
> -----------------------------------------------------------------------------------
>
> Key: HARMONY-1083
> URL: http://issues.apache.org/jira/browse/HARMONY-1083
> Project: Harmony
> Issue Type: Improvement
> Environment: Windows/ia32
> Reporter: Salikh Zakirov
> Attachments: 0001-Restricted-svn-revision-stamping-to-svn-workspaces.patch, 0001-Restricted-svn-revision-stamping-to-svn-workspaces.patch, 0001-Restricted-svn-revision-stamping-to-svn-workspaces.patch
>
>
> I would like to suggest to make svn revision stamping optional.
> In my use case, I do not have .svn directory in most of my
> workspaces, because I use other version control system for managing
> local patches, so 'java -version' says on my local builds
> java version "1.5.0"
> pre-alpha : not complete or compatible
> svn = rsvn: '.' is not a working copy, (Aug 7 2006), Windows/ia32/msvc 1310, debug build
> http://incubator.apache.org/harmony
> and obviously is not helpful.
> However, having version_svn_tag.h file modified after each
> build is annoying -- it always shows up in diff, prevents me
> from merging with latest revision from SVN etc.
> The attached patch solves the problem.
> It prevents the version_svn_tag.h from being overwritten if svn revision information
> is not available.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira