You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/08/04 17:16:41 UTC

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a diff in pull request #1382: MINIFICPP-1899 - Fix local Docker build failure

adam-markovics commented on code in PR #1382:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1382#discussion_r938058318


##########
libminifi/src/utils/BackTrace.cpp:
##########
@@ -117,6 +117,8 @@ void pull_trace(uint8_t frames_to_skip /* = 1 */) {
 
     TraceResolver::getResolver().addTraceLine(file_name, symbol_name.c_str(), symbol_offset);
   }
+#else
+  (void)(frames_to_skip);

Review Comment:
   I agree. Because indentation cannot be used to mark nested `#ifdef`s I added some more comments to help a bit.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org