Re: [PR] Fix disk weight ensemble infinite loop bug [bookkeeper]

["hangc0276 (via GitHub)" <gi...@apache.org>]

hangc0276 commented on code in PR #4324:
URL: https://github.com/apache/bookkeeper/pull/4324#discussion_r1590014563


##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RackawareEnsemblePlacementPolicyImpl.java:
##########
@@ -792,9 +792,6 @@ protected List<BookieNode> selectRandomInternal(List<BookieNode> bookiesToSelect
 
             Map<BookieNode, WeightedObject> rackMap = new HashMap<BookieNode, WeightedObject>();
             for (BookieNode n : bookiesToSelectFrom) {
-                if (excludeBookies.contains(n)) {
-                    continue;
-                }

Review Comment:
   The current change won't change behaviors and can resolve this bug most simply.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org