[GitHub] [incubator-hudi] bvaradar commented on issue #915: [HUDI-268] Shade and relocate Avro dependency in hadoop-mr-bundle

[GitBox <gi...@apache.org>]

bvaradar commented on issue #915: [HUDI-268] Shade and relocate Avro dependency in hadoop-mr-bundle
URL: https://github.com/apache/incubator-hudi/pull/915#issuecomment-534322614
 
 
   @umehrot2  Shading Avro will cause some Realtime Table use-cases to break. This was one of the reasons why we ended up not using this approach. 
   
   Hudi allows for pluggable record payload implementations. HoodieRecordPayload (a public facing interface) exposes Avro GenericRecord types as part of its interface. 
   
   We have some deployments where custom implementations of this interface (which resides in different jar) is used to perform on-the-fly merges for Realtime Table reading.  If we make shading avro as mandatory for hoodie-hadoop-mr-table, then these plugins also needs to shade avro in the same way. 
   
   I think keeping the bundling optional (default = not bundle) would be better.  
   
   @vinothchandar : Assuming this is a one-off case, If it makes things easier for everyone, would it make sense to publish a new jar type (hudi-hadoop-mr-bundle-with-avro-shaded) along with hudi-hadoop-mr-bundle ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services