[GitHub] [incubator-hop] nadment edited a comment on pull request #1028: Hop-3221 Deprecated code cleanup

[GitBox <gi...@apache.org>]

nadment edited a comment on pull request #1028:
URL: https://github.com/apache/incubator-hop/pull/1028#issuecomment-908656854


   The changes will be very important!
    
     1) How to name the text field with the reference of the database uses: connection or databaseName?
   
     2) I am having difficulty with some functions of ITransformMeta which doesn't  have a metadataProvider like: 
              public DatabaseMeta [] getUsedDatabaseConnections ()
   
     3) The MetaSelectionLine widget should first be adapted to give it a name rather than a metadata
   
   -- addConnectionLine (Composite parent, Control previous, DatabaseMeta selected, ModifyListener lsMod) {
   -- wConnection.addToConnectionLine (parent, previous, selected, lsMod);
   
   ++ addConnectionLine (Composite parent, Control previous, String connection, ModifyListener lsMod) {
   ++ wConnection.addToConnectionLine (parent, previous, connection, lsMod); 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org