You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/07/12 20:00:02 UTC

[GitHub] [skywalking-python] potiuk commented on pull request #128: removed requests as required dependency

potiuk commented on pull request #128:
URL: https://github.com/apache/skywalking-python/pull/128#issuecomment-878466814


   Correct. I mentioned that in my report. So this is right, it's not *necesssary* according to the ASF Policy (similarly in Airflow we have a lot of extras with `requests`) - the "optional" LGPL dependency is acceptable. But once the new version is out, I think it would be great to make it "minimal" version of requests - this way the LGPL dependency becomes optional even for optional dependencies ;)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org