You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by snuyanzin <gi...@git.apache.org> on 2018/06/28 17:35:22 UTC
[GitHub] flink pull request #6226: [FLINK-8650] Tests for WINDOW clause and documenta...
GitHub user snuyanzin opened a pull request:
https://github.com/apache/flink/pull/6226
[FLINK-8650] Tests for WINDOW clause and documentation update
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Travis CI to do that following [this guide](http://flink.apache.org/contribute-code.html#best-practices).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
## What is the purpose of the change
test and documentation coverage of WINDOW clause
## Brief change log
- *Test that the same queries but with different specification of windows have the same plan*
- *Mentioning in doc WINDOW syntax*
## Verifying this change
This change added tests and can be verified as follows:
via running of org.apache.flink.table.api.stream.sql.OverWindowTest
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/snuyanzin/flink FLINK_8560
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/6226.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6226
----
commit 85451a2f9e6d1cd5d8b98fa2bba5c92326e817ce
Author: snuyanzin <sn...@...>
Date: 2018-06-28T16:19:25Z
[FLINK-8650] Tests for WINDOW clause and documentation update
----
---
[GitHub] flink pull request #6226: [FLINK-8650] Tests for WINDOW clause and documenta...
Posted by snuyanzin <gi...@git.apache.org>.
Github user snuyanzin commented on a diff in the pull request:
https://github.com/apache/flink/pull/6226#discussion_r198928207
--- Diff: docs/dev/table/sql.md ---
@@ -115,6 +115,10 @@ The following BNF-grammar describes the superset of supported SQL features in ba
{% highlight sql %}
+insert:
+ INSERT INTO tableReference
--- End diff --
Move up to be sync with the similar Calcite's doc
---
[GitHub] flink pull request #6226: [FLINK-8650] Tests for WINDOW clause and documenta...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/6226
---
[GitHub] flink pull request #6226: [FLINK-8650] Tests for WINDOW clause and documenta...
Posted by snuyanzin <gi...@git.apache.org>.
Github user snuyanzin commented on a diff in the pull request:
https://github.com/apache/flink/pull/6226#discussion_r198928117
--- Diff: docs/dev/table/sql.md ---
@@ -139,7 +143,8 @@ select:
[ WHERE booleanExpression ]
[ GROUP BY { groupItem [, groupItem ]* } ]
[ HAVING booleanExpression ]
-
+ [ WINDOW windowName AS windowSpec [, windowName AS windowSpec ]* ]
--- End diff --
Done in a way Calcite does it
---
[GitHub] flink pull request #6226: [FLINK-8650] Tests for WINDOW clause and documenta...
Posted by snuyanzin <gi...@git.apache.org>.
Github user snuyanzin commented on a diff in the pull request:
https://github.com/apache/flink/pull/6226#discussion_r199222853
--- Diff: docs/dev/table/sql.md ---
@@ -176,9 +181,20 @@ groupItem:
| ROLLUP '(' expression [, expression ]* ')'
| GROUPING SETS '(' groupItem [, groupItem ]* ')'
-insert:
- INSERT INTO tableReference
- query
+windowRef:
+ windowName
+ | windowSpec
+
+windowSpec:
--- End diff --
yes sure, done
---
[GitHub] flink pull request #6226: [FLINK-8650] Tests for WINDOW clause and documenta...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/6226#discussion_r199204037
--- Diff: docs/dev/table/sql.md ---
@@ -176,9 +181,20 @@ groupItem:
| ROLLUP '(' expression [, expression ]* ')'
| GROUPING SETS '(' groupItem [, groupItem ]* ')'
-insert:
- INSERT INTO tableReference
- query
+windowRef:
+ windowName
+ | windowSpec
+
+windowSpec:
+ [ windowName ]
+ '('
+ [ ORDER BY orderItem [, orderItem ]* ]
+ [ PARTITION BY expression [, expression ]* ]
+ [
+ RANGE numericOrIntervalExpression { PRECEDING | FOLLOWING }
--- End diff --
Flink does not support `FOLLOWING` yet
---
[GitHub] flink pull request #6226: [FLINK-8650] Tests for WINDOW clause and documenta...
Posted by snuyanzin <gi...@git.apache.org>.
Github user snuyanzin commented on a diff in the pull request:
https://github.com/apache/flink/pull/6226#discussion_r199223349
--- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/stream/sql/OverWindowTest.scala ---
@@ -44,7 +44,26 @@ class OverWindowTest extends TableTestBase {
"sum(DISTINCT c) OVER (PARTITION BY b ORDER BY proctime ROWS BETWEEN 2 preceding AND " +
"CURRENT ROW) as sum2 " +
"from MyTable"
-
+ val sql2 = "SELECT " +
--- End diff --
Agree. I've reduced number of queries per test case (one without `WINDOW ` and one with). Please let me know if it looks good or not
---
[GitHub] flink pull request #6226: [FLINK-8650] Tests for WINDOW clause and documenta...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/6226#discussion_r199209179
--- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/stream/sql/OverWindowTest.scala ---
@@ -44,7 +44,26 @@ class OverWindowTest extends TableTestBase {
"sum(DISTINCT c) OVER (PARTITION BY b ORDER BY proctime ROWS BETWEEN 2 preceding AND " +
"CURRENT ROW) as sum2 " +
"from MyTable"
-
+ val sql2 = "SELECT " +
--- End diff --
I think we can reduce the number of tests is a bit.
We are basically testing Calcite's parser / validator multiple times with very similar queries. For example, Calcite does not distinguish between proctime and rowtime. One query with a `WINDOW` clause per test case should be sufficient.
---
[GitHub] flink pull request #6226: [FLINK-8650] Tests for WINDOW clause and documenta...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/6226#discussion_r199205419
--- Diff: docs/dev/table/sql.md ---
@@ -176,9 +181,20 @@ groupItem:
| ROLLUP '(' expression [, expression ]* ')'
| GROUPING SETS '(' groupItem [, groupItem ]* ')'
-insert:
- INSERT INTO tableReference
- query
+windowRef:
+ windowName
+ | windowSpec
+
+windowSpec:
--- End diff --
Can you also add a `WINDOW` example to the **Over Window aggregation** section in https://ci.apache.org/projects/flink/flink-docs-release-1.5/dev/table/sql.html#aggregations ?
---
[GitHub] flink pull request #6226: [FLINK-8650] Tests for WINDOW clause and documenta...
Posted by snuyanzin <gi...@git.apache.org>.
Github user snuyanzin commented on a diff in the pull request:
https://github.com/apache/flink/pull/6226#discussion_r199223615
--- Diff: docs/dev/table/sql.md ---
@@ -176,9 +181,20 @@ groupItem:
| ROLLUP '(' expression [, expression ]* ')'
| GROUPING SETS '(' groupItem [, groupItem ]* ')'
-insert:
- INSERT INTO tableReference
- query
+windowRef:
+ windowName
+ | windowSpec
+
+windowSpec:
+ [ windowName ]
+ '('
+ [ ORDER BY orderItem [, orderItem ]* ]
+ [ PARTITION BY expression [, expression ]* ]
+ [
+ RANGE numericOrIntervalExpression { PRECEDING | FOLLOWING }
--- End diff --
Yes agree I've removed it
---
[GitHub] flink issue #6226: [FLINK-8650] Tests for WINDOW clause and documentation up...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/6226
Thanks for the update @snuyanzin.
Looks good. Will merge it.
---
[GitHub] flink pull request #6226: [FLINK-8650] Tests for WINDOW clause and documenta...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/6226#discussion_r199204120
--- Diff: docs/dev/table/sql.md ---
@@ -176,9 +181,20 @@ groupItem:
| ROLLUP '(' expression [, expression ]* ')'
| GROUPING SETS '(' groupItem [, groupItem ]* ')'
-insert:
- INSERT INTO tableReference
- query
+windowRef:
+ windowName
+ | windowSpec
+
+windowSpec:
+ [ windowName ]
+ '('
+ [ ORDER BY orderItem [, orderItem ]* ]
+ [ PARTITION BY expression [, expression ]* ]
+ [
+ RANGE numericOrIntervalExpression { PRECEDING | FOLLOWING }
+ | ROWS numericExpression { PRECEDING | FOLLOWING }
--- End diff --
Flink does not support `FOLLOWING` yet
---
[GitHub] flink issue #6226: [FLINK-8650] Tests for WINDOW clause and documentation up...
Posted by snuyanzin <gi...@git.apache.org>.
Github user snuyanzin commented on the issue:
https://github.com/apache/flink/pull/6226
@fhueske thank you for your review
I have left comments and done changes. Please let me know if it is required some more efforts
---