You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/11 01:52:27 UTC
[GitHub] [airflow] cris-b opened a new issue #13003: KubernetesExecutor - image from executor_config is ignored
cris-b opened a new issue #13003:
URL: https://github.com/apache/airflow/issues/13003
In 1.10.11+ the image used in executor_config is ignored.
in PodGenerator.construct_pod the kube_image is used as the image when constructing the dynamic_pod. Then because dynamic pod takes precedence here:
pod_list = [base_worker_pod, pod_override_object, dynamic_pod]
I cant see how the image could ever be anything but the default worker image.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on issue #13003: KubernetesExecutor - image from executor_config is ignored
Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #13003:
URL: https://github.com/apache/airflow/issues/13003#issuecomment-764695294
Fixed by https://github.com/apache/airflow/pull/13074
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil edited a comment on issue #13003: KubernetesExecutor - image from executor_config is ignored
Posted by GitBox <gi...@apache.org>.
kaxil edited a comment on issue #13003:
URL: https://github.com/apache/airflow/issues/13003#issuecomment-780195540
> hey @kaxil just wondering if there is already a tentative release date for 1.10.15?
Planning last week of Feb or Early March
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] marcusianlevine commented on issue #13003: KubernetesExecutor - image from executor_config is ignored
Posted by GitBox <gi...@apache.org>.
marcusianlevine commented on issue #13003:
URL: https://github.com/apache/airflow/issues/13003#issuecomment-744724098
Thanks for reporting this Cris, I'm seeing the same issue
AFAIK this only affects 1.10.13+
I'm currently running Airflow 1.10.12 and the `executor_config` image override works, but when I try to upgrade to 1.10.14 it always uses the image specified in the base config
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on issue #13003: KubernetesExecutor - image from executor_config is ignored
Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #13003:
URL: https://github.com/apache/airflow/issues/13003#issuecomment-764695294
Fixed by https://github.com/apache/airflow/pull/13074
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] CatarinaSilva commented on issue #13003: KubernetesExecutor - image from executor_config is ignored
Posted by GitBox <gi...@apache.org>.
CatarinaSilva commented on issue #13003:
URL: https://github.com/apache/airflow/issues/13003#issuecomment-782881052
> Planning last week of Feb or Early March
Thanks for the info 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on issue #13003: KubernetesExecutor - image from executor_config is ignored
Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #13003:
URL: https://github.com/apache/airflow/issues/13003#issuecomment-780195540
> hey @kaxil just wondering if there is already a tentative release date for 1.10.15?
Planning Early March
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on issue #13003: KubernetesExecutor - image from executor_config is ignored
Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #13003:
URL: https://github.com/apache/airflow/issues/13003#issuecomment-758769643
> Hi, also suffering from this when trying to migrate from 1.10.12 to 1.10.14, I see the PR is already done, is there any idea when it's going to be released? @dimberman
Most-likely in a month (or sooner)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] CatarinaSilva commented on issue #13003: KubernetesExecutor - image from executor_config is ignored
Posted by GitBox <gi...@apache.org>.
CatarinaSilva commented on issue #13003:
URL: https://github.com/apache/airflow/issues/13003#issuecomment-754489721
Hi, also suffering from this when trying to migrate from 1.10.12 to 1.10.14, I see the PR is already done, is there any idea when it's going to be released? @dimberman
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil closed issue #13003: KubernetesExecutor - image from executor_config is ignored
Posted by GitBox <gi...@apache.org>.
kaxil closed issue #13003:
URL: https://github.com/apache/airflow/issues/13003
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] cris-b commented on issue #13003: KubernetesExecutor - image from executor_config is ignored
Posted by GitBox <gi...@apache.org>.
cris-b commented on issue #13003:
URL: https://github.com/apache/airflow/issues/13003#issuecomment-743733799
this is only relevant to 1.10.x, in 2.0 there is this code in construct_pod which stops the problem:
try:
image = pod_override_object.spec.containers[0].image # type: ignore
if not image:
image = kube_image
except Exception: # pylint: disable=W0703
image = kube_image
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] CatarinaSilva commented on issue #13003: KubernetesExecutor - image from executor_config is ignored
Posted by GitBox <gi...@apache.org>.
CatarinaSilva commented on issue #13003:
URL: https://github.com/apache/airflow/issues/13003#issuecomment-779281746
hey @kaxil just wondering if there is already a tentative release date for 1.10.15?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on issue #13003: KubernetesExecutor - image from executor_config is ignored
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #13003:
URL: https://github.com/apache/airflow/issues/13003#issuecomment-742912743
Thanks for opening your first issue here! Be sure to follow the issue template!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil closed issue #13003: KubernetesExecutor - image from executor_config is ignored
Posted by GitBox <gi...@apache.org>.
kaxil closed issue #13003:
URL: https://github.com/apache/airflow/issues/13003
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org