You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2020/09/04 12:09:22 UTC
[GitHub] [couchdb] bessbd opened a new pull request #3128: Make COPY doc return only one "ok"
bessbd opened a new pull request #3128:
URL: https://github.com/apache/couchdb/pull/3128
## Overview
When copying a doc, the returned JSON contains two `"ok"` fields:
`curl -H'Destination: copied5' --request COPY http://adm:pass@127.0.0.1:15984/foo/5cdc97838a8c748f7352d488ab0004c6`
```JSON
{"ok":true,"ok":true,"id":"foo/copied","rev":"1-967a00dff5e02add41819138abb3284d"}
```
## Testing recommendations
`make eunit apps=chttpd suites=chttpd_db_test`
## Related Issues or Pull Requests
<!-- If your changes affects multiple components in different
repositories please put links to those issues or pull requests here. -->
## Checklist
- [x] Code is written and works correctly
- [x] Changes are covered by tests
- [x] Any new configurable parameters are documented in `rel/overlay/etc/default.ini`
- [ ] A PR for documentation changes has been made in https://github.com/apache/couchdb-documentation - N/A, the docs are correct: https://docs.couchdb.org/en/latest/api/document/common.html#copy--db-docid
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] bessbd commented on pull request #3128: Make COPY doc return only one "ok"
Posted by GitBox <gi...@apache.org>.
bessbd commented on pull request #3128:
URL: https://github.com/apache/couchdb/pull/3128#issuecomment-687136271
Thank you for the review, @rnewson ! Can you please merge this PR for me?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] bessbd commented on pull request #3128: Make COPY doc return only one "ok"
Posted by GitBox <gi...@apache.org>.
bessbd commented on pull request #3128:
URL: https://github.com/apache/couchdb/pull/3128#issuecomment-687247839
Thank you for the merge, @janl !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] janl merged pull request #3128: Make COPY doc return only one "ok"
Posted by GitBox <gi...@apache.org>.
janl merged pull request #3128:
URL: https://github.com/apache/couchdb/pull/3128
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] bessbd commented on pull request #3128: Make COPY doc return only one "ok"
Posted by GitBox <gi...@apache.org>.
bessbd commented on pull request #3128:
URL: https://github.com/apache/couchdb/pull/3128#issuecomment-687254169
I've opened a PR to backport this to 3.x: https://github.com/apache/couchdb/pull/3130
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org