[GitHub] [incubator-doris] morningman commented on a change in pull request #7454: memory usage optimization for load job

[GitBox <gi...@apache.org>]

morningman commented on a change in pull request #7454:
URL: https://github.com/apache/incubator-doris/pull/7454#discussion_r773978100



##########
File path: be/src/exec/broker_scan_node.cpp
##########
@@ -284,11 +284,19 @@ Status BrokerScanNode::scanner_scan(const TBrokerScanRange& scan_range,
             memset(tuple, 0, _tuple_desc->num_null_bytes());
 
             // Get from scanner
-            RETURN_IF_ERROR(scanner->get_next(tuple, tuple_pool, &scanner_eof));
+            bool tuple_fill = false;
+            RETURN_IF_ERROR(scanner->get_next(tuple, tuple_pool, &scanner_eof, &tuple_fill));
             if (scanner_eof) {
                 continue;
             }
 
+            // if read row succed, but fill dest tuple fail, we need to increase # of uncommitted rows, 

Review comment:
       ```suggestion
               // if read row succeed, but fill dest tuple fail, we need to increase # of uncommitted rows, 
   ```

##########
File path: be/src/exec/broker_scanner.cpp
##########
@@ -116,8 +116,11 @@ Status BrokerScanner::get_next(Tuple* tuple, MemPool* tuple_pool, bool* eof) {
             SCOPED_TIMER(_materialize_timer);
             if (convert_one_row(Slice(ptr, size), tuple, tuple_pool)) {
                 free_expr_local_allocations();
-                break;
+                *fill_tuple = true;
+            } else {
+                *fill_tuple = false;
             }
+            break; //break always

Review comment:
       ```suggestion
               break; // break always
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org