You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by mo...@apache.org on 2023/04/20 14:53:11 UTC
[doris] branch branch-2.0-alpha updated: [branch-2.0-alpha] fix mtmv thread interruption issue
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch branch-2.0-alpha
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-2.0-alpha by this push:
new 19870d99cd [branch-2.0-alpha] fix mtmv thread interruption issue
19870d99cd is described below
commit 19870d99cdf382cd22212e292b31217c2b191ce8
Author: morningman <mo...@163.com>
AuthorDate: Thu Apr 20 22:52:24 2023 +0800
[branch-2.0-alpha] fix mtmv thread interruption issue
A temp fix only for branch-2.0-alpha, master branch will be fixed later after this patch works
---
fe/fe-core/src/main/java/org/apache/doris/mtmv/MTMVJobManager.java | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/fe/fe-core/src/main/java/org/apache/doris/mtmv/MTMVJobManager.java b/fe/fe-core/src/main/java/org/apache/doris/mtmv/MTMVJobManager.java
index 0e27a4616f..44df43a8e3 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/mtmv/MTMVJobManager.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/mtmv/MTMVJobManager.java
@@ -306,7 +306,10 @@ public class MTMVJobManager {
LOG.warn("fail to obtain scheduled info for job [{}]", job.getName());
return true;
}
- boolean isCancel = future.cancel(true);
+ // MUST not set true for "mayInterruptIfRunning".
+ // Because this thread may doing bdbje write operation, it is interrupted,
+ // FE may exit due to bdbje write failure.
+ boolean isCancel = future.cancel(false);
if (!isCancel) {
LOG.warn("fail to cancel scheduler for job [{}]", job.getName());
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org