[GitHub] [sling-org-apache-sling-distribution-journal-messages] joerghoh commented on a change in pull request #8: SLING-11028 - Allow to assign to relative offsets

[GitBox <gi...@apache.org>]

joerghoh commented on a change in pull request #8:
URL: https://github.com/apache/sling-org-apache-sling-distribution-journal-messages/pull/8#discussion_r772453949



##########
File path: src/main/java/org/apache/sling/distribution/journal/MessagingProvider.java
##########
@@ -40,6 +40,8 @@ default Closeable createPoller(
 
     String assignTo(long offset);
     
+    String assignTo(Reset reset, long relativeOffset);

Review comment:
       please add Javadoc

##########
File path: src/main/java/org/apache/sling/distribution/journal/Reset.java
##########
@@ -18,4 +18,5 @@
  */
 package org.apache.sling.distribution.journal;
 
+// Do not change the enum names. Implementation depends on the exact names.

Review comment:
       Some more javadoc would be appropriate here as well.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org