You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "boneanxs (via GitHub)" <gi...@apache.org> on 2023/03/09 03:30:43 UTC

[GitHub] [hudi] boneanxs opened a new pull request, #8139: [HUDI-5909] Reuse hive client if possible

boneanxs opened a new pull request, #8139:
URL: https://github.com/apache/hudi/pull/8139

   ### Change Logs
   For query like
   ```
   create table hudi_test()...;
   insert into hudi_test()...;
   ```
   it will create 3 hive clients(spark's hiveClient, hudi's hiveClient to create a new hudi table, SyncTool to sync meta after the insert operation)
   
   We can actually reuse the spark's hiveClient when creating a new hudi table.
   
   ### Impact
   
   none
   
   ### Risk level (write none, low medium or high below)
   none
   
   ### Documentation Update
   
   _Describe any necessary documentation update if there is any new feature, config, or user-facing change_
   
   - _The config description must be updated if new configs are added or the default value of the configs are changed_
   - _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
     ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
     changes to the website._
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Change Logs and Impact were stated clearly
   - [ ] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #8139: [HUDI-5909] Reuse hive client if possible

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8139:
URL: https://github.com/apache/hudi/pull/8139#issuecomment-1461241184

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0bcd6490f856475266dfff3882728aa1392727f1",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0bcd6490f856475266dfff3882728aa1392727f1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0bcd6490f856475266dfff3882728aa1392727f1 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] danny0405 merged pull request #8139: [HUDI-5909] Reuse hive client if possible

Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 merged PR #8139:
URL: https://github.com/apache/hudi/pull/8139


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #8139: [HUDI-5909] Reuse hive client if possible

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8139:
URL: https://github.com/apache/hudi/pull/8139#issuecomment-1461252718

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0bcd6490f856475266dfff3882728aa1392727f1",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15628",
       "triggerID" : "0bcd6490f856475266dfff3882728aa1392727f1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0bcd6490f856475266dfff3882728aa1392727f1 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15628) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] danny0405 commented on pull request #8139: [HUDI-5909] Reuse hive client if possible

Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on PR #8139:
URL: https://github.com/apache/hudi/pull/8139#issuecomment-1461676523

   > > We try to close the hive meta sync connection after each meta sync, does that logic still work after your change?
   > 
   > We don't close `HiveClient`(it lives with the lifetime of the job), we will close SyncTool's metaClient(syncing the metadata after writing operation).
   > 
   > So this pr tries to reuse `HiveClient` which Spark created before when creating table(I notice that drop table already reuse spark's). It won't change the behavior for the insert operation.
   
   Got it, is it possible we can write some tests here?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #8139: [HUDI-5909] Reuse hive client if possible

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8139:
URL: https://github.com/apache/hudi/pull/8139#issuecomment-1463506676

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0bcd6490f856475266dfff3882728aa1392727f1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15628",
       "triggerID" : "0bcd6490f856475266dfff3882728aa1392727f1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "075563866d156e36afe34780d5fb132d6da57251",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15649",
       "triggerID" : "075563866d156e36afe34780d5fb132d6da57251",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 075563866d156e36afe34780d5fb132d6da57251 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15649) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #8139: [HUDI-5909] Reuse hive client if possible

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8139:
URL: https://github.com/apache/hudi/pull/8139#issuecomment-1461440846

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0bcd6490f856475266dfff3882728aa1392727f1",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15628",
       "triggerID" : "0bcd6490f856475266dfff3882728aa1392727f1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0bcd6490f856475266dfff3882728aa1392727f1 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15628) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] danny0405 commented on pull request #8139: [HUDI-5909] Reuse hive client if possible

Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on PR #8139:
URL: https://github.com/apache/hudi/pull/8139#issuecomment-1461358327

   We try to close the hive meta sync connection after each meta sync, does that logic still work after your change?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] boneanxs commented on pull request #8139: [HUDI-5909] Reuse hive client if possible

Posted by "boneanxs (via GitHub)" <gi...@apache.org>.
boneanxs commented on PR #8139:
URL: https://github.com/apache/hudi/pull/8139#issuecomment-1461380756

   > We try to close the hive meta sync connection after each meta sync, does that logic still work after your change?
   
   We don't close `HiveClient`, we just close SyncTool's metaClient


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #8139: [HUDI-5909] Reuse hive client if possible

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8139:
URL: https://github.com/apache/hudi/pull/8139#issuecomment-1463234376

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0bcd6490f856475266dfff3882728aa1392727f1",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15628",
       "triggerID" : "0bcd6490f856475266dfff3882728aa1392727f1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "075563866d156e36afe34780d5fb132d6da57251",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15649",
       "triggerID" : "075563866d156e36afe34780d5fb132d6da57251",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0bcd6490f856475266dfff3882728aa1392727f1 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15628) 
   * 075563866d156e36afe34780d5fb132d6da57251 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15649) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #8139: [HUDI-5909] Reuse hive client if possible

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8139:
URL: https://github.com/apache/hudi/pull/8139#issuecomment-1463230840

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0bcd6490f856475266dfff3882728aa1392727f1",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15628",
       "triggerID" : "0bcd6490f856475266dfff3882728aa1392727f1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "075563866d156e36afe34780d5fb132d6da57251",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "075563866d156e36afe34780d5fb132d6da57251",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0bcd6490f856475266dfff3882728aa1392727f1 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15628) 
   * 075563866d156e36afe34780d5fb132d6da57251 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org