You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by nitin-maharana <gi...@git.apache.org> on 2016/02/02 20:45:29 UTC

[GitHub] cloudstack pull request: CLOUDSTACK-9270: UI alignment gone bad in...

GitHub user nitin-maharana opened a pull request:

    https://github.com/apache/cloudstack/pull/1398

    CLOUDSTACK-9270: UI alignment gone bad in multiple places - VM Instance, Network, Egress rules

    Steps to Repro:
    ============
    Please see the snapshots attached. 
    
    Fix:
    ===
    Now it breaks into two lines once the word goes out of the box.
    Fixed the advanced search field issue.
    
    Network Section:
    =============
    ![network-section-nitin](https://cloud.githubusercontent.com/assets/12583725/12762032/66f27d32-ca13-11e5-8d0a-9c8f99a12a99.png)
    
    Adding VM to LB Rule:
    ==================
    ![adding-vm-to-lb-rule-nitin](https://cloud.githubusercontent.com/assets/12583725/12762050/76083cd0-ca13-11e5-873d-0037bc13a444.png)
    
    Affinity Group Section:
    ==================
    ![affinity-group-section-nitin](https://cloud.githubusercontent.com/assets/12583725/12762066/881c2a1c-ca13-11e5-8905-f72676151130.png)
    
    Fixed Affinity Group Section:
    ======================
    ![fix-affinity-group-section-nitin](https://cloud.githubusercontent.com/assets/12583725/12762083/990a673a-ca13-11e5-9d63-f895f9a1875c.png)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nitin-maharana/CloudStack-Nitin CloudStack-Nitin23_4.7

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1398.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1398
    
----
commit 7c7bee8bbaab58aab6d0f9eaf3b8c60cf45866a1
Author: Nitin Kumar Maharana <ni...@gmail.com>
Date:   2016-02-02T19:39:36Z

    CLOUDSTACK-9270: UI alignment gone bad in multiple places - VM Instance, Network, Egress rules
    
    Now it breaks into two lines once the word goes out of the box.
    Fixed the advanced search field issue.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9270: UI alignment gone bad in...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cloudstack/pull/1398


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9270: UI alignment gone bad in...

Posted by glennwagner <gi...@git.apache.org>.
Github user glennwagner commented on the pull request:

    https://github.com/apache/cloudstack/pull/1398#issuecomment-193325954
  
    LGTM no issues


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9270: UI alignment gone bad in...

Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:

    https://github.com/apache/cloudstack/pull/1398#issuecomment-179724866
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9270: UI alignment gone bad in...

Posted by koushik-das <gi...@git.apache.org>.
Github user koushik-das commented on the pull request:

    https://github.com/apache/cloudstack/pull/1398#issuecomment-212779591
  
    LGTM - verified on 4.7 that alignment is proper


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---