You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Pascal Parraud (JIRA)" <ji...@apache.org> on 2010/06/24 19:00:51 UTC

[jira] Created: (MATH-381) inconsistency for methods names within StepInterpolator and StepInterpolatorWithJacobians

inconsistency for methods names within StepInterpolator and StepInterpolatorWithJacobians
-----------------------------------------------------------------------------------------

                 Key: MATH-381
                 URL: https://issues.apache.org/jira/browse/MATH-381
             Project: Commons Math
          Issue Type: Bug
    Affects Versions: 2.1
            Reporter: Pascal Parraud
            Priority: Trivial


There is some inconstency in methods naming :
getInterpolatedY and getInterpolatedYDot in StepInterpolatorWithJacobians do the same as getInterpolatedState and getInterpolatedDerivatives in StepInterpolator, so it will be better if they would have the same name.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MATH-381) inconsistency for methods names within StepInterpolator and StepInterpolatorWithJacobians

Posted by "Luc Maisonobe (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MATH-381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Luc Maisonobe updated MATH-381:
-------------------------------

    Fix Version/s: 3.0
                       (was: 2.2)

Yes, I pushed this to 3.0.
However, the refactoring proposed in my previous comment should be done for 2.2.
I'm working on it.

> inconsistency for methods names within StepInterpolator and StepInterpolatorWithJacobians
> -----------------------------------------------------------------------------------------
>
>                 Key: MATH-381
>                 URL: https://issues.apache.org/jira/browse/MATH-381
>             Project: Commons Math
>          Issue Type: Bug
>    Affects Versions: 2.1
>            Reporter: Pascal Parraud
>            Priority: Trivial
>             Fix For: 3.0
>
>
> There is some inconstency in methods naming :
> getInterpolatedY and getInterpolatedYDot in StepInterpolatorWithJacobians do the same as getInterpolatedState and getInterpolatedDerivatives in StepInterpolator, so it will be better if they would have the same name.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MATH-381) inconsistency for methods names within StepInterpolator and StepInterpolatorWithJacobians

Posted by "Phil Steitz (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MATH-381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12901249#action_12901249 ] 

Phil Steitz commented on MATH-381:
----------------------------------

Should this move to 3.0, given compatibility issues?

> inconsistency for methods names within StepInterpolator and StepInterpolatorWithJacobians
> -----------------------------------------------------------------------------------------
>
>                 Key: MATH-381
>                 URL: https://issues.apache.org/jira/browse/MATH-381
>             Project: Commons Math
>          Issue Type: Bug
>    Affects Versions: 2.1
>            Reporter: Pascal Parraud
>            Priority: Trivial
>             Fix For: 2.2
>
>
> There is some inconstency in methods naming :
> getInterpolatedY and getInterpolatedYDot in StepInterpolatorWithJacobians do the same as getInterpolatedState and getInterpolatedDerivatives in StepInterpolator, so it will be better if they would have the same name.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MATH-381) inconsistency for methods names within StepInterpolator and StepInterpolatorWithJacobians

Posted by "Luc Maisonobe (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MATH-381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12882305#action_12882305 ] 

Luc Maisonobe commented on MATH-381:
------------------------------------

Agreed.
This will be fixed in the new design which should in fact completely remove the need for StepInterpolatorWithJacobians and replae it by something else.

> inconsistency for methods names within StepInterpolator and StepInterpolatorWithJacobians
> -----------------------------------------------------------------------------------------
>
>                 Key: MATH-381
>                 URL: https://issues.apache.org/jira/browse/MATH-381
>             Project: Commons Math
>          Issue Type: Bug
>    Affects Versions: 2.1
>            Reporter: Pascal Parraud
>            Priority: Trivial
>
> There is some inconstency in methods naming :
> getInterpolatedY and getInterpolatedYDot in StepInterpolatorWithJacobians do the same as getInterpolatedState and getInterpolatedDerivatives in StepInterpolator, so it will be better if they would have the same name.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (MATH-381) inconsistency for methods names within StepInterpolator and StepInterpolatorWithJacobians

Posted by "Luc Maisonobe (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MATH-381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12901289#action_12901289 ] 

Luc Maisonobe edited comment on MATH-381 at 8/23/10 3:28 AM:
-------------------------------------------------------------

Yes, I pushed this to 3.0.
However, the refactoring proposed in my previous comment should be done for 2.2. This means that the new implementation should be made available in 2.2 and the old one deprecated. Then in 3.0 the old deprecated implementation should be removed.
I'm working on it.

      was (Author: luc):
    Yes, I pushed this to 3.0.
However, the refactoring proposed in my previous comment should be done for 2.2.
I'm working on it.
  
> inconsistency for methods names within StepInterpolator and StepInterpolatorWithJacobians
> -----------------------------------------------------------------------------------------
>
>                 Key: MATH-381
>                 URL: https://issues.apache.org/jira/browse/MATH-381
>             Project: Commons Math
>          Issue Type: Bug
>    Affects Versions: 2.1
>            Reporter: Pascal Parraud
>            Priority: Trivial
>             Fix For: 3.0
>
>
> There is some inconstency in methods naming :
> getInterpolatedY and getInterpolatedYDot in StepInterpolatorWithJacobians do the same as getInterpolatedState and getInterpolatedDerivatives in StepInterpolator, so it will be better if they would have the same name.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MATH-381) inconsistency for methods names within StepInterpolator and StepInterpolatorWithJacobians

Posted by "Luc Maisonobe (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MATH-381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Luc Maisonobe updated MATH-381:
-------------------------------

    Fix Version/s: 2.2

We need the refactoring of ODE with Jacobians to be done for 2.2

> inconsistency for methods names within StepInterpolator and StepInterpolatorWithJacobians
> -----------------------------------------------------------------------------------------
>
>                 Key: MATH-381
>                 URL: https://issues.apache.org/jira/browse/MATH-381
>             Project: Commons Math
>          Issue Type: Bug
>    Affects Versions: 2.1
>            Reporter: Pascal Parraud
>            Priority: Trivial
>             Fix For: 2.2
>
>
> There is some inconstency in methods naming :
> getInterpolatedY and getInterpolatedYDot in StepInterpolatorWithJacobians do the same as getInterpolatedState and getInterpolatedDerivatives in StepInterpolator, so it will be better if they would have the same name.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.