[GitHub] [samza] xinyuiscool commented on a change in pull request #1034: SAMZA-2185: Add ability to expose remote store specific features in remote table

[GitBox <gi...@apache.org>]

xinyuiscool commented on a change in pull request #1034: SAMZA-2185: Add ability to expose remote store specific features in remote table
URL: https://github.com/apache/samza/pull/1034#discussion_r284824006
 
 

 ##########
 File path: samza-api/src/main/java/org/apache/samza/table/ReadWriteTable.java
 ##########
 @@ -59,33 +61,37 @@
    *
    * @param key the key with which the specified {@code value} is to be associated.
    * @param value the value with which the specified {@code key} is to be associated.
+   * @param args additional arguments
    * @throws NullPointerException if the specified {@code key} is {@code null}.
    */
-  void put(K key, V value);
+  void put(K key, V value, Object ... args);
 
   /**
    * Updates the mappings of the specified key-value {@code entries}.
    *
    * A key is deleted from the table if its corresponding value is {@code null}.
    *
    * @param entries the updated mappings to put into this table.
+   * @param args additional arguments
    * @throws NullPointerException if any of the specified {@code entries} has {@code null} as key.
    */
-  void putAll(List<Entry<K, V>> entries);
+  void putAll(List<Entry<K, V>> entries, Object ... args);
 
   /**
    * Deletes the mapping for the specified {@code key} from this table (if such mapping exists).
    *
    * @param key the key for which the mapping is to be deleted.
+   * @param args additional arguments
    * @throws NullPointerException if the specified {@code key} is {@code null}.
    */
-  void delete(K key);
+  void delete(K key, Object ... args);
 
   /**
    * Deletes the mappings for the specified {@code keys} from this table.
    *
    * @param keys the keys for which the mappings are to be deleted.
+   * @param args additional arguments
    * @throws NullPointerException if the specified {@code keys} list, or any of the keys, is {@code null}.
    */
-  void deleteAll(List<K> keys);
+  void deleteAll(List<K> keys, Object ... args);
 }
 
 Review comment:
   Shall we also add read() and write() too?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services