[GitHub] gianm commented on a change in pull request #6875: Fix fallback to cursor-based plan in UseIndexesStrategy

[GitBox <gi...@apache.org>]

gianm commented on a change in pull request #6875: Fix fallback to cursor-based plan in UseIndexesStrategy
URL: https://github.com/apache/incubator-druid/pull/6875#discussion_r248471494
 
 

 ##########
 File path: processing/src/main/java/org/apache/druid/query/search/UseIndexesStrategy.java
 ##########
 @@ -134,10 +134,7 @@ private UseIndexesStrategy(
       }
     }
 
-    return new Pair<List<DimensionSpec>, List<DimensionSpec>>(
-        ImmutableList.copyOf(bitmapDims),
-        ImmutableList.copyOf(nonBitmapDims)
-    );
+    return new Pair<>(bitmapDims, nonBitmapDims);
 
 Review comment:
   Please document, via javadoc, that this method returns editable lists that the caller is free to edit. That's not typical; callers should generally assume that they should _not_ edit the list that comes back from a method, since it might be "owned" by someone else.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org