You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "SteNicholas (via GitHub)" <gi...@apache.org> on 2023/12/28 06:05:02 UTC
[PR] [CELEBORN-1202] LICENSE mentions third-party components under other open source licenses [incubator-celeborn]
SteNicholas opened a new pull request, #2193:
URL: https://github.com/apache/incubator-celeborn/pull/2193
### What changes were proposed in this pull request?
`LICENSE` mentions third-party components under other open source licenses like Apache Spark etc.
### Why are the changes needed?
`LICENSE` mentions 1 3rd party file from Guava. However, the `NOTICE` lists both Apache Spark and Apache Flink. `LICENSE` should mention all third-party components under other open source licenses.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1202] LICENSE mentions third-party components under other open source licenses [incubator-celeborn]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on code in PR #2193:
URL: https://github.com/apache/incubator-celeborn/pull/2193#discussion_r1440121607
##########
LICENSE:
##########
@@ -210,4 +210,38 @@ for text of these licenses.
Apache License 2.0
--------------------------------------
-common/src/main/java/org/apache/celeborn/common/network/util/LimitedInputStream.java
+Apache Spark
+./client-spark/spark-2/src/main/java/org/apache/spark/shuffle/celeborn/SparkUtils.java
+./client-spark/spark-3/src/main/java/org/apache/spark/shuffle/celeborn/SparkUtils.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/DB.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/DBIterator.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/LevelDB.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/LevelDBProvider.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/RocksDBIterator.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/StoreVersion.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/DBBackend.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/DBProvider.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/LevelDBIterator.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/RocksDB.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/RocksDBProvider.java
+
+Apache Kyuubi
+./common/src/main/java/org/apache/celeborn/reflect/DynClasses.java
+./common/src/main/java/org/apache/celeborn/reflect/DynConstructors.java
+./common/src/main/java/org/apache/celeborn/reflect/DynFields.java
+./common/src/main/java/org/apache/celeborn/reflect/DynMethods.java
+./dev/checkout_pr.sh
Review Comment:
@justinmclean, I have started new vote thread: [[VOTE] Release Apache Celeborn(Incubating) 0.3.2-incubating-rc2](https://lists.apache.org/thread/4zks008fyqo5om6tg0872xbz9wt562ds). If you are available, please help to check this rc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1202] LICENSE mentions third-party components under other open source licenses [incubator-celeborn]
Posted by "carp84 (via GitHub)" <gi...@apache.org>.
carp84 commented on code in PR #2193:
URL: https://github.com/apache/incubator-celeborn/pull/2193#discussion_r1438166063
##########
LICENSE:
##########
@@ -210,4 +210,38 @@ for text of these licenses.
Apache License 2.0
--------------------------------------
-common/src/main/java/org/apache/celeborn/common/network/util/LimitedInputStream.java
Review Comment:
ok, missed since there're quite some comments in between. Thanks for the clarification guys.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1202] LICENSE mentions third-party components under other open source licenses [incubator-celeborn]
Posted by "carp84 (via GitHub)" <gi...@apache.org>.
carp84 commented on code in PR #2193:
URL: https://github.com/apache/incubator-celeborn/pull/2193#discussion_r1437980522
##########
LICENSE:
##########
@@ -210,4 +210,38 @@ for text of these licenses.
Apache License 2.0
--------------------------------------
-common/src/main/java/org/apache/celeborn/common/network/util/LimitedInputStream.java
Review Comment:
Why do we remove this line? This is required because the `LimitedInputStream` class stems from Guava and is still bundled in our source package.
Please be cautious to remove any line in the LICENSE file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1202] LICENSE mentions third-party components under other open source licenses [incubator-celeborn]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #2193:
URL: https://github.com/apache/incubator-celeborn/pull/2193#discussion_r1437989732
##########
LICENSE:
##########
@@ -210,4 +210,38 @@ for text of these licenses.
Apache License 2.0
--------------------------------------
-common/src/main/java/org/apache/celeborn/common/network/util/LimitedInputStream.java
Review Comment:
it is moved to line 236
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1202] LICENSE mentions third-party components under other open source licenses [incubator-celeborn]
Posted by "CalvinKirs (via GitHub)" <gi...@apache.org>.
CalvinKirs commented on code in PR #2193:
URL: https://github.com/apache/incubator-celeborn/pull/2193#discussion_r1437974602
##########
LICENSE:
##########
@@ -210,4 +210,38 @@ for text of these licenses.
Apache License 2.0
--------------------------------------
-common/src/main/java/org/apache/celeborn/common/network/util/LimitedInputStream.java
+Apache Spark
+./client-spark/spark-2/src/main/java/org/apache/spark/shuffle/celeborn/SparkUtils.java
+./client-spark/spark-3/src/main/java/org/apache/spark/shuffle/celeborn/SparkUtils.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/DB.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/DBIterator.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/LevelDB.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/LevelDBProvider.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/RocksDBIterator.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/StoreVersion.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/DBBackend.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/DBProvider.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/LevelDBIterator.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/RocksDB.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/RocksDBProvider.java
+
+Apache Kyuubi
+./common/src/main/java/org/apache/celeborn/reflect/DynClasses.java
+./common/src/main/java/org/apache/celeborn/reflect/DynConstructors.java
+./common/src/main/java/org/apache/celeborn/reflect/DynFields.java
+./common/src/main/java/org/apache/celeborn/reflect/DynMethods.java
+./dev/checkout_pr.sh
Review Comment:
https://github.com/apache/iceberg/tree/22d4e7836ac0bb47bed627e7c773d44105b8f0f8/common/src/main/java/org/apache/iceberg/common
Sorry, I checked the source of the code again, these codes should come from iceberg, not Kyuubi. at least that's how it looks on the timeline.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1202] LICENSE mentions third-party components under other open source licenses [incubator-celeborn]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #2193:
URL: https://github.com/apache/incubator-celeborn/pull/2193#discussion_r1438004853
##########
LICENSE:
##########
@@ -210,4 +210,38 @@ for text of these licenses.
Apache License 2.0
--------------------------------------
-common/src/main/java/org/apache/celeborn/common/network/util/LimitedInputStream.java
+Apache Spark
+./client-spark/spark-2/src/main/java/org/apache/spark/shuffle/celeborn/SparkUtils.java
+./client-spark/spark-3/src/main/java/org/apache/spark/shuffle/celeborn/SparkUtils.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/DB.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/DBIterator.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/LevelDB.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/LevelDBProvider.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/RocksDBIterator.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/StoreVersion.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/DBBackend.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/DBProvider.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/LevelDBIterator.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/RocksDB.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/RocksDBProvider.java
+
+Apache Kyuubi
+./common/src/main/java/org/apache/celeborn/reflect/DynClasses.java
+./common/src/main/java/org/apache/celeborn/reflect/DynConstructors.java
+./common/src/main/java/org/apache/celeborn/reflect/DynFields.java
+./common/src/main/java/org/apache/celeborn/reflect/DynMethods.java
+./dev/checkout_pr.sh
Review Comment:
Yeah, I know the LICENSE header's rule, it's documented under the ASF website clearly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1202] LICENSE mentions third-party components under other open source licenses [incubator-celeborn]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #2193:
URL: https://github.com/apache/incubator-celeborn/pull/2193#issuecomment-1870861553
## [Codecov](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2193?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Comparison is base [(`6691568`)](https://app.codecov.io/gh/apache/incubator-celeborn/commit/669156824271caec03f2f1f62c48c02cd870e684?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 47.26% compared to head [(`c851aba`)](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2193?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 47.25%.
> :exclamation: Current head c851aba differs from pull request most recent head 7e980cc. Consider uploading reports for the commit 7e980cc to get more accurate results
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #2193 +/- ##
==========================================
- Coverage 47.26% 47.25% -0.00%
==========================================
Files 185 185
Lines 11717 11717
Branches 1043 1043
==========================================
- Hits 5537 5536 -1
- Misses 5813 5815 +2
+ Partials 367 366 -1
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2193?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1202] LICENSE mentions third-party components under other open source licenses [incubator-celeborn]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #2193:
URL: https://github.com/apache/incubator-celeborn/pull/2193#issuecomment-1871860996
From the context, I think there is no blocking issue about LICENSE now, will prepare for the next RC soon, and we are open to having additional discussions on LICENSE-related topics on this thread or mailing list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1202] LICENSE mentions third-party components under other open source licenses [incubator-celeborn]
Posted by "justinmclean (via GitHub)" <gi...@apache.org>.
justinmclean commented on code in PR #2193:
URL: https://github.com/apache/incubator-celeborn/pull/2193#discussion_r1437999411
##########
LICENSE:
##########
@@ -210,4 +210,38 @@ for text of these licenses.
Apache License 2.0
--------------------------------------
-common/src/main/java/org/apache/celeborn/common/network/util/LimitedInputStream.java
+Apache Spark
+./client-spark/spark-2/src/main/java/org/apache/spark/shuffle/celeborn/SparkUtils.java
+./client-spark/spark-3/src/main/java/org/apache/spark/shuffle/celeborn/SparkUtils.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/DB.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/DBIterator.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/LevelDB.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/LevelDBProvider.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/RocksDBIterator.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/StoreVersion.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/DBBackend.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/DBProvider.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/LevelDBIterator.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/RocksDB.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/RocksDBProvider.java
+
+Apache Kyuubi
+./common/src/main/java/org/apache/celeborn/reflect/DynClasses.java
+./common/src/main/java/org/apache/celeborn/reflect/DynConstructors.java
+./common/src/main/java/org/apache/celeborn/reflect/DynFields.java
+./common/src/main/java/org/apache/celeborn/reflect/DynMethods.java
+./dev/checkout_pr.sh
Review Comment:
Listing the files in LICENSE is a good idea so users know where they come from. Is it not a requirement, but anything that makes the licenses easier to check is good by me. If you copied them from Apache Kyuubi, I would use their NOTICE file contents.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1202] LICENSE mentions third-party components under other open source licenses [incubator-celeborn]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #2193:
URL: https://github.com/apache/incubator-celeborn/pull/2193#discussion_r1437996177
##########
LICENSE:
##########
@@ -210,4 +210,38 @@ for text of these licenses.
Apache License 2.0
--------------------------------------
-common/src/main/java/org/apache/celeborn/common/network/util/LimitedInputStream.java
+Apache Spark
+./client-spark/spark-2/src/main/java/org/apache/spark/shuffle/celeborn/SparkUtils.java
+./client-spark/spark-3/src/main/java/org/apache/spark/shuffle/celeborn/SparkUtils.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/DB.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/DBIterator.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/LevelDB.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/LevelDBProvider.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/RocksDBIterator.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/StoreVersion.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/DBBackend.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/DBProvider.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/LevelDBIterator.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/RocksDB.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/RocksDBProvider.java
+
+Apache Kyuubi
+./common/src/main/java/org/apache/celeborn/reflect/DynClasses.java
+./common/src/main/java/org/apache/celeborn/reflect/DynConstructors.java
+./common/src/main/java/org/apache/celeborn/reflect/DynFields.java
+./common/src/main/java/org/apache/celeborn/reflect/DynMethods.java
+./dev/checkout_pr.sh
Review Comment:
AFAIK, the `Dyn*` classes originated from the Apache Parquet project, then were borrowed by Apache Iceberg, Apache Kyuubi, and I copied them to Apache Celeborn (incubating). Specifically, I copied a modified version of the Kyuubi project. How should I write the NOTICE or LICENSE is correct then?
I had thought that copying code across ASF projects did not require listing files under LICENSE, because, legally speaking, the copyright owner of the code is ASF, not some natural persons.
> I think this is redundant, the author of the file belongs to the same person.
Sorry, I don't know such a rule. Could you clarify where I can find such guidance that clearly states that the same author could legally contribute the same code to different projects without declarations, even though the copyright of the code belongs to different organizations or companies?
Let's say Tom contributes some code to a project under the GPL license, and the copyright owner is company A. Could Tom legally contribute the same code to an ASF project, without any declarations?
I think all code contributed to the ASF projects belongs to ASF, there is no difference between different contributors.
TBH, different people have different interpretations of LICENSE rules, I believe that I and other community members always respond positively when someone, especially someone we consider to be an expert in the field, to adapt to the guidance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1202] LICENSE mentions third-party components under other open source licenses [incubator-celeborn]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #2193:
URL: https://github.com/apache/incubator-celeborn/pull/2193#discussion_r1438037957
##########
LICENSE:
##########
@@ -210,4 +210,38 @@ for text of these licenses.
Apache License 2.0
--------------------------------------
-common/src/main/java/org/apache/celeborn/common/network/util/LimitedInputStream.java
+Apache Spark
+./client-spark/spark-2/src/main/java/org/apache/spark/shuffle/celeborn/SparkUtils.java
+./client-spark/spark-3/src/main/java/org/apache/spark/shuffle/celeborn/SparkUtils.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/DB.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/DBIterator.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/LevelDB.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/LevelDBProvider.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/RocksDBIterator.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/StoreVersion.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/DBBackend.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/DBProvider.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/LevelDBIterator.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/RocksDB.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/RocksDBProvider.java
+
+Apache Kyuubi
+./common/src/main/java/org/apache/celeborn/reflect/DynClasses.java
+./common/src/main/java/org/apache/celeborn/reflect/DynConstructors.java
+./common/src/main/java/org/apache/celeborn/reflect/DynFields.java
+./common/src/main/java/org/apache/celeborn/reflect/DynMethods.java
+./dev/checkout_pr.sh
Review Comment:
> it is hard to know where a given file comes from.
we usually document where the code comes from in the class javadocs :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1202] LICENSE mentions third-party components under other open source licenses [incubator-celeborn]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on PR #2193:
URL: https://github.com/apache/incubator-celeborn/pull/2193#issuecomment-1871043177
> @justinmclean Celeborn has copied some codes from the remote shuffle service for flink [https://github.com/flink-extended/flink-remote-shuffle]. There are no codes copied from flink directly. Adding "flink" into NOTICE might be a misunderstanding.
@justinmclean, do you have other comments for this pull request?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1202] LICENSE mentions third-party components under other open source licenses [incubator-celeborn]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #2193:
URL: https://github.com/apache/incubator-celeborn/pull/2193#discussion_r1438001796
##########
LICENSE:
##########
@@ -210,4 +210,38 @@ for text of these licenses.
Apache License 2.0
--------------------------------------
-common/src/main/java/org/apache/celeborn/common/network/util/LimitedInputStream.java
+Apache Spark
+./client-spark/spark-2/src/main/java/org/apache/spark/shuffle/celeborn/SparkUtils.java
+./client-spark/spark-3/src/main/java/org/apache/spark/shuffle/celeborn/SparkUtils.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/DB.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/DBIterator.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/LevelDB.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/LevelDBProvider.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/RocksDBIterator.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/StoreVersion.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/DBBackend.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/DBProvider.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/LevelDBIterator.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/RocksDB.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/RocksDBProvider.java
+
+Apache Kyuubi
+./common/src/main/java/org/apache/celeborn/reflect/DynClasses.java
+./common/src/main/java/org/apache/celeborn/reflect/DynConstructors.java
+./common/src/main/java/org/apache/celeborn/reflect/DynFields.java
+./common/src/main/java/org/apache/celeborn/reflect/DynMethods.java
+./dev/checkout_pr.sh
Review Comment:
@justinmclean thanks for your clarification.
In the past, when borrowing code from external projects(non-ASF projects) to an ASF project, I would carefully evaluate the LICENSE and list the copied files under LICENSE, also mentioned in NOTICE. In the future, I will follow your guidance to list files copied from ASF projects too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1202] LICENSE mentions third-party components under other open source licenses [incubator-celeborn]
Posted by "justinmclean (via GitHub)" <gi...@apache.org>.
justinmclean commented on code in PR #2193:
URL: https://github.com/apache/incubator-celeborn/pull/2193#discussion_r1438004269
##########
LICENSE:
##########
@@ -210,4 +210,38 @@ for text of these licenses.
Apache License 2.0
--------------------------------------
-common/src/main/java/org/apache/celeborn/common/network/util/LimitedInputStream.java
+Apache Spark
+./client-spark/spark-2/src/main/java/org/apache/spark/shuffle/celeborn/SparkUtils.java
+./client-spark/spark-3/src/main/java/org/apache/spark/shuffle/celeborn/SparkUtils.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/DB.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/DBIterator.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/LevelDB.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/LevelDBProvider.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/RocksDBIterator.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/StoreVersion.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/DBBackend.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/DBProvider.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/LevelDBIterator.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/RocksDB.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/RocksDBProvider.java
+
+Apache Kyuubi
+./common/src/main/java/org/apache/celeborn/reflect/DynClasses.java
+./common/src/main/java/org/apache/celeborn/reflect/DynConstructors.java
+./common/src/main/java/org/apache/celeborn/reflect/DynFields.java
+./common/src/main/java/org/apache/celeborn/reflect/DynMethods.java
+./dev/checkout_pr.sh
Review Comment:
Note that third-party Apache Licensed files will have different headers. All ASF project files have the same header, so it is hard to know where a given file comes from.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1202] LICENSE mentions third-party components under other open source licenses [incubator-celeborn]
Posted by "FMX (via GitHub)" <gi...@apache.org>.
FMX commented on PR #2193:
URL: https://github.com/apache/incubator-celeborn/pull/2193#issuecomment-1870915947
@justinmclean Celeborn has copied some codes from the remote shuffle service for flink [https://github.com/flink-extended/flink-remote-shuffle]. There are no codes copied from flink directly. Adding "flink" into NOTICE might be a misunderstanding.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1202] LICENSE mentions third-party components under other open source licenses [incubator-celeborn]
Posted by "FMX (via GitHub)" <gi...@apache.org>.
FMX closed pull request #2193: [CELEBORN-1202] LICENSE mentions third-party components under other open source licenses
URL: https://github.com/apache/incubator-celeborn/pull/2193
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1202] LICENSE mentions third-party components under other open source licenses [incubator-celeborn]
Posted by "justinmclean (via GitHub)" <gi...@apache.org>.
justinmclean commented on PR #2193:
URL: https://github.com/apache/incubator-celeborn/pull/2193#issuecomment-1870866642
Why was Apache Flink removed from NOTICE? There must have been a reason why it was added in the first place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1202] LICENSE mentions third-party components under other open source licenses [incubator-celeborn]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #2193:
URL: https://github.com/apache/incubator-celeborn/pull/2193#issuecomment-1870868784
cc @RexXiong @zhongqiangczq who familiar with the Flink modules
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1202] LICENSE mentions third-party components under other open source licenses [incubator-celeborn]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on code in PR #2193:
URL: https://github.com/apache/incubator-celeborn/pull/2193#discussion_r1438048794
##########
LICENSE:
##########
@@ -210,4 +210,38 @@ for text of these licenses.
Apache License 2.0
--------------------------------------
-common/src/main/java/org/apache/celeborn/common/network/util/LimitedInputStream.java
Review Comment:
@carp84, `LimitedInputStream` uses the Guava third party and I have moved to line 236. Does not remove this line. PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1202] LICENSE mentions third-party components under other open source licenses [incubator-celeborn]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #2193:
URL: https://github.com/apache/incubator-celeborn/pull/2193#discussion_r1437996177
##########
LICENSE:
##########
@@ -210,4 +210,38 @@ for text of these licenses.
Apache License 2.0
--------------------------------------
-common/src/main/java/org/apache/celeborn/common/network/util/LimitedInputStream.java
+Apache Spark
+./client-spark/spark-2/src/main/java/org/apache/spark/shuffle/celeborn/SparkUtils.java
+./client-spark/spark-3/src/main/java/org/apache/spark/shuffle/celeborn/SparkUtils.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/DB.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/DBIterator.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/LevelDB.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/LevelDBProvider.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/RocksDBIterator.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/StoreVersion.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/DBBackend.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/DBProvider.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/LevelDBIterator.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/RocksDB.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/RocksDBProvider.java
+
+Apache Kyuubi
+./common/src/main/java/org/apache/celeborn/reflect/DynClasses.java
+./common/src/main/java/org/apache/celeborn/reflect/DynConstructors.java
+./common/src/main/java/org/apache/celeborn/reflect/DynFields.java
+./common/src/main/java/org/apache/celeborn/reflect/DynMethods.java
+./dev/checkout_pr.sh
Review Comment:
AFAIK, the `Dyn*` classes originated from the Apache Parquet project, then were borrowed by Apache Iceberg, Apache Kyuubi, and I copied them to Apache Celeborn (incubating). Specifically, I copied a modified version of the Kyuubi project. How should I write the NOTICE or LICENSE is correct then?
I had thought that copying code across ASF projects did not require listing files under LICENSE, because, legally speaking, the copyright owner of the code is ASF, not some natural persons.
> I think this is redundant, the author of the file belongs to the same person.
Sorry, I don't know such a rule. Could you clarify where I can find such guidance that clearly states that the same author could legally contribute the same code to different projects without declarations, even though the copyright of the code belongs to different organizations or companies?
Let's say Tom contributes some code to a project under the GPL license, and the copyright owner is company A. Could Tom legally contribute the same code to an ASF project, without any declarations?
I think all code contributed to the ASF projects belongs to ASF, there is no difference between different contributors.
TBH, different people have different interpretations of LICENSE rules, I believe that I and other community members always respond positively when someone raises concerns, especially someone we consider to be an expert in the field, to adapt to the guidance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1202] LICENSE mentions third-party components under other open source licenses [incubator-celeborn]
Posted by "CalvinKirs (via GitHub)" <gi...@apache.org>.
CalvinKirs commented on code in PR #2193:
URL: https://github.com/apache/incubator-celeborn/pull/2193#discussion_r1437972158
##########
LICENSE:
##########
@@ -210,4 +210,38 @@ for text of these licenses.
Apache License 2.0
--------------------------------------
-common/src/main/java/org/apache/celeborn/common/network/util/LimitedInputStream.java
+Apache Spark
+./client-spark/spark-2/src/main/java/org/apache/spark/shuffle/celeborn/SparkUtils.java
+./client-spark/spark-3/src/main/java/org/apache/spark/shuffle/celeborn/SparkUtils.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/DB.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/DBIterator.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/LevelDB.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/LevelDBProvider.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/RocksDBIterator.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/StoreVersion.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/DBBackend.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/DBProvider.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/LevelDBIterator.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/RocksDB.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/RocksDBProvider.java
+
+Apache Kyuubi
+./common/src/main/java/org/apache/celeborn/reflect/DynClasses.java
+./common/src/main/java/org/apache/celeborn/reflect/DynConstructors.java
+./common/src/main/java/org/apache/celeborn/reflect/DynFields.java
+./common/src/main/java/org/apache/celeborn/reflect/DynMethods.java
+./dev/checkout_pr.sh
Review Comment:
I think this is redundant, the author of the file belongs to the same person.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1202] LICENSE mentions third-party components under other open source licenses [incubator-celeborn]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #2193:
URL: https://github.com/apache/incubator-celeborn/pull/2193#discussion_r1437996177
##########
LICENSE:
##########
@@ -210,4 +210,38 @@ for text of these licenses.
Apache License 2.0
--------------------------------------
-common/src/main/java/org/apache/celeborn/common/network/util/LimitedInputStream.java
+Apache Spark
+./client-spark/spark-2/src/main/java/org/apache/spark/shuffle/celeborn/SparkUtils.java
+./client-spark/spark-3/src/main/java/org/apache/spark/shuffle/celeborn/SparkUtils.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/DB.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/DBIterator.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/LevelDB.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/LevelDBProvider.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/RocksDBIterator.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/StoreVersion.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/DBBackend.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/DBProvider.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/LevelDBIterator.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/RocksDB.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/RocksDBProvider.java
+
+Apache Kyuubi
+./common/src/main/java/org/apache/celeborn/reflect/DynClasses.java
+./common/src/main/java/org/apache/celeborn/reflect/DynConstructors.java
+./common/src/main/java/org/apache/celeborn/reflect/DynFields.java
+./common/src/main/java/org/apache/celeborn/reflect/DynMethods.java
+./dev/checkout_pr.sh
Review Comment:
AFAIK, the `Dyn*` classes originated from the Apache Parquet project, then were borrowed by Apache Iceberg, Apache Kyuubi, and I copied them to Apache Celeborn (incubating). Specifically, I copied a modified version of the Kyuubi project. How should I write the NOTICE or LICENSE is correct then?
I had thought that copying code across ASF projects did not require listing files under LICENSE, because, legally speaking, the copyright owner of the code is ASF, not some natural persons.
> I think this is redundant, the author of the file belongs to the same person.
Sorry, I don't know such a rule. Could you clarify where I can find such guidance that clearly states that the same author could legally contribute the same code to different projects without declarations, even though the copyright of the code belongs to different organizations or companies?
Let's say Tom contributes some code to a project under the GPL license, and the copyright owner is company A. Could Tom legally contribute the same code to an ASF project, without any declarations?
I think all code contributed to the ASF projects belongs to ASF, there is no difference between different contributors.
TBH, different people have different interpretations of LICENSE rules, I believe that I and other community members always respond positively when someone, especially someone we consider to be an expert in the field, adapts to the guidance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1202] LICENSE mentions third-party components under other open source licenses [incubator-celeborn]
Posted by "carp84 (via GitHub)" <gi...@apache.org>.
carp84 commented on PR #2193:
URL: https://github.com/apache/incubator-celeborn/pull/2193#issuecomment-1871723449
@SteNicholas Please note that there are more comments here although the PR is already merged, and hold the new RC until the comments are addressed. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1202] LICENSE mentions third-party components under other open source licenses [incubator-celeborn]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #2193:
URL: https://github.com/apache/incubator-celeborn/pull/2193#discussion_r1438066174
##########
LICENSE:
##########
@@ -210,4 +210,38 @@ for text of these licenses.
Apache License 2.0
--------------------------------------
-common/src/main/java/org/apache/celeborn/common/network/util/LimitedInputStream.java
+Apache Spark
+./client-spark/spark-2/src/main/java/org/apache/spark/shuffle/celeborn/SparkUtils.java
+./client-spark/spark-3/src/main/java/org/apache/spark/shuffle/celeborn/SparkUtils.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/DB.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/DBIterator.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/LevelDB.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/LevelDBProvider.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/RocksDBIterator.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/StoreVersion.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/DBBackend.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/DBProvider.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/LevelDBIterator.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/RocksDB.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/RocksDBProvider.java
+
+Apache Kyuubi
+./common/src/main/java/org/apache/celeborn/reflect/DynClasses.java
+./common/src/main/java/org/apache/celeborn/reflect/DynConstructors.java
+./common/src/main/java/org/apache/celeborn/reflect/DynFields.java
+./common/src/main/java/org/apache/celeborn/reflect/DynMethods.java
+./dev/checkout_pr.sh
Review Comment:
@CalvinKirs would you mind providing the legal basis for your statement? especially are those provisions documented under the Apache official site? I may miss something.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1202] LICENSE mentions third-party components under other open source licenses [incubator-celeborn]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on PR #2193:
URL: https://github.com/apache/incubator-celeborn/pull/2193#issuecomment-1871130294
@justinmclean, the NOTICE file has also updated with the modification of the LISENCE. PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1202] LICENSE mentions third-party components under other open source licenses [incubator-celeborn]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #2193:
URL: https://github.com/apache/incubator-celeborn/pull/2193#discussion_r1437996177
##########
LICENSE:
##########
@@ -210,4 +210,38 @@ for text of these licenses.
Apache License 2.0
--------------------------------------
-common/src/main/java/org/apache/celeborn/common/network/util/LimitedInputStream.java
+Apache Spark
+./client-spark/spark-2/src/main/java/org/apache/spark/shuffle/celeborn/SparkUtils.java
+./client-spark/spark-3/src/main/java/org/apache/spark/shuffle/celeborn/SparkUtils.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/DB.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/DBIterator.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/LevelDB.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/LevelDBProvider.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/RocksDBIterator.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/StoreVersion.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/DBBackend.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/DBProvider.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/LevelDBIterator.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/RocksDB.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/RocksDBProvider.java
+
+Apache Kyuubi
+./common/src/main/java/org/apache/celeborn/reflect/DynClasses.java
+./common/src/main/java/org/apache/celeborn/reflect/DynConstructors.java
+./common/src/main/java/org/apache/celeborn/reflect/DynFields.java
+./common/src/main/java/org/apache/celeborn/reflect/DynMethods.java
+./dev/checkout_pr.sh
Review Comment:
AFAIK, the `Dyn*` classes originated from the Apache Parquet project, then
were borrowed by Apache Iceberg, Apache Kyuubi, and I copied them to Apache Celeborn (incubating). Specifically, I copied a modified version of the Kyuubi project. How should I write the NOTICE or LICENSE is correct then?
I had thought that copying code across ASF projects did not require listing files under LICENSE, because, legally speaking, the copyright owner of the code is ASF, not some natural persons.
> I think this is redundant, the author of the file belongs to the same person.
Sorry, I don't know such a rule. Could you clarify where I can find such guidance that clearly states that the same author could legally contribute the same code to different projects without declarations, even though the copyright of the code belongs to different organizations or companies?
Let's say Tom contributes some code to a project under the GPL license, and the copyright owner is company A. Could Tom legally contribute the same code to an ASF project, without any declarations?
I think all code contributed to the ASF projects belongs to ASF, there is no difference between different contributors.
TBH, different people have different interpretations of LICENSE rules, I believe that I and other community members always respond positively when someone, especially someone we consider to be an expert in the field, adapts to the guidance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1202] LICENSE mentions third-party components under other open source licenses [incubator-celeborn]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #2193:
URL: https://github.com/apache/incubator-celeborn/pull/2193#discussion_r1438001796
##########
LICENSE:
##########
@@ -210,4 +210,38 @@ for text of these licenses.
Apache License 2.0
--------------------------------------
-common/src/main/java/org/apache/celeborn/common/network/util/LimitedInputStream.java
+Apache Spark
+./client-spark/spark-2/src/main/java/org/apache/spark/shuffle/celeborn/SparkUtils.java
+./client-spark/spark-3/src/main/java/org/apache/spark/shuffle/celeborn/SparkUtils.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/DB.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/DBIterator.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/LevelDB.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/LevelDBProvider.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/RocksDBIterator.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/StoreVersion.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/DBBackend.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/DBProvider.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/LevelDBIterator.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/RocksDB.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/RocksDBProvider.java
+
+Apache Kyuubi
+./common/src/main/java/org/apache/celeborn/reflect/DynClasses.java
+./common/src/main/java/org/apache/celeborn/reflect/DynConstructors.java
+./common/src/main/java/org/apache/celeborn/reflect/DynFields.java
+./common/src/main/java/org/apache/celeborn/reflect/DynMethods.java
+./dev/checkout_pr.sh
Review Comment:
@justinmclean thanks for your clarification.
In the past, when borrowing code from external projects(non-ASF projects) to an ASF project, I would carefully evaluate the LICENSE and list the copied files under LICENSE and NOTICE. In the future, I will follow your guidance to list files copied from ASF projects too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1202] LICENSE mentions third-party components under other open source licenses [incubator-celeborn]
Posted by "CalvinKirs (via GitHub)" <gi...@apache.org>.
CalvinKirs commented on code in PR #2193:
URL: https://github.com/apache/incubator-celeborn/pull/2193#discussion_r1438054672
##########
LICENSE:
##########
@@ -210,4 +210,38 @@ for text of these licenses.
Apache License 2.0
--------------------------------------
-common/src/main/java/org/apache/celeborn/common/network/util/LimitedInputStream.java
+Apache Spark
+./client-spark/spark-2/src/main/java/org/apache/spark/shuffle/celeborn/SparkUtils.java
+./client-spark/spark-3/src/main/java/org/apache/spark/shuffle/celeborn/SparkUtils.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/DB.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/DBIterator.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/LevelDB.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/LevelDBProvider.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/RocksDBIterator.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/StoreVersion.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/DBBackend.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/DBProvider.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/LevelDBIterator.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/RocksDB.java
+./worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/RocksDBProvider.java
+
+Apache Kyuubi
+./common/src/main/java/org/apache/celeborn/reflect/DynClasses.java
+./common/src/main/java/org/apache/celeborn/reflect/DynConstructors.java
+./common/src/main/java/org/apache/celeborn/reflect/DynFields.java
+./common/src/main/java/org/apache/celeborn/reflect/DynMethods.java
+./dev/checkout_pr.sh
Review Comment:
Apache products are composed of lots of pieces of code across numerous source files, licensed to the ASF by various authors who maintain ownership of their contributions.
In short, I contributed a piece of code to Skywalking, but I still own the code, so I can feel free to contribute the code to other projects, even if its license is incompatible with AL2. Because the ownership is mine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1202] LICENSE mentions third-party components under other open source licenses [incubator-celeborn]
Posted by "justinmclean (via GitHub)" <gi...@apache.org>.
justinmclean commented on PR #2193:
URL: https://github.com/apache/incubator-celeborn/pull/2193#issuecomment-1871105148
If code has been copied from a 3rd party, then that needs to be listed in LICENSE. As that project is Apache licensed and it has a NOTICE file then NOTICE also needs to be modified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org