You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2019/11/21 22:55:21 UTC

[kudu-CR] [java] Fix kudu-client checkstyle warnings 

Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14775


Change subject: [java] Fix kudu-client checkstyle warnings
......................................................................

[java] Fix kudu-client checkstyle warnings

This patch fixes all of the checkstlyle warnings reported by:
./gradlew :kudu-client:checkstyle

A follow on patch will enforce confoming to checkstyle rules in the
pre-commit build.

Change-Id: I153b7bf11b505871703da729720c988dd7c212f9
---
M java/kudu-client/src/test/java/org/apache/kudu/TestColumnSchema.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITClientStress.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITNonFaultTolerantScanner.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITScannerMultiTablet.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduSession.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthTokenReacquire.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthnTokenReacquireOpen.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthzTokenCache.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestBitSet.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestBloomFilter.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestBytes.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestClientFailoverSupport.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestColumnRangePredicate.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestConnectToCluster.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestConnectionCache.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestErrorCollector.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestFlexiblePartitioning.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestHandleTooBusy.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKeyEncoding.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduPartitioner.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduPredicate.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduSession.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestLeaderFailover.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestMasterFailover.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestMultipleLeaderFailover.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestNegotiation.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestOperation.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartitionPruner.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRemoteTablet.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRequestTracker.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowErrors.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowResult.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRpcTraces.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestScanPredicate.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestScanToken.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestScannerMultiTablet.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurityContextRealUser.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestServerInfo.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSplitKeyRange.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestStatistics.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestStatus.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestTableLocationsCache.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestTimeoutTracker.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestTimeouts.java
M java/kudu-client/src/test/java/org/apache/kudu/util/TestAsyncUtil.java
M java/kudu-client/src/test/java/org/apache/kudu/util/TestByteVec.java
M java/kudu-client/src/test/java/org/apache/kudu/util/TestMurmurHash.java
M java/kudu-client/src/test/java/org/apache/kudu/util/TestNetUtil.java
M java/kudu-client/src/test/java/org/apache/kudu/util/TestStringUtil.java
M java/kudu-client/src/test/java/org/apache/kudu/util/TestTimestampUtil.java
59 files changed, 752 insertions(+), 513 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/75/14775/1
-- 
To view, visit http://gerrit.cloudera.org:8080/14775
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I153b7bf11b505871703da729720c988dd7c212f9
Gerrit-Change-Number: 14775
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>

[kudu-CR] [java] Fix kudu-client checkstyle warnings

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14775 )

Change subject: [java] Fix kudu-client checkstyle warnings
......................................................................


Patch Set 4:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/14775/4/java/kudu-client/src/main/java/org/apache/kudu/client/AuthnTokenReacquirer.java
File java/kudu-client/src/main/java/org/apache/kudu/client/AuthnTokenReacquirer.java:

http://gerrit.cloudera.org:8080/#/c/14775/4/java/kudu-client/src/main/java/org/apache/kudu/client/AuthnTokenReacquirer.java@104
PS4, Line 104:       An utility class providing callbacks for successful completion of authn token re-acqusition.
Not sure what happened here, but this seems like a style mistake?


http://gerrit.cloudera.org:8080/#/c/14775/4/java/kudu-client/src/main/java/org/apache/kudu/client/ExternalConsistencyMode.java
File java/kudu-client/src/main/java/org/apache/kudu/client/ExternalConsistencyMode.java:

http://gerrit.cloudera.org:8080/#/c/14775/4/java/kudu-client/src/main/java/org/apache/kudu/client/ExternalConsistencyMode.java@37
PS4, Line 37:   ExternalConsistencyMode(Common.ExternalConsistencyMode pbVersion) {
Why the increased visibility?


http://gerrit.cloudera.org:8080/#/c/14775/4/java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java
File java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java:

http://gerrit.cloudera.org:8080/#/c/14775/4/java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java@94
PS4, Line 94:   private final SaslClientCallbackHandler saslCallback = new SaslClientCallbackHandler();
Maybe the original intent was for this to be static too? Or is the base implementation (CallbackHandler) stateful?

Anyway stateless is fine too.



-- 
To view, visit http://gerrit.cloudera.org:8080/14775
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I153b7bf11b505871703da729720c988dd7c212f9
Gerrit-Change-Number: 14775
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 27 Nov 2019 19:53:51 +0000
Gerrit-HasComments: Yes

[kudu-CR] [java] Fix kudu-client checkstyle warnings

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14775 )

Change subject: [java] Fix kudu-client checkstyle warnings
......................................................................


Patch Set 3:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/14775/3/java/kudu-client/src/main/java/org/apache/kudu/Type.java
File java/kudu-client/src/main/java/org/apache/kudu/Type.java:

http://gerrit.cloudera.org:8080/#/c/14775/3/java/kudu-client/src/main/java/org/apache/kudu/Type.java@59
PS3, Line 59: Private 
> nit: it's no longer private.  Or it means package private?
Private here is redundant. Enum constructors are private by default.


http://gerrit.cloudera.org:8080/#/c/14775/3/java/kudu-client/src/main/java/org/apache/kudu/client/KeyRange.java
File java/kudu-client/src/main/java/org/apache/kudu/client/KeyRange.java:

http://gerrit.cloudera.org:8080/#/c/14775/3/java/kudu-client/src/main/java/org/apache/kudu/client/KeyRange.java@97
PS3, Line 97:                              "<start>" : Bytes.hex(primaryKeyStart),
> Is this what checkstyle recommends?  For some reason, I found it a bit hard
Operators are supposed to be before the line break.


http://gerrit.cloudera.org:8080/#/c/14775/3/java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java
File java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java:

http://gerrit.cloudera.org:8080/#/c/14775/3/java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java@453
PS3, Line 453:             saslCallback);
> nit: any reason to have this is so out-of-bound compared with other argumen
no, not sure how that happened. I will fix it in a follow up change.



-- 
To view, visit http://gerrit.cloudera.org:8080/14775
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I153b7bf11b505871703da729720c988dd7c212f9
Gerrit-Change-Number: 14775
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 26 Nov 2019 14:04:24 +0000
Gerrit-HasComments: Yes

[kudu-CR] [java] Fix kudu-client checkstyle warnings

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14775 )

Change subject: [java] Fix kudu-client checkstyle warnings
......................................................................


Patch Set 4:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/14775/4/java/kudu-client/src/main/java/org/apache/kudu/client/AuthnTokenReacquirer.java
File java/kudu-client/src/main/java/org/apache/kudu/client/AuthnTokenReacquirer.java:

http://gerrit.cloudera.org:8080/#/c/14775/4/java/kudu-client/src/main/java/org/apache/kudu/client/AuthnTokenReacquirer.java@104
PS4, Line 104:       An utility class providing callbacks for successful completion of authn token re-acqusition.
> Not sure what happened here, but this seems like a style mistake?
This should be a block comment and not a javadoc comment because it's inside the private reacquireAuthnToken method and won't be output in javadoc.


http://gerrit.cloudera.org:8080/#/c/14775/4/java/kudu-client/src/main/java/org/apache/kudu/client/ExternalConsistencyMode.java
File java/kudu-client/src/main/java/org/apache/kudu/client/ExternalConsistencyMode.java:

http://gerrit.cloudera.org:8080/#/c/14775/4/java/kudu-client/src/main/java/org/apache/kudu/client/ExternalConsistencyMode.java@37
PS4, Line 37:   ExternalConsistencyMode(Common.ExternalConsistencyMode pbVersion) {
> Why the increased visibility?
This isn't increased visibility. Enum constructors are private by default. So this was flagged as redundant.


http://gerrit.cloudera.org:8080/#/c/14775/4/java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java
File java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java:

http://gerrit.cloudera.org:8080/#/c/14775/4/java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java@94
PS4, Line 94:   private final SaslClientCallbackHandler saslCallback = new SaslClientCallbackHandler();
> Maybe the original intent was for this to be static too? Or is the base imp
I don't think it's stateful. 

SaslClientCallbackHandler can't be created in a static context because it's an inner class. It could be broken out if we wanted.



-- 
To view, visit http://gerrit.cloudera.org:8080/14775
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I153b7bf11b505871703da729720c988dd7c212f9
Gerrit-Change-Number: 14775
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 27 Nov 2019 21:13:34 +0000
Gerrit-HasComments: Yes

[kudu-CR] [java] Fix kudu-client checkstyle warnings

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/14775

to look at the new patch set (#3).

Change subject: [java] Fix kudu-client checkstyle warnings
......................................................................

[java] Fix kudu-client checkstyle warnings

This patch fixes all of the checkstlyle warnings reported by:
./gradlew :kudu-client:checkstyle

I also included some trivial style changes and suppression annotations.

A follow on patch will enforce confoming to checkstyle rules in the
pre-commit build.

Change-Id: I153b7bf11b505871703da729720c988dd7c212f9
---
M java/config/checkstyle/checkstyle.xml
M java/kudu-client/src/main/java/org/apache/kudu/ColumnSchema.java
M java/kudu-client/src/main/java/org/apache/kudu/Schema.java
M java/kudu-client/src/main/java/org/apache/kudu/Type.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AbstractKuduScannerBuilder.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableRequest.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AuthnTokenReacquirer.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AuthzTokenCache.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Batch.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Bytes.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToCluster.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ExternalConsistencyMode.java
M java/kudu-client/src/main/java/org/apache/kudu/client/GetTableSchemaRequest.java
M java/kudu-client/src/main/java/org/apache/kudu/client/HostAndPort.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KeyEncoder.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KeyRange.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduPartitioner.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduRpc.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanToken.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduScannerIterator.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ListTablesResponse.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ListTabletServersRequest.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ListTabletsRequest.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java
M java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Partition.java
M java/kudu-client/src/main/java/org/apache/kudu/client/PartitionPruner.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ProtobufHelper.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RemoteTablet.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RequestTracker.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ResourceMetrics.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RowResultIterator.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RpcProxy.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RpcTraceFrame.java
M java/kudu-client/src/main/java/org/apache/kudu/client/SecurityContext.java
M java/kudu-client/src/main/java/org/apache/kudu/client/SplitKeyRangeRequest.java
M java/kudu-client/src/main/java/org/apache/kudu/util/BloomFilter.java
M java/kudu-client/src/main/java/org/apache/kudu/util/CharUtil.java
M java/kudu-client/src/main/java/org/apache/kudu/util/DataGenerator.java
M java/kudu-client/src/main/java/org/apache/kudu/util/DecimalUtil.java
M java/kudu-client/src/main/java/org/apache/kudu/util/SchemaGenerator.java
M java/kudu-client/src/main/java/org/apache/kudu/util/Slices.java
M java/kudu-client/src/main/java/org/apache/kudu/util/StringUtil.java
M java/kudu-client/src/test/java/org/apache/kudu/TestColumnSchema.java
M java/kudu-client/src/test/java/org/apache/kudu/TestType.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITClientStress.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITNonFaultTolerantScanner.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITScannerMultiTablet.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduSession.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthTokenReacquire.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthnTokenReacquireOpen.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthzTokenCache.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestBitSet.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestBloomFilter.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestBytes.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestClientFailoverSupport.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestColumnRangePredicate.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestConnectToCluster.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestConnectionCache.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestErrorCollector.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestFlexiblePartitioning.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestHandleTooBusy.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKeyEncoding.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduPartitioner.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduPredicate.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduSession.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestLeaderFailover.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestMasterFailover.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestMultipleLeaderFailover.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestNegotiation.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestNegotiator.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestOperation.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartitionPruner.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRemoteTablet.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRequestTracker.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowErrors.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowResult.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRpcTraces.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestScanPredicate.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestScanToken.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestScannerMultiTablet.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurityContextRealUser.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestServerInfo.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSplitKeyRange.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestStatistics.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestStatus.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestTableLocationsCache.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestTimeoutTracker.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestTimeouts.java
M java/kudu-client/src/test/java/org/apache/kudu/util/TestAsyncUtil.java
M java/kudu-client/src/test/java/org/apache/kudu/util/TestByteVec.java
M java/kudu-client/src/test/java/org/apache/kudu/util/TestMurmurHash.java
M java/kudu-client/src/test/java/org/apache/kudu/util/TestNetUtil.java
M java/kudu-client/src/test/java/org/apache/kudu/util/TestStringUtil.java
M java/kudu-client/src/test/java/org/apache/kudu/util/TestTimestampUtil.java
112 files changed, 1,204 insertions(+), 866 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/75/14775/3
-- 
To view, visit http://gerrit.cloudera.org:8080/14775
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I153b7bf11b505871703da729720c988dd7c212f9
Gerrit-Change-Number: 14775
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [java] Fix kudu-client checkstyle warnings

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14775 )

Change subject: [java] Fix kudu-client checkstyle warnings
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/14775/2/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java:

http://gerrit.cloudera.org:8080/#/c/14775/2/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java@447
PS2, Line 447: getFakeMasterUuid(hostPort),
A bit of bike-shedding: if checkstyle so picky, then, maybe, more consistent approach to list arguments would be

return newRpcProxy(
    new ServerInfo(
        getFakeMasterUuid(hostPort),
        hostPort,
        ...),
    credentialsPolicy);

?



-- 
To view, visit http://gerrit.cloudera.org:8080/14775
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I153b7bf11b505871703da729720c988dd7c212f9
Gerrit-Change-Number: 14775
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 21 Nov 2019 23:24:46 +0000
Gerrit-HasComments: Yes

[kudu-CR] [java] Fix kudu-client checkstyle warnings

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14775 )

Change subject: [java] Fix kudu-client checkstyle warnings
......................................................................


Patch Set 3: Code-Review+2

(3 comments)

http://gerrit.cloudera.org:8080/#/c/14775/3/java/kudu-client/src/main/java/org/apache/kudu/Type.java
File java/kudu-client/src/main/java/org/apache/kudu/Type.java:

http://gerrit.cloudera.org:8080/#/c/14775/3/java/kudu-client/src/main/java/org/apache/kudu/Type.java@59
PS3, Line 59: Private 
nit: it's no longer private.  Or it means package private?

Also, is it necessary to add an empty line between the short description and the list of parameters?


http://gerrit.cloudera.org:8080/#/c/14775/3/java/kudu-client/src/main/java/org/apache/kudu/client/KeyRange.java
File java/kudu-client/src/main/java/org/apache/kudu/client/KeyRange.java:

http://gerrit.cloudera.org:8080/#/c/14775/3/java/kudu-client/src/main/java/org/apache/kudu/client/KeyRange.java@97
PS3, Line 97:                              "<start>" : Bytes.hex(primaryKeyStart),
Is this what checkstyle recommends?  For some reason, I found it a bit harder to read than the original variant.

I don't have a strong opinion on this, but I'm just curious on the style preferred by the checkstyle plugin.


http://gerrit.cloudera.org:8080/#/c/14775/3/java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java
File java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java:

http://gerrit.cloudera.org:8080/#/c/14775/3/java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java@453
PS3, Line 453:             saslCallback);
nit: any reason to have this is so out-of-bound compared with other arguments?



-- 
To view, visit http://gerrit.cloudera.org:8080/14775
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I153b7bf11b505871703da729720c988dd7c212f9
Gerrit-Change-Number: 14775
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 25 Nov 2019 20:11:10 +0000
Gerrit-HasComments: Yes

[kudu-CR] [java] Fix kudu-client checkstyle warnings

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14775 )

Change subject: [java] Fix kudu-client checkstyle warnings
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/14775/4/java/kudu-client/src/main/java/org/apache/kudu/client/AuthnTokenReacquirer.java
File java/kudu-client/src/main/java/org/apache/kudu/client/AuthnTokenReacquirer.java:

http://gerrit.cloudera.org:8080/#/c/14775/4/java/kudu-client/src/main/java/org/apache/kudu/client/AuthnTokenReacquirer.java@104
PS4, Line 104:       An utility class providing callbacks for successful completion of authn token re-acqusition.
> This should be a block comment and not a javadoc comment because it's insid
But aren't multiline block comments formatted like this?

  /*
   * line 1
   * <line 2..N, if they exist, look like line 1>
   */

Here I see:
  /*
     line 1
   */



-- 
To view, visit http://gerrit.cloudera.org:8080/14775
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I153b7bf11b505871703da729720c988dd7c212f9
Gerrit-Change-Number: 14775
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 27 Nov 2019 23:09:06 +0000
Gerrit-HasComments: Yes

[kudu-CR] [java] Fix kudu-client checkstyle warnings

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14775 )

Change subject: [java] Fix kudu-client checkstyle warnings
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/14775/2/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java:

http://gerrit.cloudera.org:8080/#/c/14775/2/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java@a437
PS2, Line 437: 
             : 
             : 
             : 
> So checkstyle doesn't like this particular alignment? Is that something we 
I accidentally used the IDE auto-format on this file and the PartialRow.java file. Checkstyle isn't that picky. I went back and manually fixed all the reported issues instead. 

Note: We can configure Checkstyle for basically any rule we would like.


http://gerrit.cloudera.org:8080/#/c/14775/2/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java@447
PS2, Line 447: getFakeMasterUuid(hostPort),
> A bit of bike-shedding: if checkstyle so picky, then, maybe, more consisten
See my other response.



-- 
To view, visit http://gerrit.cloudera.org:8080/14775
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I153b7bf11b505871703da729720c988dd7c212f9
Gerrit-Change-Number: 14775
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 25 Nov 2019 15:51:52 +0000
Gerrit-HasComments: Yes

[kudu-CR] [java] Fix kudu-client checkstyle warnings

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14775 )

Change subject: [java] Fix kudu-client checkstyle warnings
......................................................................

[java] Fix kudu-client checkstyle warnings

This patch fixes all of the checkstlyle warnings reported by:
./gradlew :kudu-client:checkstyle

I also included some trivial style changes and suppression annotations.

A follow on patch will enforce confoming to checkstyle rules in the
pre-commit build.

Change-Id: I153b7bf11b505871703da729720c988dd7c212f9
Reviewed-on: http://gerrit.cloudera.org:8080/14775
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M java/config/checkstyle/checkstyle.xml
M java/kudu-client/src/main/java/org/apache/kudu/ColumnSchema.java
M java/kudu-client/src/main/java/org/apache/kudu/Schema.java
M java/kudu-client/src/main/java/org/apache/kudu/Type.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AbstractKuduScannerBuilder.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableRequest.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AuthnTokenReacquirer.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AuthzTokenCache.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Batch.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Bytes.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToCluster.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ExternalConsistencyMode.java
M java/kudu-client/src/main/java/org/apache/kudu/client/GetTableSchemaRequest.java
M java/kudu-client/src/main/java/org/apache/kudu/client/HostAndPort.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KeyEncoder.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KeyRange.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduPartitioner.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduRpc.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanToken.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduScannerIterator.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ListTablesResponse.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ListTabletServersRequest.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ListTabletsRequest.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java
M java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Partition.java
M java/kudu-client/src/main/java/org/apache/kudu/client/PartitionPruner.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ProtobufHelper.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RemoteTablet.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RequestTracker.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ResourceMetrics.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RowResultIterator.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RpcProxy.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RpcTraceFrame.java
M java/kudu-client/src/main/java/org/apache/kudu/client/SecurityContext.java
M java/kudu-client/src/main/java/org/apache/kudu/client/SplitKeyRangeRequest.java
M java/kudu-client/src/main/java/org/apache/kudu/util/BloomFilter.java
M java/kudu-client/src/main/java/org/apache/kudu/util/CharUtil.java
M java/kudu-client/src/main/java/org/apache/kudu/util/DataGenerator.java
M java/kudu-client/src/main/java/org/apache/kudu/util/DecimalUtil.java
M java/kudu-client/src/main/java/org/apache/kudu/util/SchemaGenerator.java
M java/kudu-client/src/main/java/org/apache/kudu/util/Slices.java
M java/kudu-client/src/main/java/org/apache/kudu/util/StringUtil.java
M java/kudu-client/src/test/java/org/apache/kudu/TestColumnSchema.java
M java/kudu-client/src/test/java/org/apache/kudu/TestType.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITClientStress.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITNonFaultTolerantScanner.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITScannerMultiTablet.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduSession.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthTokenReacquire.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthnTokenReacquireOpen.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthzTokenCache.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestBitSet.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestBloomFilter.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestBytes.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestClientFailoverSupport.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestColumnRangePredicate.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestConnectToCluster.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestConnectionCache.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestErrorCollector.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestFlexiblePartitioning.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestHandleTooBusy.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKeyEncoding.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduPartitioner.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduPredicate.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduSession.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestLeaderFailover.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestMasterFailover.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestMultipleLeaderFailover.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestNegotiation.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestNegotiator.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestOperation.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartitionPruner.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRemoteTablet.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRequestTracker.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowErrors.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowResult.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRpcTraces.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestScanPredicate.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestScanToken.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestScannerMultiTablet.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurityContextRealUser.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestServerInfo.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSplitKeyRange.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestStatistics.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestStatus.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestTableLocationsCache.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestTimeoutTracker.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestTimeouts.java
M java/kudu-client/src/test/java/org/apache/kudu/util/TestAsyncUtil.java
M java/kudu-client/src/test/java/org/apache/kudu/util/TestByteVec.java
M java/kudu-client/src/test/java/org/apache/kudu/util/TestMurmurHash.java
M java/kudu-client/src/test/java/org/apache/kudu/util/TestNetUtil.java
M java/kudu-client/src/test/java/org/apache/kudu/util/TestStringUtil.java
M java/kudu-client/src/test/java/org/apache/kudu/util/TestTimestampUtil.java
112 files changed, 1,204 insertions(+), 866 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Alexey Serbin: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/14775
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I153b7bf11b505871703da729720c988dd7c212f9
Gerrit-Change-Number: 14775
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [java] Fix kudu-client checkstyle warnings

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/14775

to look at the new patch set (#2).

Change subject: [java] Fix kudu-client checkstyle warnings
......................................................................

[java] Fix kudu-client checkstyle warnings

This patch fixes all of the checkstlyle warnings reported by:
./gradlew :kudu-client:checkstyle

A follow on patch will enforce confoming to checkstyle rules in the
pre-commit build.

Change-Id: I153b7bf11b505871703da729720c988dd7c212f9
---
M java/config/checkstyle/checkstyle.xml
M java/kudu-client/src/main/java/org/apache/kudu/ColumnSchema.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AuthzTokenCache.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Bytes.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToCluster.java
M java/kudu-client/src/main/java/org/apache/kudu/client/HostAndPort.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KeyRange.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduPartitioner.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduRpc.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanToken.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduScannerIterator.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ListTablesResponse.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java
M java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ProtobufHelper.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RequestTracker.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RowResultIterator.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RpcProxy.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RpcTraceFrame.java
M java/kudu-client/src/main/java/org/apache/kudu/client/SecurityContext.java
M java/kudu-client/src/main/java/org/apache/kudu/util/BloomFilter.java
M java/kudu-client/src/main/java/org/apache/kudu/util/CharUtil.java
M java/kudu-client/src/main/java/org/apache/kudu/util/DataGenerator.java
M java/kudu-client/src/main/java/org/apache/kudu/util/DecimalUtil.java
M java/kudu-client/src/main/java/org/apache/kudu/util/SchemaGenerator.java
M java/kudu-client/src/main/java/org/apache/kudu/util/Slices.java
M java/kudu-client/src/main/java/org/apache/kudu/util/StringUtil.java
M java/kudu-client/src/test/java/org/apache/kudu/TestColumnSchema.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITClientStress.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITNonFaultTolerantScanner.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITScannerMultiTablet.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduSession.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthTokenReacquire.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthnTokenReacquireOpen.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthzTokenCache.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestBitSet.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestBloomFilter.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestBytes.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestClientFailoverSupport.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestColumnRangePredicate.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestConnectToCluster.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestConnectionCache.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestErrorCollector.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestFlexiblePartitioning.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestHandleTooBusy.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKeyEncoding.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduPartitioner.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduPredicate.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduSession.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestLeaderFailover.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestMasterFailover.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestMultipleLeaderFailover.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestNegotiation.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestOperation.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartitionPruner.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRemoteTablet.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRequestTracker.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowErrors.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowResult.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRpcTraces.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestScanPredicate.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestScanToken.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestScannerMultiTablet.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurityContextRealUser.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestServerInfo.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSplitKeyRange.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestStatistics.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestStatus.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestTableLocationsCache.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestTimeoutTracker.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestTimeouts.java
M java/kudu-client/src/test/java/org/apache/kudu/util/TestAsyncUtil.java
M java/kudu-client/src/test/java/org/apache/kudu/util/TestByteVec.java
M java/kudu-client/src/test/java/org/apache/kudu/util/TestMurmurHash.java
M java/kudu-client/src/test/java/org/apache/kudu/util/TestNetUtil.java
M java/kudu-client/src/test/java/org/apache/kudu/util/TestStringUtil.java
M java/kudu-client/src/test/java/org/apache/kudu/util/TestTimestampUtil.java
93 files changed, 1,707 insertions(+), 1,235 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/75/14775/2
-- 
To view, visit http://gerrit.cloudera.org:8080/14775
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I153b7bf11b505871703da729720c988dd7c212f9
Gerrit-Change-Number: 14775
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [java] Fix kudu-client checkstyle warnings

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14775 )

Change subject: [java] Fix kudu-client checkstyle warnings
......................................................................


Patch Set 2:

(1 comment)

Just passing through.

http://gerrit.cloudera.org:8080/#/c/14775/2/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java:

http://gerrit.cloudera.org:8080/#/c/14775/2/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java@a437
PS2, Line 437: 
             : 
             : 
             : 
So checkstyle doesn't like this particular alignment? Is that something we can configure?

I can live with it if not, but it's what we do on the C++ side and it seems reasonable to do use it in Java too.



-- 
To view, visit http://gerrit.cloudera.org:8080/14775
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I153b7bf11b505871703da729720c988dd7c212f9
Gerrit-Change-Number: 14775
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 21 Nov 2019 23:09:52 +0000
Gerrit-HasComments: Yes