You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/12/07 12:43:49 UTC

[GitHub] [spark] StefanXiepj opened a new pull request #30646: SPARK-33686: Spark SQL unrecognized `db.tbl`

StefanXiepj opened a new pull request #30646:
URL: https://github.com/apache/spark/pull/30646


   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
     2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
     4. Be sure to keep the PR description updated to reflect all changes.
     5. Please write your PR title to summarize what this PR proposes.
     6. If possible, provide a concise example to reproduce the issue for a faster review.
     7. If you want to add a new configuration, please read the guideline first for naming configurations in
        'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
   -->
   
   ### What changes were proposed in this pull request?
   <!--
   Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. 
   If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
     1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
     2. If you fix some SQL features, you can provide some references of other DBMSes.
     3. If there is design documentation, please add the link.
     4. If there is a discussion in the mailing list, please add the link.
   -->
   In this PR, if somebody created table like this:
   ```
   create table `bigdata_db.test_spark_33686` (c1 int);
   ```
   it's mean db name is `bigdata_db`, table name is `test_spark_33686`, but current version don't support it and throws exception like:
   ```
   spark-sql> create table `bigdata_db.test_spark_33686` (c1 int);
   Error in query: `bigdata_db.test_spark_33686` is not a valid name for tables/databases. Valid names only contain alphabet characters, numbers and _.;
   ```
   we should support it.
   
   ### Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   This is more relaxed and friendly syntax support.
   
   ### Does this PR introduce _any_ user-facing change?
   <!--
   Note that it means *any* user-facing change including all aspects such as the documentation fix.
   If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
   If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
   If no, write 'No'.
   -->
   No
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   -->
   add new tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] StefanXiepj commented on pull request #30646: SPARK-33686: Spark SQL unrecognized `db.tbl`

Posted by GitBox <gi...@apache.org>.
StefanXiepj commented on pull request #30646:
URL: https://github.com/apache/spark/pull/30646#issuecomment-745392096


   @cloud-fan Could you review this PR , thanks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan commented on pull request #30646: SPARK-33686: Spark SQL unrecognized `db.tbl`

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #30646:
URL: https://github.com/apache/spark/pull/30646#issuecomment-745927454


   `SessionCatalog` is a wrapper of the hive catalog and the name validation is done there. You can try to add this feature there.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] srowen commented on pull request #30646: SPARK-33686: Spark SQL unrecognized `db.tbl`

Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #30646:
URL: https://github.com/apache/spark/pull/30646#issuecomment-739987454


   If you back-tick-quote it, then you are not specifying a DB and table name, right? you're just specifying a table name, and the error is correct. Just don't quote it, right?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] StefanXiepj commented on pull request #30646: SPARK-33686: Spark SQL unrecognized `db.tbl`

Posted by GitBox <gi...@apache.org>.
StefanXiepj commented on pull request #30646:
URL: https://github.com/apache/spark/pull/30646#issuecomment-745899787


   > I don't think spark can support it, as we may have catalog implementations that support table name with dot, and this change will break it.
   
   I am glad to receive your reply.  emm... i have some questions need your help. spark support table name with dot,  Could you give me some examples, it is better for me to understand this question.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan commented on pull request #30646: SPARK-33686: Spark SQL unrecognized `db.tbl`

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #30646:
URL: https://github.com/apache/spark/pull/30646#issuecomment-745782558


   I don't think spark can support it, as we may have catalog implementations that support table name with dot, and this change will break it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #30646: SPARK-33686: Spark SQL unrecognized `db.tbl`

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30646:
URL: https://github.com/apache/spark/pull/30646#issuecomment-739896155


   Can one of the admins verify this patch?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan commented on pull request #30646: SPARK-33686: Spark SQL unrecognized `db.tbl`

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #30646:
URL: https://github.com/apache/spark/pull/30646#issuecomment-745902632


   We have `TableCatalog` now, and the implementation can accept any table name as it wants.
   
   That said, I think it's OK to do it as a Hive-catalog-specific feature, but not at the parser side.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] StefanXiepj commented on pull request #30646: SPARK-33686: Spark SQL unrecognized `db.tbl`

Posted by GitBox <gi...@apache.org>.
StefanXiepj commented on pull request #30646:
URL: https://github.com/apache/spark/pull/30646#issuecomment-740388303


   > If you back-tick-quote it, then you are not specifying a DB and table name, right? you're just specifying a table name, and the error is correct. Just don't quote it, right?
   
   thx for your report. We have a lot of tasks about hive sql, when migrating it to spark sql, we found we can't, but hive support it, if Spark also supports it, it will be easier for users to use Spark. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] srowen closed pull request #30646: SPARK-33686: Spark SQL unrecognized `db.tbl`

Posted by GitBox <gi...@apache.org>.
srowen closed pull request #30646:
URL: https://github.com/apache/spark/pull/30646


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] StefanXiepj closed pull request #30646: SPARK-33686: Spark SQL unrecognized `db.tbl`

Posted by GitBox <gi...@apache.org>.
StefanXiepj closed pull request #30646:
URL: https://github.com/apache/spark/pull/30646


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] StefanXiepj commented on pull request #30646: SPARK-33686: Spark SQL unrecognized `db.tbl`

Posted by GitBox <gi...@apache.org>.
StefanXiepj commented on pull request #30646:
URL: https://github.com/apache/spark/pull/30646#issuecomment-745934597


   > `SessionCatalog` is a wrapper of the hive catalog and the name validation is done there. You can try to add this feature there.
   
   Ok, thanks very much, i will do it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] StefanXiepj commented on pull request #30646: SPARK-33686: Spark SQL unrecognized `db.tbl`

Posted by GitBox <gi...@apache.org>.
StefanXiepj commented on pull request #30646:
URL: https://github.com/apache/spark/pull/30646#issuecomment-745924787


   > We have `TableCatalog` now, and the implementation can accept any table name as it wants.
   > 
   > That said, I think it's OK to do it as a Hive-catalog-specific feature, but not at the parser side.
   
   yeah, this is just for hive catalog, my purpose is to better migrate tasks from hive to spark. I like Spark, but we hive many tasks running on hive, we want to migrate it. I will move it from parser side to hive-catalog, have you got anything special in mind?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] StefanXiepj closed pull request #30646: SPARK-33686: Spark SQL unrecognized `db.tbl`

Posted by GitBox <gi...@apache.org>.
StefanXiepj closed pull request #30646:
URL: https://github.com/apache/spark/pull/30646


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org