You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Chesnay Schepler (Jira)" <ji...@apache.org> on 2020/02/27 14:50:00 UTC

[jira] [Updated] (FLINK-16189) Remove testing logic from FlinkDistribution

     [ https://issues.apache.org/jira/browse/FLINK-16189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chesnay Schepler updated FLINK-16189:
-------------------------------------
    Description: 
Currently, the {{FlinkDistribution}} is responsible for locating and copying the distribution for usage in tests, and contains hooks for backing up log files.
 This makes the class a bit inflexible to use, as for example a {{FlinkResource}} could not create 2 distributions in separate places.

I suggest to move these responsibilities into the {{FlinkResource}} implementations, and "demote" the distribution to a simple wrapper, only providing programmatic access for mutating/interacting with the distribution.

  was:
Currently, the {{FlinkDistribution}} is responsible for locating and copying the distribution for usage in tests.
This makes the class a bit inflexible to use, as for example a {{FlinkResource}} could not create 2 distributions in separate places.

I suggest to move these responsibilities into the {{FlinkResource}} implementations.


> Remove testing logic from FlinkDistribution
> -------------------------------------------
>
>                 Key: FLINK-16189
>                 URL: https://issues.apache.org/jira/browse/FLINK-16189
>             Project: Flink
>          Issue Type: Improvement
>          Components: Test Infrastructure
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>            Priority: Major
>             Fix For: 1.11.0
>
>
> Currently, the {{FlinkDistribution}} is responsible for locating and copying the distribution for usage in tests, and contains hooks for backing up log files.
>  This makes the class a bit inflexible to use, as for example a {{FlinkResource}} could not create 2 distributions in separate places.
> I suggest to move these responsibilities into the {{FlinkResource}} implementations, and "demote" the distribution to a simple wrapper, only providing programmatic access for mutating/interacting with the distribution.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)