You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Julian Gutierrez Oschmann (JIRA)" <ji...@apache.org> on 2011/06/01 05:42:47 UTC

[jira] [Created] (PIG-2103) support for Squid logs parsing/loading (Loader UDF)

support for Squid logs parsing/loading (Loader UDF)
---------------------------------------------------

                 Key: PIG-2103
                 URL: https://issues.apache.org/jira/browse/PIG-2103
             Project: Pig
          Issue Type: New Feature
            Reporter: Julian Gutierrez Oschmann
            Priority: Minor


As proposed in the development list, LoadFunc UDF for parsing/loading of Squid logs (default, common, squidmime and combined log levels)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (PIG-2103) Support for Squid logs parsing/loading (Loader UDF)

Posted by "Julian Gutierrez Oschmann (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Julian Gutierrez Oschmann updated PIG-2103:
-------------------------------------------

    Attachment: squid-fixed.patch

My fault. The import statements were pointing to a wrong package. Fixed in squid-fixed.patch.

> Support for Squid logs parsing/loading (Loader UDF)
> ---------------------------------------------------
>
>                 Key: PIG-2103
>                 URL: https://issues.apache.org/jira/browse/PIG-2103
>             Project: Pig
>          Issue Type: New Feature
>            Reporter: Julian Gutierrez Oschmann
>            Priority: Minor
>         Attachments: squid-fixed.patch, squid.patch
>
>
> As proposed in the development list, LoadFunc UDF for parsing/loading of Squid logs (default, common, squidmime and combined log levels)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (PIG-2103) Support for Squid logs parsing/loading (Loader UDF)

Posted by "Julian Gutierrez Oschmann (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Julian Gutierrez Oschmann updated PIG-2103:
-------------------------------------------

    Status: Open  (was: Patch Available)

Attach upload failed.

> Support for Squid logs parsing/loading (Loader UDF)
> ---------------------------------------------------
>
>                 Key: PIG-2103
>                 URL: https://issues.apache.org/jira/browse/PIG-2103
>             Project: Pig
>          Issue Type: New Feature
>            Reporter: Julian Gutierrez Oschmann
>            Priority: Minor
>
> As proposed in the development list, LoadFunc UDF for parsing/loading of Squid logs (default, common, squidmime and combined log levels)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (PIG-2103) Support for Squid logs parsing/loading (Loader UDF)

Posted by "Julian Gutierrez Oschmann (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Julian Gutierrez Oschmann updated PIG-2103:
-------------------------------------------

    Status: Patch Available  (was: Open)

> Support for Squid logs parsing/loading (Loader UDF)
> ---------------------------------------------------
>
>                 Key: PIG-2103
>                 URL: https://issues.apache.org/jira/browse/PIG-2103
>             Project: Pig
>          Issue Type: New Feature
>            Reporter: Julian Gutierrez Oschmann
>            Priority: Minor
>         Attachments: squid.patch
>
>
> As proposed in the development list, LoadFunc UDF for parsing/loading of Squid logs (default, common, squidmime and combined log levels)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (PIG-2103) Support for Squid logs parsing/loading (Loader UDF)

Posted by "Julian Gutierrez Oschmann (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Julian Gutierrez Oschmann updated PIG-2103:
-------------------------------------------

    Status: Patch Available  (was: Open)

> Support for Squid logs parsing/loading (Loader UDF)
> ---------------------------------------------------
>
>                 Key: PIG-2103
>                 URL: https://issues.apache.org/jira/browse/PIG-2103
>             Project: Pig
>          Issue Type: New Feature
>            Reporter: Julian Gutierrez Oschmann
>            Priority: Minor
>
> As proposed in the development list, LoadFunc UDF for parsing/loading of Squid logs (default, common, squidmime and combined log levels)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (PIG-2103) Support for Squid logs parsing/loading (Loader UDF)

Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashutosh Chauhan updated PIG-2103:
----------------------------------

    Status: Open  (was: Patch Available)

Newly added test case failed with following log:

Testsuite: org.apache.pig.piggybank.test.storage.squid.BaseSquidLogTest
Tests run: 1, Failures: 1, Errors: 0, Time elapsed: 0.041 sec

Testcase: warning took 0.007 sec
        FAILED
Class org.apache.pig.piggybank.test.storage.squid.BaseSquidLogTest has no public constructor TestCase(String name) or TestCase()
junit.framework.AssertionFailedError: Class org.apache.pig.piggybank.test.storage.squid.BaseSquidLogTest has no public constructor TestCase(String name) or TestCase()



> Support for Squid logs parsing/loading (Loader UDF)
> ---------------------------------------------------
>
>                 Key: PIG-2103
>                 URL: https://issues.apache.org/jira/browse/PIG-2103
>             Project: Pig
>          Issue Type: New Feature
>            Reporter: Julian Gutierrez Oschmann
>            Priority: Minor
>         Attachments: squid-fixed.patch, squid.patch
>
>
> As proposed in the development list, LoadFunc UDF for parsing/loading of Squid logs (default, common, squidmime and combined log levels)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (PIG-2103) Support for Squid logs parsing/loading (Loader UDF)

Posted by "Julian Gutierrez Oschmann (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Julian Gutierrez Oschmann updated PIG-2103:
-------------------------------------------

    Summary: Support for Squid logs parsing/loading (Loader UDF)  (was: support for Squid logs parsing/loading (Loader UDF))

> Support for Squid logs parsing/loading (Loader UDF)
> ---------------------------------------------------
>
>                 Key: PIG-2103
>                 URL: https://issues.apache.org/jira/browse/PIG-2103
>             Project: Pig
>          Issue Type: New Feature
>            Reporter: Julian Gutierrez Oschmann
>            Priority: Minor
>
> As proposed in the development list, LoadFunc UDF for parsing/loading of Squid logs (default, common, squidmime and combined log levels)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (PIG-2103) Support for Squid logs parsing/loading (Loader UDF)

Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042775#comment-13042775 ] 

Ashutosh Chauhan commented on PIG-2103:
---------------------------------------

Ur patch import classes from package com.globant.hadoop.udf.pig.net.* Did you forget to add those files in the patch?

> Support for Squid logs parsing/loading (Loader UDF)
> ---------------------------------------------------
>
>                 Key: PIG-2103
>                 URL: https://issues.apache.org/jira/browse/PIG-2103
>             Project: Pig
>          Issue Type: New Feature
>            Reporter: Julian Gutierrez Oschmann
>            Priority: Minor
>         Attachments: squid.patch
>
>
> As proposed in the development list, LoadFunc UDF for parsing/loading of Squid logs (default, common, squidmime and combined log levels)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (PIG-2103) Support for Squid logs parsing/loading (Loader UDF)

Posted by "Julian Gutierrez Oschmann (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Julian Gutierrez Oschmann updated PIG-2103:
-------------------------------------------

    Attachment: squid.patch

Patch file.

> Support for Squid logs parsing/loading (Loader UDF)
> ---------------------------------------------------
>
>                 Key: PIG-2103
>                 URL: https://issues.apache.org/jira/browse/PIG-2103
>             Project: Pig
>          Issue Type: New Feature
>            Reporter: Julian Gutierrez Oschmann
>            Priority: Minor
>         Attachments: squid.patch
>
>
> As proposed in the development list, LoadFunc UDF for parsing/loading of Squid logs (default, common, squidmime and combined log levels)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (PIG-2103) Support for Squid logs parsing/loading (Loader UDF)

Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13064957#comment-13064957 ] 

Ashutosh Chauhan commented on PIG-2103:
---------------------------------------

I realized there already is RegExLoader in piggybank which can be used as I suggested in previous comment. So, these loaders are really syntactic sugar. Adding them in will help users to avoid struggling to do the right escaping.

+1

> Support for Squid logs parsing/loading (Loader UDF)
> ---------------------------------------------------
>
>                 Key: PIG-2103
>                 URL: https://issues.apache.org/jira/browse/PIG-2103
>             Project: Pig
>          Issue Type: New Feature
>            Reporter: Julian Gutierrez Oschmann
>            Priority: Minor
>         Attachments: squid-fixed.patch, squid.patch
>
>
> As proposed in the development list, LoadFunc UDF for parsing/loading of Squid logs (default, common, squidmime and combined log levels)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (PIG-2103) Support for Squid logs parsing/loading (Loader UDF)

Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13041976#comment-13041976 ] 

Ashutosh Chauhan commented on PIG-2103:
---------------------------------------

Did you accidentally forgot to attach the patch or did you accidentally changed the status to Patch Available?

> Support for Squid logs parsing/loading (Loader UDF)
> ---------------------------------------------------
>
>                 Key: PIG-2103
>                 URL: https://issues.apache.org/jira/browse/PIG-2103
>             Project: Pig
>          Issue Type: New Feature
>            Reporter: Julian Gutierrez Oschmann
>            Priority: Minor
>
> As proposed in the development list, LoadFunc UDF for parsing/loading of Squid logs (default, common, squidmime and combined log levels)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (PIG-2103) Support for Squid logs parsing/loading (Loader UDF)

Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042892#comment-13042892 ] 

Ashutosh Chauhan commented on PIG-2103:
---------------------------------------

Although this approach also work, I wonder if it would have been better that we make RegExLoader take in a regex as a ctor argument and use it to compile pattern. That way Regex loader can work with any regular expression and then there wouldn't be a need for a different loader for every regex. In this patch, you already have three different loaders which just differ on the regular expression they are working on.

> Support for Squid logs parsing/loading (Loader UDF)
> ---------------------------------------------------
>
>                 Key: PIG-2103
>                 URL: https://issues.apache.org/jira/browse/PIG-2103
>             Project: Pig
>          Issue Type: New Feature
>            Reporter: Julian Gutierrez Oschmann
>            Priority: Minor
>         Attachments: squid-fixed.patch, squid.patch
>
>
> As proposed in the development list, LoadFunc UDF for parsing/loading of Squid logs (default, common, squidmime and combined log levels)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira