You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by "MartijnVisser (via GitHub)" <gi...@apache.org> on 2023/04/03 07:59:11 UTC

[GitHub] [flink] MartijnVisser commented on a diff in pull request #22202: [FLINK-29177][hive] Shade org.apache.commons.lang3 in flink-sql-connector-hive to avoid potential class conflict

MartijnVisser commented on code in PR #22202:
URL: https://github.com/apache/flink/pull/22202#discussion_r1155609325


##########
flink-connectors/flink-sql-connector-hive-2.3.9/pom.xml:
##########
@@ -115,6 +115,10 @@ under the License.
 									<pattern>com.google</pattern>
 									<shadedPattern>org.apache.flink.hive.shaded.com.google</shadedPattern>
 								</relocation>
+								<relocation>

Review Comment:
   Keep in mind that Jackson is already in `flink-shaded`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org