You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Abhay Kulkarni <ak...@hortonworks.com> on 2021/05/12 00:56:36 UTC

Review Request 73350: RANGER-3284: Simplify processing of tasks scheduled to execute after current transaction is completed

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73350/
-----------------------------------------------------------

Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Madhan Neethiraj, Mehul Parikh, and Velmurugan Periasamy.


Bugs: RANGER-3284
    https://issues.apache.org/jira/browse/RANGER-3284


Repository: ranger


Description
-------

Some tasks, such as updating policy/tag versions of a service after a policy/tag is updated, are scheduled to run after the transaction changing policy/tag is completed. The scheduling and execution of such tasks is complicated and can be simplified by directly queueing the task to be executed on Transaction commit/completion.


Diffs
-----

  security-admin/src/main/java/org/apache/ranger/biz/PolicyRefUpdater.java 115e55629 
  security-admin/src/main/java/org/apache/ranger/biz/RoleRefUpdater.java 10a762576 
  security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java dd58e0587 


Diff: https://reviews.apache.org/r/73350/diff/1/


Testing
-------

Passed all unit tests.
Ensured that when a resource service is created, a tag service, if not already present, is created and linked with the resource-service by the task scheduled to run after the transaction that created resource service is committed.


Thanks,

Abhay Kulkarni


Re: Review Request 73350: RANGER-3284: Simplify processing of tasks scheduled to execute after current transaction is completed

Posted by Sailaja Polavarapu <sp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73350/#review222989
-----------------------------------------------------------


Ship it!




Ship It!

- Sailaja Polavarapu


On May 12, 2021, 12:56 a.m., Abhay Kulkarni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73350/
> -----------------------------------------------------------
> 
> (Updated May 12, 2021, 12:56 a.m.)
> 
> 
> Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Madhan Neethiraj, Mehul Parikh, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3284
>     https://issues.apache.org/jira/browse/RANGER-3284
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Some tasks, such as updating policy/tag versions of a service after a policy/tag is updated, are scheduled to run after the transaction changing policy/tag is completed. The scheduling and execution of such tasks is complicated and can be simplified by directly queueing the task to be executed on Transaction commit/completion.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/biz/PolicyRefUpdater.java 115e55629 
>   security-admin/src/main/java/org/apache/ranger/biz/RoleRefUpdater.java 10a762576 
>   security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java dd58e0587 
> 
> 
> Diff: https://reviews.apache.org/r/73350/diff/1/
> 
> 
> Testing
> -------
> 
> Passed all unit tests.
> Ensured that when a resource service is created, a tag service, if not already present, is created and linked with the resource-service by the task scheduled to run after the transaction that created resource service is committed.
> 
> 
> Thanks,
> 
> Abhay Kulkarni
> 
>


Re: Review Request 73350: RANGER-3284: Simplify processing of tasks scheduled to execute after current transaction is completed

Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73350/#review222990
-----------------------------------------------------------


Ship it!




Ship It!

- Ramesh Mani


On May 12, 2021, 12:56 a.m., Abhay Kulkarni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73350/
> -----------------------------------------------------------
> 
> (Updated May 12, 2021, 12:56 a.m.)
> 
> 
> Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Madhan Neethiraj, Mehul Parikh, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3284
>     https://issues.apache.org/jira/browse/RANGER-3284
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Some tasks, such as updating policy/tag versions of a service after a policy/tag is updated, are scheduled to run after the transaction changing policy/tag is completed. The scheduling and execution of such tasks is complicated and can be simplified by directly queueing the task to be executed on Transaction commit/completion.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/biz/PolicyRefUpdater.java 115e55629 
>   security-admin/src/main/java/org/apache/ranger/biz/RoleRefUpdater.java 10a762576 
>   security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java dd58e0587 
> 
> 
> Diff: https://reviews.apache.org/r/73350/diff/1/
> 
> 
> Testing
> -------
> 
> Passed all unit tests.
> Ensured that when a resource service is created, a tag service, if not already present, is created and linked with the resource-service by the task scheduled to run after the transaction that created resource service is committed.
> 
> 
> Thanks,
> 
> Abhay Kulkarni
> 
>