You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Brenden Matthews <br...@diddyinc.com> on 2013/04/17 00:06:41 UTC
Review Request: Build fix for GCC 4.7.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10561/
-----------------------------------------------------------
Review request for mesos.
Description
-------
Build fix for GCC 4.7.
Diffs
-----
third_party/libprocess/third_party/stout/include/stout/multimap.hpp 8f0f803
Diff: https://reviews.apache.org/r/10561/diff/
Testing
-------
Used in production at Airbnb.
Thanks,
Brenden Matthews
Re: Review Request: Build fix for GCC 4.7.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10561/#review19334
-----------------------------------------------------------
third_party/libprocess/third_party/stout/include/stout/multimap.hpp
<https://reviews.apache.org/r/10561/#comment40012>
For consistency, can you s/this->/std::multimap<K, V>::/ as done elsewhere?
Otherwise, if you prefer to change the other spots to use 'this->' that's fine as well.
- Ben Mahler
On April 16, 2013, 10:06 p.m., Brenden Matthews wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10561/
> -----------------------------------------------------------
>
> (Updated April 16, 2013, 10:06 p.m.)
>
>
> Review request for mesos.
>
>
> Description
> -------
>
> Build fix for GCC 4.7.
>
>
> Diffs
> -----
>
> third_party/libprocess/third_party/stout/include/stout/multimap.hpp 8f0f803
>
> Diff: https://reviews.apache.org/r/10561/diff/
>
>
> Testing
> -------
>
> Used in production at Airbnb.
>
>
> Thanks,
>
> Brenden Matthews
>
>
Re: Review Request: Build fix for GCC 4.7.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10561/#review19477
-----------------------------------------------------------
Thanks Brenden, this is now committed, can you mark this as submitted?
- Ben Mahler
On April 18, 2013, 12:36 a.m., Brenden Matthews wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10561/
> -----------------------------------------------------------
>
> (Updated April 18, 2013, 12:36 a.m.)
>
>
> Review request for mesos.
>
>
> Description
> -------
>
> Build fix for GCC 4.7.
>
>
> Diffs
> -----
>
> third_party/libprocess/third_party/stout/include/stout/multimap.hpp 8f0f803
>
> Diff: https://reviews.apache.org/r/10561/diff/
>
>
> Testing
> -------
>
> Used in production at Airbnb.
>
>
> Thanks,
>
> Brenden Matthews
>
>
Re: Review Request: Build fix for GCC 4.7.
Posted by Brenden Matthews <br...@diddyinc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10561/
-----------------------------------------------------------
(Updated April 18, 2013, 12:36 a.m.)
Review request for mesos.
Description
-------
Build fix for GCC 4.7.
Diffs (updated)
-----
third_party/libprocess/third_party/stout/include/stout/multimap.hpp 8f0f803
Diff: https://reviews.apache.org/r/10561/diff/
Testing
-------
Used in production at Airbnb.
Thanks,
Brenden Matthews