You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "JooHyukKim (via GitHub)" <gi...@apache.org> on 2023/05/12 00:12:06 UTC
[GitHub] [pulsar] JooHyukKim opened a new pull request, #20310: [fix][broker] Fix class name typo `PrecisPublishLimiter` to "Precise"
JooHyukKim opened a new pull request, #20310:
URL: https://github.com/apache/pulsar/pull/20310
### Motivation
To fix a typo on a class name. Class name is not a good place for a typo.
### Modifications
- Changed class name from `PrecisPublishLimiter` to `PrecisePublishLimiter`, ending with "e"
- Renamed relevent local declarations like wise, from `precisPublishLimiter` to `precisePublishLimiter`
### Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
### Does this pull request potentially affect one of the following parts:
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
*If the box was checked, please highlight the changes*
- [ ] Dependencies (add or upgrade a dependency)
- [ ] The public API
- [ ] The schema
- [ ] The default values of configurations
- [ ] The threading model
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
- [ ] The metrics
- [ ] Anything that affects deployment
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
### Matching PR in forked repository
PR in forked repository: https://github.com/JooHyukKim/pulsar/pull/3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] dave2wave commented on pull request #20310: [fix][broker] Fix class name typo `PrecisPublishLimiter` to "Precise"
Posted by "dave2wave (via GitHub)" <gi...@apache.org>.
dave2wave commented on PR #20310:
URL: https://github.com/apache/pulsar/pull/20310#issuecomment-1545919211
This bothered me too. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- merged pull request #20310: [fix][broker] Fix class name typo `PrecisPublishLimiter` to "Precise"
Posted by "Technoboy- (via GitHub)" <gi...@apache.org>.
Technoboy- merged PR #20310:
URL: https://github.com/apache/pulsar/pull/20310
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org