[GitHub] [spark] squito commented on issue #24565: [SPARK-27665][Core] Split fetch shuffle blocks protocol from OpenBlocks

[GitBox <gi...@apache.org>]

squito commented on issue #24565: [SPARK-27665][Core] Split fetch shuffle blocks protocol from OpenBlocks
URL: https://github.com/apache/spark/pull/24565#issuecomment-493496466
 
 
   This change makes sense, but one thing which has been in the back of my mind for a while -- I really think we should add versioning to the external shuffle service.  Its very hard to users to always upgrade the external shuffle service at the same time.  Without versioning and _some_ migration period, eg. so a 3.0 spark app can talk to a 2.4 spark shuffle service, it makes upgrades really difficult.
   
   if we do that, you'd want to send the new messages only if you're talking to a new shuffle service. and maybe in 3.1 we'd remove the old code completely.
   
   I realize this is an extra headache but I'd like us to consider it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org