You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/11/26 13:38:59 UTC
[GitHub] [incubator-yunikorn-core] manirajv06 opened a new pull request #223: YUNIKORN-415: Add "queues" REST API to fetch list of queues
manirajv06 opened a new pull request #223:
URL: https://github.com/apache/incubator-yunikorn-core/pull/223
First cut implementation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] codecov[bot] edited a comment on pull request #223: YUNIKORN-415: Add "queues" REST API to fetch list of queues
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #223:
URL: https://github.com/apache/incubator-yunikorn-core/pull/223#issuecomment-735884155
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223?src=pr&el=h1) Report
> Merging [#223](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223?src=pr&el=desc) (d39ed04) into [master](https://codecov.io/gh/apache/incubator-yunikorn-core/commit/2bf2767642274b47d94c022d4bc4f36f733da617?el=desc) (2bf2767) will **decrease** coverage by `0.33%`.
> The diff coverage is `17.07%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #223 +/- ##
==========================================
- Coverage 63.06% 62.73% -0.34%
==========================================
Files 60 60
Lines 5199 5238 +39
==========================================
+ Hits 3279 3286 +7
- Misses 1759 1787 +28
- Partials 161 165 +4
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/objects/queue.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223/diff?src=pr&el=tree#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL3F1ZXVlLmdv) | `67.01% <0.00%> (-2.44%)` | :arrow_down: |
| [pkg/scheduler/partition.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223/diff?src=pr&el=tree#diff-cGtnL3NjaGVkdWxlci9wYXJ0aXRpb24uZ28=) | `62.37% <0.00%> (-0.42%)` | :arrow_down: |
| [pkg/webservice/handlers.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223/diff?src=pr&el=tree#diff-cGtnL3dlYnNlcnZpY2UvaGFuZGxlcnMuZ28=) | `53.24% <38.88%> (-0.90%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223?src=pr&el=footer). Last update [2bf2767...d39ed04](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] manirajv06 commented on a change in pull request #223: YUNIKORN-415: Add "queues" REST API to fetch list of queues
Posted by GitBox <gi...@apache.org>.
manirajv06 commented on a change in pull request #223:
URL: https://github.com/apache/incubator-yunikorn-core/pull/223#discussion_r532717866
##########
File path: pkg/scheduler/objects/queue.go
##########
@@ -401,6 +401,28 @@ func (sq *Queue) GetQueueInfos() dao.QueueDAOInfo {
return queueInfo
}
+func (sq *Queue) GetPartitionQueues() dao.PartitionQueueDAOInfo {
+ queueInfo := dao.PartitionQueueDAOInfo{}
+ if len(sq.children) > 0 {
+ for _, child := range sq.GetCopyOfChildren() {
+ queueInfo.Children = append(queueInfo.Children, child.GetPartitionQueues())
+ }
+ }
+ queueInfo.QueueName = sq.GetQueuePath()
+ queueInfo.Status = sq.stateMachine.Current()
Review comment:
Added readlock to ensure its safety. Also replaced write lock with read lock in GetQueuePath() which got introduced as part of cache refactoring. Read lock is good enough in this case. Please verify this as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] sunilgovind commented on a change in pull request #223: YUNIKORN-415: Add "queues" REST API to fetch list of queues
Posted by GitBox <gi...@apache.org>.
sunilgovind commented on a change in pull request #223:
URL: https://github.com/apache/incubator-yunikorn-core/pull/223#discussion_r531664917
##########
File path: pkg/scheduler/objects/queue.go
##########
@@ -401,6 +401,28 @@ func (sq *Queue) GetQueueInfos() dao.QueueDAOInfo {
return queueInfo
}
+func (sq *Queue) GetPartitionQueues() dao.PartitionQueueDAOInfo {
+ queueInfo := dao.PartitionQueueDAOInfo{}
+ if len(sq.children) > 0 {
+ for _, child := range sq.GetCopyOfChildren() {
+ queueInfo.Children = append(queueInfo.Children, child.GetPartitionQueues())
+ }
+ }
+ queueInfo.QueueName = sq.GetQueuePath()
+ queueInfo.Status = sq.stateMachine.Current()
Review comment:
Is it safe to get this variable w/o readlock ?
##########
File path: pkg/webservice/handlers.go
##########
@@ -521,3 +522,27 @@ func updateConfiguration(conf string) (string, error) {
}
return "", fmt.Errorf("config plugin not found")
}
+
+func getPartitionQueues(w http.ResponseWriter, r *http.Request) {
+ vars := mux.Vars(r)
+ writeHeaders(w)
+ if len(vars) == 0 {
+ http.Error(w, "Mandatory parameters are missing in URL path. Please check the usage documentation", http.StatusBadRequest)
Review comment:
Do we need to return from here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] kingamarton commented on a change in pull request #223: YUNIKORN-415: Add "queues" REST API to fetch list of queues
Posted by GitBox <gi...@apache.org>.
kingamarton commented on a change in pull request #223:
URL: https://github.com/apache/incubator-yunikorn-core/pull/223#discussion_r563677898
##########
File path: pkg/webservice/routes.go
##########
@@ -127,6 +127,13 @@ var webRoutes = routes{
getContainerHistory,
},
+ route{
+ "Scheduler",
+ "GET",
+ "/ws/v1/partition/{partition}/queues",
+ getPartitionQueues,
Review comment:
Now we have two endpoint for retrieving the queue infos. Shouldn't we delete the old one? Or what is the plan, how will the transition to the new API will be done?
##########
File path: pkg/webservice/handlers.go
##########
@@ -521,3 +523,24 @@ func updateConfiguration(conf string) (string, error) {
}
return "", fmt.Errorf("config plugin not found")
}
+
+func getPartitionQueues(w http.ResponseWriter, r *http.Request) {
+ vars := mux.Vars(r)
+ writeHeaders(w)
+ _, partitionExists := vars["partition"]
+ if len(vars) == 0 || !partitionExists {
+ http.Error(w, "Mandatory parameters are missing in URL path. Please check the usage documentation", http.StatusBadRequest)
Review comment:
Please extend the error message with the missing parameter names.
##########
File path: pkg/webservice/handlers.go
##########
@@ -521,3 +523,24 @@ func updateConfiguration(conf string) (string, error) {
}
return "", fmt.Errorf("config plugin not found")
}
+
+func getPartitionQueues(w http.ResponseWriter, r *http.Request) {
+ vars := mux.Vars(r)
+ writeHeaders(w)
+ _, partitionExists := vars["partition"]
+ if len(vars) == 0 || !partitionExists {
+ http.Error(w, "Mandatory parameters are missing in URL path. Please check the usage documentation", http.StatusBadRequest)
+ return
+ }
+ var partitionQueuesDAOInfo dao.PartitionQueueDAOInfo
+ var partition = schedulerContext.GetPartition(vars["partition"])
+ if partition != nil {
+ partitionQueuesDAOInfo = partition.GetPartitionQueues()
+ } else {
+ http.Error(w, "partition not found", http.StatusInternalServerError)
Review comment:
Wouldn't be better to return with BasRequest error in this case as well? If the partition is not found that means that the user entered a wrong partition name.
##########
File path: pkg/webservice/handlers.go
##########
@@ -521,3 +523,24 @@ func updateConfiguration(conf string) (string, error) {
}
return "", fmt.Errorf("config plugin not found")
}
+
+func getPartitionQueues(w http.ResponseWriter, r *http.Request) {
+ vars := mux.Vars(r)
+ writeHeaders(w)
+ _, partitionExists := vars["partition"]
Review comment:
Please save here the partition name instead of ignoring it, so in the line 536 you can directly use it
##########
File path: pkg/webservice/dao/queue_info.go
##########
@@ -31,3 +31,16 @@ type QueueCapacity struct {
UsedCapacity string `json:"usedcapacity"`
AbsUsedCapacity string `json:"absusedcapacity"`
}
+
+type PartitionQueueDAOInfo struct {
+ QueueName string `json:"queuename"`
+ Status string `json:"status"`
+ Partition string `json:"partition"`
+ MaxResource string `json:"maxResource"`
+ GuaranteedResource string `json:"guaranteedResource"`
+ AllocatedResource string `json:"allocatedResource"`
+ IsLeaf bool `json:"isLeaf"`
+ IsManaged bool `json:"isManaged"`
+ Parent string `json:"parent"`
+ Children []PartitionQueueDAOInfo `json:"children"`
+}
Review comment:
We already have defined a `QueueDAOInfo`, I think we should reuse/modify that one instead of creating a new DAO structure for the Queues.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] codecov[bot] edited a comment on pull request #223: YUNIKORN-415: Add "queues" REST API to fetch list of queues
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #223:
URL: https://github.com/apache/incubator-yunikorn-core/pull/223#issuecomment-735884155
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223?src=pr&el=h1) Report
> Merging [#223](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223?src=pr&el=desc) (1cb9dbc) into [master](https://codecov.io/gh/apache/incubator-yunikorn-core/commit/683dea6673c75f24a3dfc892c31c12df212b0afe?el=desc) (683dea6) will **decrease** coverage by `0.32%`.
> The diff coverage is `18.42%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #223 +/- ##
==========================================
- Coverage 63.06% 62.74% -0.33%
==========================================
Files 59 59
Lines 4855 4891 +36
==========================================
+ Hits 3062 3069 +7
- Misses 1651 1677 +26
- Partials 142 145 +3
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/objects/queue.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223/diff?src=pr&el=tree#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL3F1ZXVlLmdv) | `67.10% <0.00%> (-2.60%)` | :arrow_down: |
| [pkg/scheduler/partition.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223/diff?src=pr&el=tree#diff-cGtnL3NjaGVkdWxlci9wYXJ0aXRpb24uZ28=) | `64.42% <0.00%> (-0.48%)` | :arrow_down: |
| [pkg/webservice/handlers.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223/diff?src=pr&el=tree#diff-cGtnL3dlYnNlcnZpY2UvaGFuZGxlcnMuZ28=) | `54.66% <46.66%> (-0.43%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223?src=pr&el=footer). Last update [683dea6...aae850a](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] manirajv06 commented on pull request #223: YUNIKORN-415: Add "queues" REST API to fetch list of queues
Posted by GitBox <gi...@apache.org>.
manirajv06 commented on pull request #223:
URL: https://github.com/apache/incubator-yunikorn-core/pull/223#issuecomment-766920950
> Can you please add some more test cases? The patch coverage is very low.
As a general thing, Developed test cases to ensure API return results as expected. Let me see..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] manirajv06 commented on a change in pull request #223: YUNIKORN-415: Add "queues" REST API to fetch list of queues
Posted by GitBox <gi...@apache.org>.
manirajv06 commented on a change in pull request #223:
URL: https://github.com/apache/incubator-yunikorn-core/pull/223#discussion_r563832692
##########
File path: pkg/webservice/routes.go
##########
@@ -127,6 +127,13 @@ var webRoutes = routes{
getContainerHistory,
},
+ route{
+ "Scheduler",
+ "GET",
+ "/ws/v1/partition/{partition}/queues",
+ getPartitionQueues,
Review comment:
Idea is to migrate the users to newly designed API's and slowly retire old one's. Hence, didn't touched the old places, in fact created a completely new dao's, struct etc and planning to take care of all clean up activities after the adoption through separate jira's. This way, we need not worry to about backward compatibility etc. Hope it makes sense.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] codecov[bot] edited a comment on pull request #223: YUNIKORN-415: Add "queues" REST API to fetch list of queues
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #223:
URL: https://github.com/apache/incubator-yunikorn-core/pull/223#issuecomment-735884155
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#223](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d39ed04) into [master](https://codecov.io/gh/apache/incubator-yunikorn-core/commit/5a1c19e280f66d6cb4fc206a675116260d6f2ff1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5a1c19e) will **decrease** coverage by `0.73%`.
> The diff coverage is `17.07%`.
> :exclamation: Current head d39ed04 differs from pull request most recent head 81c651a. Consider uploading reports for the commit 81c651a to get more accurate results
[](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #223 +/- ##
==========================================
- Coverage 63.46% 62.73% -0.74%
==========================================
Files 60 60
Lines 5220 5238 +18
==========================================
- Hits 3313 3286 -27
- Misses 1747 1787 +40
- Partials 160 165 +5
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/objects/queue.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL3F1ZXVlLmdv) | `67.01% <0.00%> (-2.44%)` | :arrow_down: |
| [pkg/scheduler/partition.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9wYXJ0aXRpb24uZ28=) | `62.37% <0.00%> (-3.67%)` | :arrow_down: |
| [pkg/webservice/handlers.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3dlYnNlcnZpY2UvaGFuZGxlcnMuZ28=) | `53.24% <38.88%> (-0.90%)` | :arrow_down: |
| [pkg/scheduler/partition\_manager.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9wYXJ0aXRpb25fbWFuYWdlci5nbw==) | `16.00% <0.00%> (-4.00%)` | :arrow_down: |
| [pkg/scheduler/objects/application\_state.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FwcGxpY2F0aW9uX3N0YXRlLmdv) | `94.82% <0.00%> (-0.95%)` | :arrow_down: |
| [pkg/scheduler/objects/application.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FwcGxpY2F0aW9uLmdv) | `49.06% <0.00%> (+0.15%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [cb890bf...81c651a](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] manirajv06 commented on a change in pull request #223: YUNIKORN-415: Add "queues" REST API to fetch list of queues
Posted by GitBox <gi...@apache.org>.
manirajv06 commented on a change in pull request #223:
URL: https://github.com/apache/incubator-yunikorn-core/pull/223#discussion_r563833169
##########
File path: pkg/webservice/handlers.go
##########
@@ -521,3 +523,24 @@ func updateConfiguration(conf string) (string, error) {
}
return "", fmt.Errorf("config plugin not found")
}
+
+func getPartitionQueues(w http.ResponseWriter, r *http.Request) {
+ vars := mux.Vars(r)
+ writeHeaders(w)
+ _, partitionExists := vars["partition"]
Review comment:
Taken care.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] manirajv06 commented on pull request #223: YUNIKORN-415: Add "queues" REST API to fetch list of queues
Posted by GitBox <gi...@apache.org>.
manirajv06 commented on pull request #223:
URL: https://github.com/apache/incubator-yunikorn-core/pull/223#issuecomment-833290633
@yangwwei @wilfred-s Made changes to use buildJSONErrorResponse() and added few more test cases. Can you please review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] codecov[bot] edited a comment on pull request #223: YUNIKORN-415: Add "queues" REST API to fetch list of queues
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #223:
URL: https://github.com/apache/incubator-yunikorn-core/pull/223#issuecomment-735884155
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#223](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d39ed04) into [master](https://codecov.io/gh/apache/incubator-yunikorn-core/commit/5a1c19e280f66d6cb4fc206a675116260d6f2ff1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5a1c19e) will **decrease** coverage by `0.73%`.
> The diff coverage is `17.07%`.
> :exclamation: Current head d39ed04 differs from pull request most recent head 859ac2a. Consider uploading reports for the commit 859ac2a to get more accurate results
[](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #223 +/- ##
==========================================
- Coverage 63.46% 62.73% -0.74%
==========================================
Files 60 60
Lines 5220 5238 +18
==========================================
- Hits 3313 3286 -27
- Misses 1747 1787 +40
- Partials 160 165 +5
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/objects/queue.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL3F1ZXVlLmdv) | `67.01% <0.00%> (-2.44%)` | :arrow_down: |
| [pkg/scheduler/partition.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9wYXJ0aXRpb24uZ28=) | `62.37% <0.00%> (-3.67%)` | :arrow_down: |
| [pkg/webservice/handlers.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3dlYnNlcnZpY2UvaGFuZGxlcnMuZ28=) | `53.24% <38.88%> (-0.90%)` | :arrow_down: |
| [pkg/scheduler/partition\_manager.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9wYXJ0aXRpb25fbWFuYWdlci5nbw==) | `16.00% <0.00%> (-4.00%)` | :arrow_down: |
| [pkg/scheduler/objects/application\_state.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FwcGxpY2F0aW9uX3N0YXRlLmdv) | `94.82% <0.00%> (-0.95%)` | :arrow_down: |
| [pkg/scheduler/objects/application.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FwcGxpY2F0aW9uLmdv) | `49.06% <0.00%> (+0.15%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [cb890bf...859ac2a](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] codecov[bot] commented on pull request #223: YUNIKORN-415: Add "queues" REST API to fetch list of queues
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #223:
URL: https://github.com/apache/incubator-yunikorn-core/pull/223#issuecomment-735884155
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223?src=pr&el=h1) Report
> Merging [#223](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223?src=pr&el=desc) (1cb9dbc) into [master](https://codecov.io/gh/apache/incubator-yunikorn-core/commit/683dea6673c75f24a3dfc892c31c12df212b0afe?el=desc) (683dea6) will **decrease** coverage by `0.32%`.
> The diff coverage is `18.42%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #223 +/- ##
==========================================
- Coverage 63.06% 62.74% -0.33%
==========================================
Files 59 59
Lines 4855 4891 +36
==========================================
+ Hits 3062 3069 +7
- Misses 1651 1677 +26
- Partials 142 145 +3
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/objects/queue.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223/diff?src=pr&el=tree#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL3F1ZXVlLmdv) | `67.10% <0.00%> (-2.60%)` | :arrow_down: |
| [pkg/scheduler/partition.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223/diff?src=pr&el=tree#diff-cGtnL3NjaGVkdWxlci9wYXJ0aXRpb24uZ28=) | `64.42% <0.00%> (-0.48%)` | :arrow_down: |
| [pkg/webservice/handlers.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223/diff?src=pr&el=tree#diff-cGtnL3dlYnNlcnZpY2UvaGFuZGxlcnMuZ28=) | `54.66% <46.66%> (-0.43%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223?src=pr&el=footer). Last update [683dea6...1cb9dbc](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] manirajv06 commented on pull request #223: YUNIKORN-415: Add "queues" REST API to fetch list of queues
Posted by GitBox <gi...@apache.org>.
manirajv06 commented on pull request #223:
URL: https://github.com/apache/incubator-yunikorn-core/pull/223#issuecomment-766920950
> Can you please add some more test cases? The patch coverage is very low.
As a general thing, Developed test cases to ensure API return results as expected. Let me see..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] manirajv06 commented on a change in pull request #223: YUNIKORN-415: Add "queues" REST API to fetch list of queues
Posted by GitBox <gi...@apache.org>.
manirajv06 commented on a change in pull request #223:
URL: https://github.com/apache/incubator-yunikorn-core/pull/223#discussion_r563832875
##########
File path: pkg/webservice/handlers.go
##########
@@ -521,3 +523,24 @@ func updateConfiguration(conf string) (string, error) {
}
return "", fmt.Errorf("config plugin not found")
}
+
+func getPartitionQueues(w http.ResponseWriter, r *http.Request) {
+ vars := mux.Vars(r)
+ writeHeaders(w)
+ _, partitionExists := vars["partition"]
+ if len(vars) == 0 || !partitionExists {
+ http.Error(w, "Mandatory parameters are missing in URL path. Please check the usage documentation", http.StatusBadRequest)
Review comment:
Taken care.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] kingamarton commented on a change in pull request #223: YUNIKORN-415: Add "queues" REST API to fetch list of queues
Posted by GitBox <gi...@apache.org>.
kingamarton commented on a change in pull request #223:
URL: https://github.com/apache/incubator-yunikorn-core/pull/223#discussion_r563677898
##########
File path: pkg/webservice/routes.go
##########
@@ -127,6 +127,13 @@ var webRoutes = routes{
getContainerHistory,
},
+ route{
+ "Scheduler",
+ "GET",
+ "/ws/v1/partition/{partition}/queues",
+ getPartitionQueues,
Review comment:
Now we have two endpoint for retrieving the queue infos. Shouldn't we delete the old one? Or what is the plan, how will the transition to the new API will be done?
##########
File path: pkg/webservice/handlers.go
##########
@@ -521,3 +523,24 @@ func updateConfiguration(conf string) (string, error) {
}
return "", fmt.Errorf("config plugin not found")
}
+
+func getPartitionQueues(w http.ResponseWriter, r *http.Request) {
+ vars := mux.Vars(r)
+ writeHeaders(w)
+ _, partitionExists := vars["partition"]
+ if len(vars) == 0 || !partitionExists {
+ http.Error(w, "Mandatory parameters are missing in URL path. Please check the usage documentation", http.StatusBadRequest)
Review comment:
Please extend the error message with the missing parameter names.
##########
File path: pkg/webservice/handlers.go
##########
@@ -521,3 +523,24 @@ func updateConfiguration(conf string) (string, error) {
}
return "", fmt.Errorf("config plugin not found")
}
+
+func getPartitionQueues(w http.ResponseWriter, r *http.Request) {
+ vars := mux.Vars(r)
+ writeHeaders(w)
+ _, partitionExists := vars["partition"]
+ if len(vars) == 0 || !partitionExists {
+ http.Error(w, "Mandatory parameters are missing in URL path. Please check the usage documentation", http.StatusBadRequest)
+ return
+ }
+ var partitionQueuesDAOInfo dao.PartitionQueueDAOInfo
+ var partition = schedulerContext.GetPartition(vars["partition"])
+ if partition != nil {
+ partitionQueuesDAOInfo = partition.GetPartitionQueues()
+ } else {
+ http.Error(w, "partition not found", http.StatusInternalServerError)
Review comment:
Wouldn't be better to return with BasRequest error in this case as well? If the partition is not found that means that the user entered a wrong partition name.
##########
File path: pkg/webservice/handlers.go
##########
@@ -521,3 +523,24 @@ func updateConfiguration(conf string) (string, error) {
}
return "", fmt.Errorf("config plugin not found")
}
+
+func getPartitionQueues(w http.ResponseWriter, r *http.Request) {
+ vars := mux.Vars(r)
+ writeHeaders(w)
+ _, partitionExists := vars["partition"]
Review comment:
Please save here the partition name instead of ignoring it, so in the line 536 you can directly use it
##########
File path: pkg/webservice/dao/queue_info.go
##########
@@ -31,3 +31,16 @@ type QueueCapacity struct {
UsedCapacity string `json:"usedcapacity"`
AbsUsedCapacity string `json:"absusedcapacity"`
}
+
+type PartitionQueueDAOInfo struct {
+ QueueName string `json:"queuename"`
+ Status string `json:"status"`
+ Partition string `json:"partition"`
+ MaxResource string `json:"maxResource"`
+ GuaranteedResource string `json:"guaranteedResource"`
+ AllocatedResource string `json:"allocatedResource"`
+ IsLeaf bool `json:"isLeaf"`
+ IsManaged bool `json:"isManaged"`
+ Parent string `json:"parent"`
+ Children []PartitionQueueDAOInfo `json:"children"`
+}
Review comment:
We already have defined a `QueueDAOInfo`, I think we should reuse/modify that one instead of creating a new DAO structure for the Queues.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] manirajv06 commented on a change in pull request #223: YUNIKORN-415: Add "queues" REST API to fetch list of queues
Posted by GitBox <gi...@apache.org>.
manirajv06 commented on a change in pull request #223:
URL: https://github.com/apache/incubator-yunikorn-core/pull/223#discussion_r563832692
##########
File path: pkg/webservice/routes.go
##########
@@ -127,6 +127,13 @@ var webRoutes = routes{
getContainerHistory,
},
+ route{
+ "Scheduler",
+ "GET",
+ "/ws/v1/partition/{partition}/queues",
+ getPartitionQueues,
Review comment:
Idea is to migrate the users to newly designed API's and slowly retire old one's. Hence, didn't touched the old places, in fact created a completely new dao's, struct etc and planning to take care of all clean up activities after the adoption through separate jira's. This way, we need not worry to about backward compatibility etc. Hope it makes sense.
##########
File path: pkg/webservice/handlers.go
##########
@@ -521,3 +523,24 @@ func updateConfiguration(conf string) (string, error) {
}
return "", fmt.Errorf("config plugin not found")
}
+
+func getPartitionQueues(w http.ResponseWriter, r *http.Request) {
+ vars := mux.Vars(r)
+ writeHeaders(w)
+ _, partitionExists := vars["partition"]
+ if len(vars) == 0 || !partitionExists {
+ http.Error(w, "Mandatory parameters are missing in URL path. Please check the usage documentation", http.StatusBadRequest)
Review comment:
Taken care.
##########
File path: pkg/webservice/handlers.go
##########
@@ -521,3 +523,24 @@ func updateConfiguration(conf string) (string, error) {
}
return "", fmt.Errorf("config plugin not found")
}
+
+func getPartitionQueues(w http.ResponseWriter, r *http.Request) {
+ vars := mux.Vars(r)
+ writeHeaders(w)
+ _, partitionExists := vars["partition"]
Review comment:
Taken care.
##########
File path: pkg/webservice/dao/queue_info.go
##########
@@ -31,3 +31,16 @@ type QueueCapacity struct {
UsedCapacity string `json:"usedcapacity"`
AbsUsedCapacity string `json:"absusedcapacity"`
}
+
+type PartitionQueueDAOInfo struct {
+ QueueName string `json:"queuename"`
+ Status string `json:"status"`
+ Partition string `json:"partition"`
+ MaxResource string `json:"maxResource"`
+ GuaranteedResource string `json:"guaranteedResource"`
+ AllocatedResource string `json:"allocatedResource"`
+ IsLeaf bool `json:"isLeaf"`
+ IsManaged bool `json:"isManaged"`
+ Parent string `json:"parent"`
+ Children []PartitionQueueDAOInfo `json:"children"`
+}
Review comment:
Comment https://github.com/apache/incubator-yunikorn-core/pull/223#discussion_r563832692 covers this too.
##########
File path: pkg/webservice/handlers.go
##########
@@ -521,3 +523,24 @@ func updateConfiguration(conf string) (string, error) {
}
return "", fmt.Errorf("config plugin not found")
}
+
+func getPartitionQueues(w http.ResponseWriter, r *http.Request) {
+ vars := mux.Vars(r)
+ writeHeaders(w)
+ _, partitionExists := vars["partition"]
+ if len(vars) == 0 || !partitionExists {
+ http.Error(w, "Mandatory parameters are missing in URL path. Please check the usage documentation", http.StatusBadRequest)
+ return
+ }
+ var partitionQueuesDAOInfo dao.PartitionQueueDAOInfo
+ var partition = schedulerContext.GetPartition(vars["partition"])
+ if partition != nil {
+ partitionQueuesDAOInfo = partition.GetPartitionQueues()
+ } else {
+ http.Error(w, "partition not found", http.StatusInternalServerError)
Review comment:
Taken care.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] manirajv06 commented on a change in pull request #223: YUNIKORN-415: Add "queues" REST API to fetch list of queues
Posted by GitBox <gi...@apache.org>.
manirajv06 commented on a change in pull request #223:
URL: https://github.com/apache/incubator-yunikorn-core/pull/223#discussion_r563834741
##########
File path: pkg/webservice/dao/queue_info.go
##########
@@ -31,3 +31,16 @@ type QueueCapacity struct {
UsedCapacity string `json:"usedcapacity"`
AbsUsedCapacity string `json:"absusedcapacity"`
}
+
+type PartitionQueueDAOInfo struct {
+ QueueName string `json:"queuename"`
+ Status string `json:"status"`
+ Partition string `json:"partition"`
+ MaxResource string `json:"maxResource"`
+ GuaranteedResource string `json:"guaranteedResource"`
+ AllocatedResource string `json:"allocatedResource"`
+ IsLeaf bool `json:"isLeaf"`
+ IsManaged bool `json:"isManaged"`
+ Parent string `json:"parent"`
+ Children []PartitionQueueDAOInfo `json:"children"`
+}
Review comment:
Comment https://github.com/apache/incubator-yunikorn-core/pull/223#discussion_r563832692 covers this too.
##########
File path: pkg/webservice/handlers.go
##########
@@ -521,3 +523,24 @@ func updateConfiguration(conf string) (string, error) {
}
return "", fmt.Errorf("config plugin not found")
}
+
+func getPartitionQueues(w http.ResponseWriter, r *http.Request) {
+ vars := mux.Vars(r)
+ writeHeaders(w)
+ _, partitionExists := vars["partition"]
+ if len(vars) == 0 || !partitionExists {
+ http.Error(w, "Mandatory parameters are missing in URL path. Please check the usage documentation", http.StatusBadRequest)
+ return
+ }
+ var partitionQueuesDAOInfo dao.PartitionQueueDAOInfo
+ var partition = schedulerContext.GetPartition(vars["partition"])
+ if partition != nil {
+ partitionQueuesDAOInfo = partition.GetPartitionQueues()
+ } else {
+ http.Error(w, "partition not found", http.StatusInternalServerError)
Review comment:
Taken care.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] sunilgovind commented on pull request #223: YUNIKORN-415: Add "queues" REST API to fetch list of queues
Posted by GitBox <gi...@apache.org>.
sunilgovind commented on pull request #223:
URL: https://github.com/apache/incubator-yunikorn-core/pull/223#issuecomment-737197384
@manirajv06 could you please help to check with the codecov report as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] sunilgovind commented on a change in pull request #223: YUNIKORN-415: Add "queues" REST API to fetch list of queues
Posted by GitBox <gi...@apache.org>.
sunilgovind commented on a change in pull request #223:
URL: https://github.com/apache/incubator-yunikorn-core/pull/223#discussion_r534125650
##########
File path: pkg/scheduler/objects/queue.go
##########
@@ -401,6 +401,28 @@ func (sq *Queue) GetQueueInfos() dao.QueueDAOInfo {
return queueInfo
}
+func (sq *Queue) GetPartitionQueues() dao.PartitionQueueDAOInfo {
+ queueInfo := dao.PartitionQueueDAOInfo{}
+ if len(sq.children) > 0 {
+ for _, child := range sq.GetCopyOfChildren() {
+ queueInfo.Children = append(queueInfo.Children, child.GetPartitionQueues())
+ }
+ }
+ queueInfo.QueueName = sq.GetQueuePath()
+ queueInfo.Status = sq.stateMachine.Current()
Review comment:
Looks good
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] yangwwei commented on pull request #223: YUNIKORN-415: Add "queues" REST API to fetch list of queues
Posted by GitBox <gi...@apache.org>.
yangwwei commented on pull request #223:
URL: https://github.com/apache/incubator-yunikorn-core/pull/223#issuecomment-734652262
hi @manirajv06 thanks for working on this. Is this PR ready for review? I see some travis job failures so I am not sure if this is ready for review. Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] codecov[bot] edited a comment on pull request #223: YUNIKORN-415: Add "queues" REST API to fetch list of queues
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #223:
URL: https://github.com/apache/incubator-yunikorn-core/pull/223#issuecomment-735884155
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#223](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d39ed04) into [master](https://codecov.io/gh/apache/incubator-yunikorn-core/commit/5a1c19e280f66d6cb4fc206a675116260d6f2ff1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5a1c19e) will **decrease** coverage by `0.73%`.
> The diff coverage is `17.07%`.
> :exclamation: Current head d39ed04 differs from pull request most recent head bb362d9. Consider uploading reports for the commit bb362d9 to get more accurate results
[](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #223 +/- ##
==========================================
- Coverage 63.46% 62.73% -0.74%
==========================================
Files 60 60
Lines 5220 5238 +18
==========================================
- Hits 3313 3286 -27
- Misses 1747 1787 +40
- Partials 160 165 +5
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/objects/queue.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL3F1ZXVlLmdv) | `67.01% <0.00%> (-2.44%)` | :arrow_down: |
| [pkg/scheduler/partition.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9wYXJ0aXRpb24uZ28=) | `62.37% <0.00%> (-3.67%)` | :arrow_down: |
| [pkg/webservice/handlers.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3dlYnNlcnZpY2UvaGFuZGxlcnMuZ28=) | `53.24% <38.88%> (-0.90%)` | :arrow_down: |
| [pkg/scheduler/partition\_manager.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9wYXJ0aXRpb25fbWFuYWdlci5nbw==) | `16.00% <0.00%> (-4.00%)` | :arrow_down: |
| [pkg/scheduler/objects/application\_state.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FwcGxpY2F0aW9uX3N0YXRlLmdv) | `94.82% <0.00%> (-0.95%)` | :arrow_down: |
| [pkg/scheduler/objects/application.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FwcGxpY2F0aW9uLmdv) | `49.06% <0.00%> (+0.15%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [cb890bf...bb362d9](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] codecov[bot] edited a comment on pull request #223: YUNIKORN-415: Add "queues" REST API to fetch list of queues
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #223:
URL: https://github.com/apache/incubator-yunikorn-core/pull/223#issuecomment-735884155
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223?src=pr&el=h1) Report
> Merging [#223](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223?src=pr&el=desc) (aae850a) into [master](https://codecov.io/gh/apache/incubator-yunikorn-core/commit/361d455c7f28b64fe6ae89b7a0dca310ace7783f?el=desc) (361d455) will **decrease** coverage by `0.33%`.
> The diff coverage is `47.22%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #223 +/- ##
==========================================
- Coverage 63.06% 62.73% -0.34%
==========================================
Files 60 60
Lines 5199 5238 +39
==========================================
+ Hits 3279 3286 +7
- Misses 1759 1787 +28
- Partials 161 165 +4
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/objects/queue.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223/diff?src=pr&el=tree#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL3F1ZXVlLmdv) | `67.01% <25.00%> (-2.44%)` | :arrow_down: |
| [pkg/webservice/handlers.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223/diff?src=pr&el=tree#diff-cGtnL3dlYnNlcnZpY2UvaGFuZGxlcnMuZ28=) | `53.24% <61.11%> (-0.90%)` | :arrow_down: |
| [pkg/scheduler/partition.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223/diff?src=pr&el=tree#diff-cGtnL3NjaGVkdWxlci9wYXJ0aXRpb24uZ28=) | `62.37% <100.00%> (-0.42%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223?src=pr&el=footer). Last update [2bf2767...d39ed04](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] kingamarton merged pull request #223: YUNIKORN-415: Add "queues" REST API to fetch list of queues
Posted by GitBox <gi...@apache.org>.
kingamarton merged pull request #223:
URL: https://github.com/apache/incubator-yunikorn-core/pull/223
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] codecov[bot] edited a comment on pull request #223: YUNIKORN-415: Add "queues" REST API to fetch list of queues
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #223:
URL: https://github.com/apache/incubator-yunikorn-core/pull/223#issuecomment-735884155
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] sunilgovind commented on a change in pull request #223: YUNIKORN-415: Add "queues" REST API to fetch list of queues
Posted by GitBox <gi...@apache.org>.
sunilgovind commented on a change in pull request #223:
URL: https://github.com/apache/incubator-yunikorn-core/pull/223#discussion_r534125919
##########
File path: pkg/scheduler/objects/queue.go
##########
@@ -401,6 +401,28 @@ func (sq *Queue) GetQueueInfos() dao.QueueDAOInfo {
return queueInfo
}
+func (sq *Queue) GetPartitionQueues() dao.PartitionQueueDAOInfo {
+ queueInfo := dao.PartitionQueueDAOInfo{}
+ if len(sq.children) > 0 {
+ for _, child := range sq.GetCopyOfChildren() {
+ queueInfo.Children = append(queueInfo.Children, child.GetPartitionQueues())
+ }
+ }
+ queueInfo.QueueName = sq.GetQueuePath()
+ queueInfo.Status = sq.stateMachine.Current()
Review comment:
looks good
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] codecov[bot] edited a comment on pull request #223: YUNIKORN-415: Add "queues" REST API to fetch list of queues
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #223:
URL: https://github.com/apache/incubator-yunikorn-core/pull/223#issuecomment-735884155
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223?src=pr&el=h1) Report
> Merging [#223](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223?src=pr&el=desc) (aae850a) into [master](https://codecov.io/gh/apache/incubator-yunikorn-core/commit/683dea6673c75f24a3dfc892c31c12df212b0afe?el=desc) (683dea6) will **decrease** coverage by `0.33%`.
> The diff coverage is `47.22%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #223 +/- ##
==========================================
- Coverage 63.06% 62.73% -0.34%
==========================================
Files 59 60 +1
Lines 4855 5238 +383
==========================================
+ Hits 3062 3286 +224
- Misses 1651 1787 +136
- Partials 142 165 +23
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/objects/queue.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223/diff?src=pr&el=tree#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL3F1ZXVlLmdv) | `67.01% <25.00%> (-2.70%)` | :arrow_down: |
| [pkg/webservice/handlers.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223/diff?src=pr&el=tree#diff-cGtnL3dlYnNlcnZpY2UvaGFuZGxlcnMuZ28=) | `53.24% <61.11%> (-1.85%)` | :arrow_down: |
| [pkg/scheduler/partition.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223/diff?src=pr&el=tree#diff-cGtnL3NjaGVkdWxlci9wYXJ0aXRpb24uZ28=) | `62.37% <100.00%> (-2.53%)` | :arrow_down: |
| [pkg/scheduler/objects/application.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223/diff?src=pr&el=tree#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FwcGxpY2F0aW9uLmdv) | `49.06% <0.00%> (-5.21%)` | :arrow_down: |
| [pkg/metrics/scheduler.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223/diff?src=pr&el=tree#diff-cGtnL21ldHJpY3Mvc2NoZWR1bGVyLmdv) | `61.58% <0.00%> (-3.69%)` | :arrow_down: |
| [pkg/scheduler/objects/node.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223/diff?src=pr&el=tree#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL25vZGUuZ28=) | `81.81% <0.00%> (-3.49%)` | :arrow_down: |
| [pkg/common/resources/resources.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi9yZXNvdXJjZXMvcmVzb3VyY2VzLmdv) | `96.02% <0.00%> (-1.48%)` | :arrow_down: |
| ... and [7 more](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223?src=pr&el=footer). Last update [683dea6...aae850a](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] codecov[bot] edited a comment on pull request #223: YUNIKORN-415: Add "queues" REST API to fetch list of queues
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #223:
URL: https://github.com/apache/incubator-yunikorn-core/pull/223#issuecomment-735884155
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#223](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (859ac2a) into [master](https://codecov.io/gh/apache/incubator-yunikorn-core/commit/5a1c19e280f66d6cb4fc206a675116260d6f2ff1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5a1c19e) will **increase** coverage by `1.46%`.
> The diff coverage is `65.42%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #223 +/- ##
==========================================
+ Coverage 63.46% 64.93% +1.46%
==========================================
Files 60 60
Lines 5220 5604 +384
==========================================
+ Hits 3313 3639 +326
- Misses 1747 1787 +40
- Partials 160 178 +18
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/metrics/init.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21ldHJpY3MvaW5pdC5nbw==) | `62.96% <ø> (ø)` | |
| [pkg/scheduler/context.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9jb250ZXh0Lmdv) | `5.78% <0.00%> (-0.49%)` | :arrow_down: |
| [pkg/scheduler/nodes\_usage\_monitor.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9ub2Rlc191c2FnZV9tb25pdG9yLmdv) | `0.00% <0.00%> (ø)` | |
| [pkg/scheduler/objects/allocation.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FsbG9jYXRpb24uZ28=) | `100.00% <ø> (ø)` | |
| [pkg/webservice/webservice.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3dlYnNlcnZpY2Uvd2Vic2VydmljZS5nbw==) | `32.25% <ø> (+19.35%)` | :arrow_up: |
| [pkg/scheduler/objects/queue.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL3F1ZXVlLmdv) | `66.80% <22.58%> (-2.65%)` | :arrow_down: |
| [pkg/metrics/metrics\_collector.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21ldHJpY3MvbWV0cmljc19jb2xsZWN0b3IuZ28=) | `63.33% <30.00%> (-10.58%)` | :arrow_down: |
| [pkg/scheduler/partition\_manager.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9wYXJ0aXRpb25fbWFuYWdlci5nbw==) | `20.00% <50.00%> (ø)` | |
| [pkg/scheduler/objects/application.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FwcGxpY2F0aW9uLmdv) | `56.58% <64.70%> (+7.67%)` | :arrow_up: |
| [pkg/webservice/handlers.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3dlYnNlcnZpY2UvaGFuZGxlcnMuZ28=) | `59.39% <70.83%> (+5.25%)` | :arrow_up: |
| ... and [11 more](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [cb890bf...859ac2a](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/223?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org