change-svn-wc-format

[Edmund Wong <ed...@belfordhk.com>]

Hi,

I'm using TortoiseSVN 1.6 (just upgraded) and Subversion
1.6 (via svnserve -i).

If the local WC is downgraded from, say 1.6 to 1.5, the
repository is still in the 1.6 state.  Does this mean
I need to also downgrade the repository as well or have
I misunderstood the whole point of this script?

I managed to patch the change-svn-wc-format.py file
to create the format file within the .svn folder;
but, since I'm not entirely sure of this, is this
'format' file supposed to be elsewhere other than
.svn/?   i.e. should it also be in .svn/text-base?
(I don't even know if I should categorize this
as a rhetorical question since I can't see any
format files in my 1.5 WC for my own project
files.)  I set up a new 1.6 repository using
svnserve as the server to test it out.  This
repository itself has a format file with a
5 in it.  (Confusing me a bit here)

After running the new patched change-svn-wc-format.py,
and then updating the WC, the format file
is removed.  I'm assuming this is right since
the repository is still in 1.6.

Any clarifications appreciated.

Thanks

Edmund

PS: FWIW, I'll post a diff.  Please note the following:
   1) I only just started doing Python for a few days.
   2) I need major guidance in this whole peer review.
      I've never submitted a patch before so I don't
      know what to expect.

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1439738

Re: change-svn-wc-format

[Edmund Wong <ed...@belfordhk.com>]

Hi Stephen,

> 
> The script is client-side only.
> Subversion servers are interoperable with all client versions.

Good. Thanks for the clarification.

> 
> See subversion/libsvn_wc/wc.h for an explanation of this number.
> The huge comment above the definition of SVN_WC__VERSION.

I'll check it out.  

> > PS: FWIW, I'll post a diff.  Please note the following:
> >    1) I only just started doing Python for a few days.
> 
> Learning Python does not take long.

I noticed that.  I did a speed read of "Learning Python".  I'll
probably pick it up a bit more as I go along.  Now I'm trying
my go and C, so I hopefully can chip in with SVN's main stuff
but I can tell it's going to be a while.  I remember C being
a difficult language to pick up. (Pointers being my main problems. :))

> I gave you a review, I hope it's similar to what you expected :)

I got it.  Thanks for the review.  

At this point, I've made the modifications.  I'm not sure if I 
should post it now, or wait for your response on the message change
issue.

Thanks.

Edmund

--
"Pax tecum"

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1451865

Re: change-svn-wc-format

[Stefan Sperling <st...@elego.de>]

On Fri, Mar 27, 2009 at 12:49:15PM +0800, Edmund Wong wrote:
> Hi,
> 
> I'm using TortoiseSVN 1.6 (just upgraded) and Subversion
> 1.6 (via svnserve -i).
> 
> If the local WC is downgraded from, say 1.6 to 1.5, the
> repository is still in the 1.6 state.  Does this mean
> I need to also downgrade the repository as well or have
> I misunderstood the whole point of this script?

The script is client-side only.
Subversion servers are interoperable with all client versions.

> I managed to patch the change-svn-wc-format.py file
> to create the format file within the .svn folder;
> but, since I'm not entirely sure of this, is this
> 'format' file supposed to be elsewhere other than
> .svn/?   i.e. should it also be in .svn/text-base?

Just in .svn.

> (I don't even know if I should categorize this
> as a rhetorical question since I can't see any
> format files in my 1.5 WC for my own project
> files.)  I set up a new 1.6 repository using
> svnserve as the server to test it out.  This
> repository itself has a format file with a
> 5 in it.  (Confusing me a bit here)

See subversion/libsvn_wc/wc.h for an explanation of this number.
The huge comment above the definition of SVN_WC__VERSION.

> After running the new patched change-svn-wc-format.py,
> and then updating the WC, the format file
> is removed.  I'm assuming this is right since
> the repository is still in 1.6.

The repository has nothing to do with it.
The 1.6.0 client is removing the format file.

It errors out if the file is not there, even though it should
not error out -- this is the bug that you are trying to address
by updating the script.
 
> PS: FWIW, I'll post a diff.  Please note the following:
>    1) I only just started doing Python for a few days.

Learning Python does not take long.

>    2) I need major guidance in this whole peer review.
>       I've never submitted a patch before so I don't
>       know what to expect.

I gave you a review, I hope it's similar to what you expected :)

Stefan