You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/01/10 01:00:18 UTC
[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4969: Add
error for empty instance list for tenant API
codecov-io edited a comment on issue #4969: Add error for empty instance list for tenant API
URL: https://github.com/apache/incubator-pinot/pull/4969#issuecomment-572822332
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4969?src=pr&el=h1) Report
> Merging [#4969](https://codecov.io/gh/apache/incubator-pinot/pull/4969?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/5503d4d6821c0e8495c5b7ee5b3c8a32bdac9dec?src=pr&el=desc) will **decrease** coverage by `5.41%`.
> The diff coverage is `73.33%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/4969?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4969 +/- ##
============================================
- Coverage 57.1% 51.68% -5.42%
Complexity 12 12
============================================
Files 1175 1175
Lines 62413 62421 +8
Branches 9179 9182 +3
============================================
- Hits 35638 32262 -3376
- Misses 24117 27689 +3572
+ Partials 2658 2470 -188
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4969?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ller/api/resources/PinotTenantRestletResource.java](https://codecov.io/gh/apache/incubator-pinot/pull/4969/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9hcGkvcmVzb3VyY2VzL1Bpbm90VGVuYW50UmVzdGxldFJlc291cmNlLmphdmE=) | `35.37% <73.33%> (+0.84%)` | `0 <0> (ø)` | :arrow_down: |
| [...starter/helix/DefaultHelixStarterServerConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/4969/diff?src=pr&el=tree#diff-cGlub3Qtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zZXJ2ZXIvc3RhcnRlci9oZWxpeC9EZWZhdWx0SGVsaXhTdGFydGVyU2VydmVyQ29uZmlnLmphdmE=) | `0% <0%> (-96.16%)` | `0% <0%> (ø)` | |
| [...converter/stats/RealtimeSegmentStatsContainer.java](https://codecov.io/gh/apache/incubator-pinot/pull/4969/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9jb252ZXJ0ZXIvc3RhdHMvUmVhbHRpbWVTZWdtZW50U3RhdHNDb250YWluZXIuamF2YQ==) | `0% <0%> (-94.45%)` | `0% <0%> (ø)` | |
| [...rg/apache/pinot/tools/utils/KafkaStarterUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/4969/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL3V0aWxzL0thZmthU3RhcnRlclV0aWxzLmphdmE=) | `0% <0%> (-93.19%)` | `0% <0%> (ø)` | |
| [.../starter/helix/HelixInstanceDataManagerConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/4969/diff?src=pr&el=tree#diff-cGlub3Qtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zZXJ2ZXIvc3RhcnRlci9oZWxpeC9IZWxpeEluc3RhbmNlRGF0YU1hbmFnZXJDb25maWcuamF2YQ==) | `0% <0%> (-92.31%)` | `0% <0%> (ø)` | |
| [...ot/tools/query/comparison/SegmentInfoProvider.java](https://codecov.io/gh/apache/incubator-pinot/pull/4969/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL3F1ZXJ5L2NvbXBhcmlzb24vU2VnbWVudEluZm9Qcm92aWRlci5qYXZh) | `0% <0%> (-88.68%)` | `0% <0%> (ø)` | |
| [...rg/apache/pinot/server/starter/ServerInstance.java](https://codecov.io/gh/apache/incubator-pinot/pull/4969/diff?src=pr&el=tree#diff-cGlub3Qtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zZXJ2ZXIvc3RhcnRlci9TZXJ2ZXJJbnN0YW5jZS5qYXZh) | `1.53% <0%> (-86.16%)` | `0% <0%> (ø)` | |
| [.../transform/function/MapValueTransformFunction.java](https://codecov.io/gh/apache/incubator-pinot/pull/4969/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci90cmFuc2Zvcm0vZnVuY3Rpb24vTWFwVmFsdWVUcmFuc2Zvcm1GdW5jdGlvbi5qYXZh) | `0% <0%> (-85.3%)` | `0% <0%> (ø)` | |
| [...pache/pinot/server/starter/helix/SegmentLocks.java](https://codecov.io/gh/apache/incubator-pinot/pull/4969/diff?src=pr&el=tree#diff-cGlub3Qtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zZXJ2ZXIvc3RhcnRlci9oZWxpeC9TZWdtZW50TG9ja3MuamF2YQ==) | `0% <0%> (-83.34%)` | `0% <0%> (ø)` | |
| [...tools/query/comparison/StarTreeQueryGenerator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4969/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL3F1ZXJ5L2NvbXBhcmlzb24vU3RhclRyZWVRdWVyeUdlbmVyYXRvci5qYXZh) | `0% <0%> (-82.84%)` | `0% <0%> (ø)` | |
| ... and [193 more](https://codecov.io/gh/apache/incubator-pinot/pull/4969/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4969?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4969?src=pr&el=footer). Last update [5503d4d...4589677](https://codecov.io/gh/apache/incubator-pinot/pull/4969?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org