[jira] [Comment Edited] (YETUS-15) build environment

["Allen Wittenauer (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YETUS-15?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16215685#comment-16215685 ] 

Allen Wittenauer edited comment on YETUS-15 at 10/23/17 7:15 PM:
-----------------------------------------------------------------

-01:
* Convert the project to Apache Maven

This is an early access patch just to get some feedback and see if this is what the community agrees with direction-wise.

Why Maven?

a) Part of the project was already in Maven.
b) As you can see from this initial patch, I've already got some Public things I'd like to expose as part of an official Apache Yetus Maven plugin.
c) There's really not much you can't do with Maven.
d) Most of our downstream is also using Maven.  This is both a pro and a con; it'd probably be great if make, gradle, and ant got more of a workout, but that could be covered by integration tests as well.

What doesn't work (that I know of)?

  * Versioning

Some versions still need to be hard-coded (checkstyle and findbugs in particular)

  * Documentation

Clearly, there are some major documentation holes (how to build, how to release, etc), but also need docs for yetus-maven-plugin

  * Tests

My current plan is to commit this without ANY tests and fill those in later.  This includes the yetus-maven-plugin.  This is already a HUGE patch and I'd rather not bog down with a lot more.

  * BATS

Along that same line, I want to add a BATS driver to yetus-maven-plugin that effectively duplicates [Hadoop's run-bats|https://github.com/apache/hadoop/blob/6b8122458ede9ececb138bed99d368580e5439a1/hadoop-common-project/hadoop-common/src/test/scripts/run-bats.sh] script.

  * Website

I've made some efforts to get the website building, but not really enough to make this viable yet.  My current thinking is that we'd get the middleman version working until we can convert to maven site.  In particular, I'm debating forking https://github.com/devacfr/reflow-maven-skin into yetus-maven-skin.  I don't think a fork is avoidable, given some of the odd choices and lack of some customizations that I think we would want to do.  (I could be wrong of course).

  * Distribution

If you do a mvn package, you'll find in yetus-dist/target the apache-yetus-0.6.0-SNAPSHOT directory.  Close!

* Licensing

There's still quite few places with missing ASF license headers.  The 'hardest' one is probably the one that needs to be in the bin files that are created via the Maven plugin.


was (Author: aw):
-01:
* Convert the project to Apache Maven

This is an early access patch just to get some feedback and see if this is what the community agrees with direction-wise.

Why Maven?

a) Part of the project was already in Maven.
b) As you can see from this initial patch, I've already got some Public things I'd like to expose as part of an official Apache Yetus Maven plugin.
c) There's really not much you can't do with Maven.
d) Most of our downstream is also using Maven.  This is both a pro and a con; it'd probably be great if make, gradle, and ant got more of a workout, but that could be covered by integration tests as well.

What doesn't work (that I know of)?

  * Versioning

Some versions still need to be hard-coded (checkstyle and findbugs in particular)

  * Documentation

Clearly, there are some major documentation holes (how to build, how to release, etc), but also need docs for yetus-maven-plugin

  * Tests

My current plan is to commit this without ANY tests and fill those in later.  This includes the yetus-maven-plugin.  This is already a HUGE patch and I'd rather not bog down with a lot more.

  * BATS

Along that same line, I want to add a BATS driver to yetus-maven-plugin that effectively duplicates [Hadoop's run-bats|https://github.com/apache/hadoop/blob/6b8122458ede9ececb138bed99d368580e5439a1/hadoop-common-project/hadoop-common/src/test/scripts/run-bats.sh] script.

  * Website

I've made some efforts to get the website building, but not really enough to make this viable yet.  My current thinking is that we'd get the middleman version working until we can convert to maven site.  In particular, I'm debating forking https://github.com/devacfr/reflow-maven-skin into yetus-maven-skin.  I don't think a fork is avoidable, given some of the odd choices and lack of some customizations that I think we would want to do.  (I could be wrong of course).

  * Distribution

If you do a mvn package, you'll find in yetus-dist/target the apache-yetus-0.6.0-SNAPSHOT directory.  Close!

> build environment
> -----------------
>
>                 Key: YETUS-15
>                 URL: https://issues.apache.org/jira/browse/YETUS-15
>             Project: Yetus
>          Issue Type: Improvement
>          Components: Test Patch
>    Affects Versions: 0.1.0
>            Reporter: Allen Wittenauer
>            Assignee: Allen Wittenauer
>            Priority: Critical
>         Attachments: HADOOP-12137.HADOOP-12111.00.patch, HADOOP-12137.HADOOP-12111.01.patch, YETUS-15.000.patch, YETUS-15.ea-maven-001.patch
>
>
> We need to have some way to build (esp the documentation!) and unit tests.  



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)