You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by felixcheung <gi...@git.apache.org> on 2018/05/13 20:59:55 UTC
[GitHub] spark pull request #21314: [SPARK-24263] SparkR java check breaks with openj...
GitHub user felixcheung opened a pull request:
https://github.com/apache/spark/pull/21314
[SPARK-24263] SparkR java check breaks with openjdk
## What changes were proposed in this pull request?
Change text to grep for.
## How was this patch tested?
manual test
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/felixcheung/spark openjdkver
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/21314.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #21314
----
commit d972120c48b0c8528dc89b4f2a49ebda17f6b2aa
Author: Felix Cheung <fe...@...>
Date: 2018-05-13T20:58:35Z
change text
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21314: [SPARK-24263][R] SparkR java check breaks with openjdk
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/21314
Looks like this is good to go?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #21314: [SPARK-24263][R] SparkR java check breaks with op...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/21314#discussion_r187816505
--- Diff: R/pkg/R/client.R ---
@@ -82,7 +82,7 @@ checkJavaVersion <- function() {
})
javaVersionFilter <- Filter(
function(x) {
- grepl("java version", x)
+ grepl(" version", x)
--- End diff --
I tried a bit but couldn't unpack the tar inside the `archive.bin` (unzip first)
https://developer.ibm.com/javasdk/downloads/sdk8/
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21314: [SPARK-24263] SparkR java check breaks with openjdk
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21314
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #21314: [SPARK-24263][R] SparkR java check breaks with op...
Posted by shivaram <gi...@git.apache.org>.
Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/21314#discussion_r187816811
--- Diff: R/pkg/R/client.R ---
@@ -82,7 +82,7 @@ checkJavaVersion <- function() {
})
javaVersionFilter <- Filter(
function(x) {
- grepl("java version", x)
+ grepl(" version", x)
--- End diff --
I managed to get it to work. I think our grep should be fine.
```
root@8c0bc3bb4123:~/ibm-java-x86_64-80# ./jre/bin/java -version
java version "1.8.0_171"
Java(TM) SE Runtime Environment (build 8.0.5.15 - pxa6480sr5fp15-20180502_01(SR5 FP15))
IBM J9 VM (build 2.9, JRE 1.8.0 Linux amd64-64 Compressed References 20180425_385365 (JIT enabled, AOT enabled)
OpenJ9 - a7ffbfe
OMR - a531219
IBM - 59ef3dc)
JCL - 20180425_01 based on Oracle jdk8u171-b11
```
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21314: [SPARK-24263] SparkR java check breaks with openjdk
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21314
**[Test build #90558 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90558/testReport)** for PR 21314 at commit [`d972120`](https://github.com/apache/spark/commit/d972120c48b0c8528dc89b4f2a49ebda17f6b2aa).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21314: [SPARK-24263] SparkR java check breaks with openjdk
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/21314
@vanzin FYI - need to fix this before release
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21314: [SPARK-24263][R] SparkR java check breaks with openjdk
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21314
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21314: [SPARK-24263][R] SparkR java check breaks with openjdk
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21314
**[Test build #90558 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90558/testReport)** for PR 21314 at commit [`d972120`](https://github.com/apache/spark/commit/d972120c48b0c8528dc89b4f2a49ebda17f6b2aa).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #21314: [SPARK-24263][R] SparkR java check breaks with op...
Posted by shivaram <gi...@git.apache.org>.
Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/21314#discussion_r187815145
--- Diff: R/pkg/R/client.R ---
@@ -82,7 +82,7 @@ checkJavaVersion <- function() {
})
javaVersionFilter <- Filter(
function(x) {
- grepl("java version", x)
+ grepl(" version", x)
--- End diff --
do we want the space " version" vs. "version" that is
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21314: [SPARK-24263] SparkR java check breaks with openjdk
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21314
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3179/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21314: [SPARK-24263][R] SparkR java check breaks with openjdk
Posted by shivaram <gi...@git.apache.org>.
Github user shivaram commented on the issue:
https://github.com/apache/spark/pull/21314
Yes @felixcheung or @vanzin can you merge this ?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #21314: [SPARK-24263][R] SparkR java check breaks with op...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/21314#discussion_r187817762
--- Diff: R/pkg/R/client.R ---
@@ -82,7 +82,7 @@ checkJavaVersion <- function() {
})
javaVersionFilter <- Filter(
function(x) {
- grepl("java version", x)
+ grepl(" version", x)
--- End diff --
great! interesting it's only broken on openjdk then
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #21314: [SPARK-24263][R] SparkR java check breaks with op...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21314
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #21314: [SPARK-24263][R] SparkR java check breaks with op...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/21314#discussion_r187815502
--- Diff: R/pkg/R/client.R ---
@@ -82,7 +82,7 @@ checkJavaVersion <- function() {
})
javaVersionFilter <- Filter(
function(x) {
- grepl("java version", x)
+ grepl(" version", x)
--- End diff --
right, I debated about it. I think we should grep for the longest match as much as possible but I suppose the space is too common to be meaningful, so I don't feel strongly either way
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21314: [SPARK-24263] SparkR java check breaks with openjdk
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/21314
@shivaram
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21314: [SPARK-24263][R] SparkR java check breaks with openjdk
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21314
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90558/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #21314: [SPARK-24263][R] SparkR java check breaks with op...
Posted by shivaram <gi...@git.apache.org>.
Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/21314#discussion_r187815762
--- Diff: R/pkg/R/client.R ---
@@ -82,7 +82,7 @@ checkJavaVersion <- function() {
})
javaVersionFilter <- Filter(
function(x) {
- grepl("java version", x)
+ grepl(" version", x)
--- End diff --
Is there any chance you have access to IBM jdk ? I'm just wondering if there is some other java version we are missing
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21314: [SPARK-24263][R] SparkR java check breaks with openjdk
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/21314
Merging to master / 2.3.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org