[GitHub] [zookeeper] Shoothzj commented on a change in pull request #1574: ZOOKEEPER-4054: Make prometheus listen host can configure

[GitBox <gi...@apache.org>]

Shoothzj commented on a change in pull request #1574:
URL: https://github.com/apache/zookeeper/pull/1574#discussion_r593853439



##########
File path: zookeeper-metrics-providers/zookeeper-prometheus-metrics/src/test/java/org/apache/zookeeper/metrics/prometheus/PrometheusMetricsProviderTest.java
##########
@@ -56,6 +56,7 @@ public void setup() throws Exception {
         CollectorRegistry.defaultRegistry.clear();
         provider = new PrometheusMetricsProvider();
         Properties configuration = new Properties();
+        configuration.setProperty("httpHost", "127.0.0.1"); // local host for test
         configuration.setProperty("httpPort", "0"); // ephemeral port

Review comment:
       I think the port 0 is enough to covert this PR.
   By the way, try to import class `PortAssignment` which is a test class in `zookeeper-server` module, can't imported easily.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org