[GitHub] [spark] dongjoon-hyun commented on a change in pull request #35404: [SPARK-38118][SQL] Func(wrong data type) in HAVING clause should throw data mismatch error

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #35404:
URL: https://github.com/apache/spark/pull/35404#discussion_r808740696



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
##########
@@ -645,4 +645,8 @@ case class TempResolvedColumn(child: Expression, nameParts: Seq[String]) extends
   override def dataType: DataType = child.dataType
   override protected def withNewChildInternal(newChild: Expression): Expression =
     copy(child = newChild)
+
+  override def sql: String = {
+    s"${child.sql}"
+  }

Review comment:
       This looks a little redundant. Shall we revise like the following?
   ```scala
   override def sql: String = child.sql
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org