You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by lys0716 <gi...@git.apache.org> on 2017/05/20 04:47:24 UTC
[GitHub] spark pull request #18038: [MINOR][SPARKRSQL]Remove unnecessary comment in S...
GitHub user lys0716 opened a pull request:
https://github.com/apache/spark/pull/18038
[MINOR][SPARKRSQL]Remove unnecessary comment in SqlBase.g4
## What changes were proposed in this pull request?
The issue(https://github.com/antlr/antlr4/issues/781) in the comment is fixed in its duplicate ticket(https://github.com/antlr/antlr4/issues/781).
## How was this patch tested?
Existing tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lys0716/spark master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/18038.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #18038
----
commit 31e000ff87b299d9adfd4b8ee010817c57734bca
Author: lys0716 <lu...@gmail.com>
Date: 2017-05-20T04:42:05Z
Remove unnecessary comment in SqlBase.g4
The issue(// https://github.com/antlr/antlr4/issues/781) in the comment is fixed in its duplicate ticket(https://github.com/antlr/antlr4/issues/781).
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18038: [MINOR][SPARKRSQL]Remove unnecessary comment in SqlBase....
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/18038
It still leads to the underlying issue. Why remove?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18038: [MINOR][SPARKRSQL]Remove unnecessary comment in SqlBase....
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/18038
Ok, so close this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18038: [MINOR][SPARKRSQL]Remove unnecessary comment in SqlBase....
Posted by lys0716 <gi...@git.apache.org>.
Github user lys0716 commented on the issue:
https://github.com/apache/spark/pull/18038
Sorry, it is duplicate to https://github.com/antlr/antlr4/issues/773. But on the second thought, the rule is still a workaround for that issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #18038: [MINOR][SPARKRSQL]Remove unnecessary comment in S...
Posted by lys0716 <gi...@git.apache.org>.
Github user lys0716 closed the pull request at:
https://github.com/apache/spark/pull/18038
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18038: [MINOR][SPARKRSQL]Remove unnecessary comment in SqlBase....
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/18038
please change your title `SPARKRSQL` -> `SQL`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18038: [MINOR][SPARKRSQL]Remove unnecessary comment in SqlBase....
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18038
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org