You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/05/01 00:48:06 UTC
[GitHub] [incubator-pinot] npawar opened a new issue #5322: Enforce sending tableConfig to SegmentGeneratorConfig
npawar opened a new issue #5322:
URL: https://github.com/apache/incubator-pinot/issues/5322
We have 2 constructors for SegmentgeneratorConfig
1) SegmentGeneratorConfig(TableCofig, Schema)
2) SegmentgeneratorConfig()
We also have a lot of setters.
We need to finalize on one way of constructing SegmentGeneratorConfig - using tableConfig and schema. TableConfig should be made mandatory. That way we can get rid of a lot of setters.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] Jackie-Jiang commented on issue #5322: Enforce sending tableConfig to SegmentGeneratorConfig
Posted by GitBox <gi...@apache.org>.
Jackie-Jiang commented on issue #5322:
URL: https://github.com/apache/incubator-pinot/issues/5322#issuecomment-625519376
Cleanup the PinotOutputFormat: #5350
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] Jackie-Jiang commented on issue #5322: Enforce sending tableConfig to SegmentGeneratorConfig
Posted by GitBox <gi...@apache.org>.
Jackie-Jiang commented on issue #5322:
URL: https://github.com/apache/incubator-pinot/issues/5322#issuecomment-624379564
Cleanup the clone constructor: #5338
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] npawar commented on issue #5322: Enforce sending tableConfig to SegmentGeneratorConfig
Posted by GitBox <gi...@apache.org>.
npawar commented on issue #5322:
URL: https://github.com/apache/incubator-pinot/issues/5322#issuecomment-622194667
FYI @Jackie-Jiang
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org