You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/06/07 03:14:55 UTC
[GitHub] [hudi] xushiyan commented on a change in pull request #1698: [HUDI-986] Support staging site for per pull request
xushiyan commented on a change in pull request #1698:
URL: https://github.com/apache/hudi/pull/1698#discussion_r436319767
##########
File path: docs/_pages/contributing.cn.md
##########
@@ -25,7 +25,7 @@ To contribute code, you need
To contribute, you would need to do the following
- - Fork the Hudi code on Github & then clone your own fork locally. Once cloned, we recommend building as per instructions on [quickstart](/docs/quick-start-guide.html)
+ - Fork the Hudi code on Github & then clone your own fork locally. Once cloned, we recommend building as per instructions on [quickstart]({{ site.baseurl }}/docs/quick-start-guide.html)
Review comment:
seems like `cn` files need double slash?
```suggestion
- Fork the Hudi code on Github & then clone your own fork locally. Once cloned, we recommend building as per instructions on [quickstart]({{ site.baseurl }}/cn/docs//quick-start-guide.html)
```
##########
File path: docs/_docs/0_3_migration_guide.cn.md
##########
@@ -52,7 +52,7 @@ for partition in [list of partitions in source dataset] {
**Option 3**
Write your own custom logic of how to load an existing dataset into a Hudi managed one. Please read about the RDD API
- [here](/cn/docs/quick-start-guide.html). Using the HDFSParquetImporter Tool. Once hudi has been built via `mvn clean install -DskipTests`, the shell can be
+ [here]({{ site.baseurl }}/cn/docs//quick-start-guide.html). Using the HDFSParquetImporter Tool. Once hudi has been built via `mvn clean install -DskipTests`, the shell can be
Review comment:
`-DskipITs` as well?
##########
File path: docs/_pages/releases.cn.md
##########
@@ -7,7 +7,7 @@ last_modified_at: 2019-12-30T15:59:57-04:00
language: cn
---
-## [Release 0.5.2-incubating](https://github.com/apache/hudi/releases/tag/release-0.5.2-incubating) ([docs](/docs/0.5.2-quick-start-guide.html))
+## [Release 0.5.2-incubating](https://github.com/apache/hudi/releases/tag/release-0.5.2-incubating) ([docs]({{ site.baseurl }}/docs/0.5.2-quick-start-guide.html))
Review comment:
ditto
##########
File path: docs/_pages/releases.cn.md
##########
@@ -33,7 +33,7 @@ temp_query --sql "select Instant, NumInserts, NumWrites from satishkotha_debug w
### Raw Release Notes
The raw release notes are available [here](https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12322822&version=12346606)
-## [Release 0.5.1-incubating](https://github.com/apache/hudi/releases/tag/release-0.5.1-incubating) ([docs](/docs/0.5.1-quick-start-guide.html))
+## [Release 0.5.1-incubating](https://github.com/apache/hudi/releases/tag/release-0.5.1-incubating) ([docs]({{ site.baseurl }}/docs/0.5.1-quick-start-guide.html))
Review comment:
ditto
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org