You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2022/09/29 17:53:05 UTC

[GitHub] [lucene] mdmarshmallow opened a new pull request, #11831: GITHUB-11761: Move minimum TieredMergePolicy delete percentage from 2…

mdmarshmallow opened a new pull request, #11831:
URL: https://github.com/apache/lucene/pull/11831

   …0% to 5%
   
   ### Description
   
   <!--
   If this is your first contribution to Lucene, please make sure you have reviewed the contribution guide.
   https://github.com/apache/lucene/blob/main/CONTRIBUTING.md
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene] mdmarshmallow commented on pull request #11831: GITHUB-11761: Move minimum TieredMergePolicy delete percentage from 2…

Posted by GitBox <gi...@apache.org>.
mdmarshmallow commented on PR #11831:
URL: https://github.com/apache/lucene/pull/11831#issuecomment-1272635717

   These new tests did fail, I created a new PR (tied to the same issue as this one) to more cleanly fix the unit tests without having to change the default percentage: https://github.com/apache/lucene/pull/11841.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene] jpountz commented on pull request #11831: GITHUB-11761: Move minimum TieredMergePolicy delete percentage from 2…

Posted by GitBox <gi...@apache.org>.
jpountz commented on PR #11831:
URL: https://github.com/apache/lucene/pull/11831#issuecomment-1269633237

   Why did we have to update the number of allowed deletes back to 33% on some tests, did they fail otherwise? Is there another way how we could improve these tests to cope better with the new default?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene] jpountz commented on pull request #11831: GITHUB-11761: Move minimum TieredMergePolicy delete percentage from 2…

Posted by GitBox <gi...@apache.org>.
jpountz commented on PR #11831:
URL: https://github.com/apache/lucene/pull/11831#issuecomment-1269635726

   E.g. maybe it would be better to add more documents in `testNRTIsCurrentAfterDelete` in order for the single delete not to introduce more than 20% deletes, and keep the `TieredMergePolicy` defaults?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene] zhaih commented on pull request #11831: GITHUB-11761: Move minimum TieredMergePolicy delete percentage from 2…

Posted by GitBox <gi...@apache.org>.
zhaih commented on PR #11831:
URL: https://github.com/apache/lucene/pull/11831#issuecomment-1269059590

   Thanks @mdmarshmallow! I merged and backported it!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene] zhaih merged pull request #11831: GITHUB-11761: Move minimum TieredMergePolicy delete percentage from 2…

Posted by GitBox <gi...@apache.org>.
zhaih merged PR #11831:
URL: https://github.com/apache/lucene/pull/11831


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org