You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by vo...@apache.org on 2022/09/06 19:17:52 UTC
[myfaces] branch 3.0.x updated: MYFACES-4450: render tabindex for outputLabel; update test
This is an automated email from the ASF dual-hosted git repository.
volosied pushed a commit to branch 3.0.x
in repository https://gitbox.apache.org/repos/asf/myfaces.git
The following commit(s) were added to refs/heads/3.0.x by this push:
new 6b2796cc8 MYFACES-4450: render tabindex for outputLabel; update test
new 0d7843951 Merge pull request #308 from volosied/MYFACES-4450-3.0
6b2796cc8 is described below
commit 6b2796cc8f75cf268b6ed0b7ef1b3741208fbeeb
Author: Volodymyr Siedlecki <vo...@gmail.com>
AuthorDate: Fri Sep 2 09:56:47 2022 -0400
MYFACES-4450: render tabindex for outputLabel; update test
---
.../org/apache/myfaces/renderkit/html/HtmlLabelRendererTest.java | 1 +
.../apache/myfaces/shared/renderkit/html/CommonPropertyUtils.java | 6 +-----
2 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/impl/src/test/java/org/apache/myfaces/renderkit/html/HtmlLabelRendererTest.java b/impl/src/test/java/org/apache/myfaces/renderkit/html/HtmlLabelRendererTest.java
index 0d3727e88..4e7f99438 100644
--- a/impl/src/test/java/org/apache/myfaces/renderkit/html/HtmlLabelRendererTest.java
+++ b/impl/src/test/java/org/apache/myfaces/renderkit/html/HtmlLabelRendererTest.java
@@ -91,6 +91,7 @@ public class HtmlLabelRendererTest extends AbstractJsfConfigurableMockTestCase
HtmlRenderedAttr[] attrs = {
//_AccesskeyProperty
new HtmlRenderedAttr("accesskey"),
+ new HtmlRenderedAttr("tabindex"),
//_UniversalProperties
new HtmlRenderedAttr("dir"),
new HtmlRenderedAttr("lang"),
diff --git a/shared/src/main/java/org/apache/myfaces/shared/renderkit/html/CommonPropertyUtils.java b/shared/src/main/java/org/apache/myfaces/shared/renderkit/html/CommonPropertyUtils.java
index daa875a5e..213b334ed 100644
--- a/shared/src/main/java/org/apache/myfaces/shared/renderkit/html/CommonPropertyUtils.java
+++ b/shared/src/main/java/org/apache/myfaces/shared/renderkit/html/CommonPropertyUtils.java
@@ -531,11 +531,7 @@ public final class CommonPropertyUtils
long commonPropertiesMarked, UIComponent component)
throws IOException
{
- if ((commonPropertiesMarked & CommonPropertyConstants.ACCESSKEY_PROP) != 0)
- {
- HtmlRendererUtils.renderHTMLStringAttribute(writer, component,
- HTML.ACCESSKEY_ATTR, HTML.ACCESSKEY_ATTR);
- }
+ renderAccesskeyTabindexProperties(writer, commonPropertiesMarked, component);
renderCommonPassthroughPropertiesWithoutEvents(writer, commonPropertiesMarked, component);
}