[GitHub] [echarts] pissang commented on a change in pull request #15309: fix(bar): set label to be inside when position is middle

[GitBox <gi...@apache.org>]

pissang commented on a change in pull request #15309:
URL: https://github.com/apache/echarts/pull/15309#discussion_r665847939



##########
File path: src/chart/bar/BarView.ts
##########
@@ -982,6 +982,9 @@ function updateStyle(
 
     if (isPolar) {
         const position = seriesModel.get(['label', 'position']);
+        if (position === 'middle') {
+            el.textConfig.inside = true;

Review comment:
       Should always set `inside` property to avoid current configuration leaking to the next render.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org