You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by "xyuanlu (via GitHub)" <gi...@apache.org> on 2023/09/19 00:56:19 UTC

[GitHub] [helix] xyuanlu commented on a diff in pull request #2618: add APIs for evacuation

xyuanlu commented on code in PR #2618:
URL: https://github.com/apache/helix/pull/2618#discussion_r1329428862


##########
helix-core/src/main/java/org/apache/helix/HelixAdmin.java:
##########
@@ -738,4 +738,15 @@ Map<String, Boolean> validateResourcesForWagedRebalance(String clusterName,
    */
   Map<String, Boolean> validateInstancesForWagedRebalance(String clusterName,
       List<String> instancesNames);
+
+  /**
+   * Return if instance operation 'Evacuate' is finished.
+   * Only return true if there is no current state on the instance and that instance is still alive.
+   * @param clusterName
+   * @param instancesNames
+   * @return
+   */
+  boolean isEvacuateFinished(String clusterName, String instancesNames);
+
+  boolean isPrepopulateReady(String clusterName, String instancesNames);

Review Comment:
   TFTR. Updated.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org