You are viewing a plain text version of this content. The canonical link for it is here.
Posted to slide-dev@jakarta.apache.org by re...@apache.org on 2001/01/05 18:06:41 UTC
cvs commit: jakarta-slide/src/webdav/server/org/apache/slide/webdav/method MkcolMethod.java
remm 01/01/05 09:06:41
Modified: src/webdav/server/org/apache/slide/webdav/method
MkcolMethod.java
Log:
- Oops, I had commited the wrong file ...
- When processing an MKCOL request, a failure because an
AccessDeniedException occured was reported as a success.
Bug reported by Rama Kurapati.
Revision Changes Path
1.3 +7 -7 jakarta-slide/src/webdav/server/org/apache/slide/webdav/method/MkcolMethod.java
Index: MkcolMethod.java
===================================================================
RCS file: /home/cvs/jakarta-slide/src/webdav/server/org/apache/slide/webdav/method/MkcolMethod.java,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- MkcolMethod.java 2000/11/25 01:36:10 1.2
+++ MkcolMethod.java 2001/01/05 17:06:41 1.3
@@ -1,7 +1,7 @@
/*
- * $Header: /home/cvs/jakarta-slide/src/webdav/server/org/apache/slide/webdav/method/MkcolMethod.java,v 1.2 2000/11/25 01:36:10 remm Exp $
- * $Revision: 1.2 $
- * $Date: 2000/11/25 01:36:10 $
+ * $Header: /home/cvs/jakarta-slide/src/webdav/server/org/apache/slide/webdav/method/MkcolMethod.java,v 1.3 2001/01/05 17:06:41 remm Exp $
+ * $Revision: 1.3 $
+ * $Date: 2001/01/05 17:06:41 $
*
* ====================================================================
*
@@ -217,6 +217,9 @@
}
+ // If everything is ok : 201 - Created / OK
+ resp.setStatus(WebdavStatus.SC_CREATED);
+
try {
structure.create(slideToken, collection, colName);
content.create(slideToken, colName, revisionDescriptor, null);
@@ -240,7 +243,7 @@
throw new WebdavException(WebdavStatus.SC_METHOD_NOT_ALLOWED);
} catch (AccessDeniedException e) {
resp.setStatus(WebdavStatus.SC_FORBIDDEN);
- //throw new WebdavException(WebdavStatus.SC_FORBIDDEN);
+ throw new WebdavException(WebdavStatus.SC_FORBIDDEN);
}
// 415 - Unsupported Media Type
@@ -252,9 +255,6 @@
// return an Internal Server Error, which is probably acceptable.
// TODO : Initialize and create collection's properties.
-
- // 201 - Created / OK
- resp.setStatus(WebdavStatus.SC_CREATED);
}