You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "paleolimbot (via GitHub)" <gi...@apache.org> on 2023/02/23 15:08:54 UTC
[GitHub] [arrow-nanoarrow] paleolimbot opened a new pull request, #116: fix: Correct storage type for timestamp and duration types
paleolimbot opened a new pull request, #116:
URL: https://github.com/apache/arrow-nanoarrow/pull/116
After spending some quality time with https://github.com/apache/arrow/blob/main/format/Schema.fbs recently, I noticed that the storage types for timestamp and duration types were incorrect: they are always 64-bit integers (as opposed to the time type, which switches width depending on the unit).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-nanoarrow] paleolimbot merged pull request #116: fix: Correct storage type for timestamp and duration types
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot merged PR #116:
URL: https://github.com/apache/arrow-nanoarrow/pull/116
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-nanoarrow] codecov-commenter commented on pull request #116: fix: Correct storage type for timestamp and duration types
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #116:
URL: https://github.com/apache/arrow-nanoarrow/pull/116#issuecomment-1441964814
# [Codecov](https://codecov.io/gh/apache/arrow-nanoarrow/pull/116?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#116](https://codecov.io/gh/apache/arrow-nanoarrow/pull/116?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a500eb0) into [main](https://codecov.io/gh/apache/arrow-nanoarrow/commit/2750d852589e31b4c83bce7361c60ade4a010013?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2750d85) will **not change** coverage.
> The diff coverage is `94.44%`.
```diff
@@ Coverage Diff @@
## main #116 +/- ##
=======================================
Coverage 92.91% 92.91%
=======================================
Files 7 7
Lines 1652 1652
Branches 52 52
=======================================
Hits 1535 1535
Misses 84 84
Partials 33 33
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-nanoarrow/pull/116?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [src/nanoarrow/array\_stream.c](https://codecov.io/gh/apache/arrow-nanoarrow/pull/116?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL25hbm9hcnJvdy9hcnJheV9zdHJlYW0uYw==) | `87.50% <93.54%> (ø)` | |
| [src/nanoarrow/schema.c](https://codecov.io/gh/apache/arrow-nanoarrow/pull/116?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL25hbm9hcnJvdy9zY2hlbWEuYw==) | `93.70% <100.00%> (ø)` | |
| [src/nanoarrow/utils.c](https://codecov.io/gh/apache/arrow-nanoarrow/pull/116?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL25hbm9hcnJvdy91dGlscy5j) | `99.04% <100.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org